Received: by 10.192.165.156 with SMTP id m28csp1512133imm; Wed, 18 Apr 2018 10:48:56 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+YFvw8fN+tMTDJ/I982ChoAMZ+AOtzerYgXn/EmOyiC4wY5P7PWhqkWj8uB1rFiiaseMHZ X-Received: by 10.167.130.22 with SMTP id k22mr2824351pfi.73.1524073736876; Wed, 18 Apr 2018 10:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524073736; cv=none; d=google.com; s=arc-20160816; b=kyF4G2QJxOj2NZOghdPtHG2v0i3ZzOlgglHPetm/r36CYbGnm6Rx7SWFtf6fyNaBIk mt9f1y7Qd7aoqbAPgAolpTrT8MQ7iQT+b4BouKVFYMO+junrVqd6hukuNIJYo+eEOrgm U2baTl0OzuiJ2B8Mxnj3LN8OXImn0m1R+7UHpVAa1ky5wsuY3jG3i4MxjZLElJ9T4Eqv UlYKtIUD/QqvmzspyL81u8h2V3Ajph/F9Hjr+Aefc+CF+Fuocs92Hfm4d5/g9Y86c/kz hbb802DtiZwrHzBl4rk7exYF3hfTWJ3OTuahi1wZ/fMsaS6XSevrQUzPRaPPaaOjIHbG nxXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=7w1NdafOics/sCozuzhlUutugN1UaYv30Vz4wqeBhFM=; b=Y1gmLxGGZF8sAMH5Z3Bpb6Jmr1be5dBsMdpIl9iQi+YFjGwOP/25+bsr1FkXZXw82k 8rC8z0MFTXTIa2iF6+21LJVTmHKqX+8Gh0nSMU81Ja6CTUkKaSpqg0Cfy3cyy6u1Ws8V w4h7FL9/Xt5iIy+a6s8ygTS5GzcEyJjn8tZdyWtvK8Gst/KRnz5dscs36LD51be5WaeT fQusz5OyWbkIpaWT0WLOsV6+8Dgqz/SGBRXBaKAvp12r+KSyqYUoNlHuSF5rYdEmPtwl fFp8rnhreudTYfy9JeVBx2A7q5mVw+jvvyXrYkacrDgcz/zBvdZe3YOHzNq6g7uwRYex 1ACQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r19si1469275pfd.267.2018.04.18.10.48.43; Wed, 18 Apr 2018 10:48:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbeDRRrY (ORCPT + 99 others); Wed, 18 Apr 2018 13:47:24 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbeDRRrX (ORCPT ); Wed, 18 Apr 2018 13:47:23 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0BB531438BF05; Wed, 18 Apr 2018 10:47:21 -0700 (PDT) Date: Wed, 18 Apr 2018 13:47:21 -0400 (EDT) Message-Id: <20180418.134721.283381724211219025.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: mpatocka@redhat.com, edumazet@google.com, joby.poriyath@citrix.com, bhutchings@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] net: don't use kvzalloc for DMA memory From: David Miller In-Reply-To: <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Apr 2018 10:47:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Wed, 18 Apr 2018 09:51:25 -0700 > I suggest that virtio_net clearly identifies which part needs a specific allocation > and does its itself, instead of abusing the netdev_priv storage. > > Ie use a pointer to a block of memory, allocated by virtio_net, for virtio_net. +1