Received: by 10.192.165.156 with SMTP id m28csp1518230imm; Wed, 18 Apr 2018 10:55:37 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+EFfCAM5g1pRiyDk8pMq9wBMFvn1+9TlU49Jyf2xM8uBG4CJ/YOCmm7Y5aIVAnzQiSPcEL X-Received: by 10.99.110.6 with SMTP id j6mr2425013pgc.29.1524074137577; Wed, 18 Apr 2018 10:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524074137; cv=none; d=google.com; s=arc-20160816; b=mcPdu7l9H6wXOLiVe2cBRRRPECjiQKaLAfHZ/28YcwDglwCH7678gVQ9Kw+6zo/7Wz OYFJbjmn13zU37Cq6y9XRJqc41TJtYB7IYECaEY7/C29/mCCZ5KnazoeGuxM3MDqECX8 Ba3S0Md2R0VdVSK7BSDdEf3qeEMDDn84G3kxaMn+tdgEsxOCPvKJKoVbHFQ2KtuzMr6L n5mqiCxL6z3etWJn4xWsbLXfIGaxM8BAo+E779j3tfoW44ZvdyiYBjskts74Q6kBHk4S t4T8za5vX0KTTyGlWlCvcgumuHnViT30kid79e446yipT+AHDommPaTrRYK3nYGlsXPW obDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=wvDtP/fsl1iDFsodQPJyrLaAsBEQy/mir4hPd5ypzmo=; b=D6cay2Gwza1Fxnbs5yr/YrYaWYrP9ZPg5pRMB8kYexPe8eUD4uttOuQDRx84HxOZ8q MhAgPxLbBklWc5dHE4+ApW77KiYddna7hIe27sba0uM+RA5plP684+xbJgV+KaO27N8a +XpMNICeXDHW81JlSm/+wHeNQnYxYKyZHmkLLnnXUxM1JjKXECX5hy+Fb+27sBEtkUvu 6wH3UeGur35s9zfEG+/Y10SzwMFpwIzk0jmEf5NF8vtVopGszkwUrJ2wRSWNLpFxt7bT GSq+KxUk1qGPsyAY+EC5du29roNA8H0h536C2q5eC52LpKZs53Txk9O+2pW+ScGqRGuA Eauw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si1054913pgv.313.2018.04.18.10.55.23; Wed, 18 Apr 2018 10:55:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbeDRRyB (ORCPT + 99 others); Wed, 18 Apr 2018 13:54:01 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751830AbeDRRyA (ORCPT ); Wed, 18 Apr 2018 13:54:00 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A230240201A4; Wed, 18 Apr 2018 17:53:59 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9446F2166BAE; Wed, 18 Apr 2018 17:53:59 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id w3IHrxnR019388; Wed, 18 Apr 2018 13:53:59 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id w3IHrxNJ019384; Wed, 18 Apr 2018 13:53:59 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Wed, 18 Apr 2018 13:53:59 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: David Miller cc: eric.dumazet@gmail.com, edumazet@google.com, bhutchings@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] net: don't use kvzalloc for DMA memory In-Reply-To: <20180418.134651.2225112489265654270.davem@davemloft.net> Message-ID: References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <20180418.134651.2225112489265654270.davem@davemloft.net> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 18 Apr 2018 17:53:59 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 18 Apr 2018 17:53:59 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mpatocka@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Apr 2018, David Miller wrote: > From: Mikulas Patocka > Date: Wed, 18 Apr 2018 12:44:25 -0400 (EDT) > > > The structure net_device is followed by arbitrary driver-specific data > > (accessible with the function netdev_priv). And for virtio-net, these > > driver-specific data must be in DMA memory. > > And we are saying that this assumption is wrong and needs to be > corrected. So, try to find all the networking drivers that to DMA to the private area. The problem here is that kvzalloc usually returns DMA-able area, but it may return non-DMA area rarely, if the memory is too fragmented. So, we are in a situation, where some networking drivers will randomly fail. Go and find them. Mikulas