Received: by 10.192.165.156 with SMTP id m28csp1519577imm; Wed, 18 Apr 2018 10:57:05 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/775OZucB4zcSV11j0uPtRRKVRDNpGrUWCwUpDkS1TJ8U7bH54WXYUIT5XRdoIODuqkYpY X-Received: by 2002:a17:902:b191:: with SMTP id s17-v6mr2919368plr.339.1524074225106; Wed, 18 Apr 2018 10:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524074225; cv=none; d=google.com; s=arc-20160816; b=xKSB1auIKllxz4ePKDu93MbA4kybGK2K0mU1BHrAXgodndd/Px9F+0v2EztAbT118I 47xdAIbNLVWB3fRVwu0jjgeLffuhVbvWvTx8kOQsXXbo65zPO5r8WMN/z9JICxioqfDQ YraBcF1bEE4p1ePvB/MHT5rklHI0+Hyq88GdE6HFOk0PUrAk0OWql9ptfJ21iW4966yy /AaagxboiqGVwaKc6GqxbywEfkTrNiRBOEPPcomao0z7hXyImaejlusmeHt+u4ybuoib ehoQUAlJNtL9oC5YlW4Un3wgS7qyer04bWtWWOMROxyQEpHHBFE3LmZ0Mau8x7R2eIro N1/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=5tckTo+ZRFE7iKcAdu2putQrmntJetEcAogkw58WsRg=; b=tW++ZxB5umm/CnbWRjHLuLEqc+/aU5gwvfHmbPSJgIOTRTORGeinoOjJ9H07QGBvBU Hkd8q8/z9FyTY9NvQPZLlVo66rKTaT+Cr8YUjONO3BaDLgkJzh4l9d7UzjWU1uhJd6kx /tfj6o2iiMTVR8gOmNaol+UxYsHdyqywPcFZCBh2ty87hGj2lCwh4rviYnD+oJP22NV/ R/E/jKoKIMlXgAeiT2+E36G+KptdRtuEyZCmjhdcPrtkHSNGFj1RtJUsrXngFB78iqNS gwoh6XufjkcZpZ7IwI4MOf+pTxlfzWRxcG8nbiiLCGiWif7qdTnYC+tXyutLhUx2ycY4 yKRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10-v6si1622832plv.563.2018.04.18.10.56.51; Wed, 18 Apr 2018 10:57:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbeDRRzj (ORCPT + 99 others); Wed, 18 Apr 2018 13:55:39 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752687AbeDRRzW (ORCPT ); Wed, 18 Apr 2018 13:55:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B8CCD7CBBA; Wed, 18 Apr 2018 17:55:21 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7C2D2026DFD; Wed, 18 Apr 2018 17:55:21 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id w3IHtLTc019512; Wed, 18 Apr 2018 13:55:21 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id w3IHtLjc019508; Wed, 18 Apr 2018 13:55:21 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Wed, 18 Apr 2018 13:55:21 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: David Miller cc: eric.dumazet@gmail.com, edumazet@google.com, joby.poriyath@citrix.com, bhutchings@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] net: don't use kvzalloc for DMA memory In-Reply-To: <20180418.134721.283381724211219025.davem@davemloft.net> Message-ID: References: <3e65977e-53cd-bf09-bc4b-0ce40e9091fe@gmail.com> <5f4e1286-b79f-0b9f-9a30-47d7654f3889@gmail.com> <20180418.134721.283381724211219025.davem@davemloft.net> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 18 Apr 2018 17:55:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 18 Apr 2018 17:55:21 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mpatocka@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Apr 2018, David Miller wrote: > From: Eric Dumazet > Date: Wed, 18 Apr 2018 09:51:25 -0700 > > > I suggest that virtio_net clearly identifies which part needs a specific allocation > > and does its itself, instead of abusing the netdev_priv storage. > > > > Ie use a pointer to a block of memory, allocated by virtio_net, for virtio_net. > > +1 And what about the other networking drivers that may do the same thing? Mikulas