Received: by 10.192.165.156 with SMTP id m28csp1639318imm; Wed, 18 Apr 2018 13:06:27 -0700 (PDT) X-Google-Smtp-Source: AIpwx491cAgVtKo5ftHfsfIRM5WV5HsGmQducDQ1hQy7Z+HoN6x2PWbHwD7WT8hNG5+/XhtCI46S X-Received: by 10.101.74.201 with SMTP id c9mr2730046pgu.26.1524081987669; Wed, 18 Apr 2018 13:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524081987; cv=none; d=google.com; s=arc-20160816; b=FslYudWDsqRiYrdukJZfJUDtG0asTBFpR1VSNLNhAdWuXXMmkI+R4Mk5Wx4wuszlKZ xQlwvTNnN4NlZQ1Y7XExuiRUE2mEQQSyizBv+DOW+z3/BDMGJzINOIp/X5p3JiHCaVOA PXKKjeuNJG1iE1CQ05h4iS7a0AcWI2GTjLgK3lVEWxNlWhldhvtevH5e23dfrs8J5BZ9 +B1il2tgNc54Gw9HIOUgp24AbI/RuDMAdM7mmK7mwJTIJk5ZoVcuPzeHI0+21LQ4sVp1 g8VdWtxlnOaRiL6UQUDhW09arfcqh/te4OUFxhBrgyj+cHCbqRnW5Hox3otXvodt5xhn ZpVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=V7La1uQiyQslY1TzDSQ/JdeyAZYAY5CKQbXvhbxVYY0=; b=oKcVGuf/RJcnSitaR7SJM66w3bhXitq8hBxtdkizwYJk19QD7QgJUYFjPxLEmDc84w 5bp3RVLMEiSTllUk95z+XVgtXO0o4/gAURDofSd3tISzJzfPzmpUrjhdYHypasiXbyAf LBX9BZL0ghHGhQmHjNkfgAYXODckzMMqnpRljfSOuDBo7O7QxqwVj4rxg4dxGyiRDnzJ xuVniDWqeuTfGEpXDaDxoO4GL6FocLQxecVCKuj8Vv6JbHnnFPUl4GVO+FoCfPPYpFql Bup+dXxj03aMzZQ0geAuRpvwxsyH/oFUa2F6+0rZVHOzXzUZAKGWvZGzDX/5AxV8iTQi i25A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=fU8ayK73; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si1733578ple.584.2018.04.18.13.06.13; Wed, 18 Apr 2018 13:06:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=fU8ayK73; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbeDRUDu (ORCPT + 99 others); Wed, 18 Apr 2018 16:03:50 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:58080 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbeDRUDs (ORCPT ); Wed, 18 Apr 2018 16:03:48 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3IJuoUj061979; Wed, 18 Apr 2018 20:03:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=V7La1uQiyQslY1TzDSQ/JdeyAZYAY5CKQbXvhbxVYY0=; b=fU8ayK73SCaYV3oW0StGKKvj2PSuZZ788FNlHAtxe+l/JkqXkJRAxmP3Ag+5cj2MHTxN V2WuM3tIpy+Dl0/MA1hZP/L2IP5hJJM8UX0LhBMOfuJ/QjPQUo0yYxtdRySzhJcPhKNh mJ0Q4C+VvbUH68U/XxuHgmCr+lQLdh+E77JjwYnrZwdVwK0+frtRd9mBSImy43b8emag H297Nj/xLn+YQg5JA3uTl228xVoKAaWWPLG3JHNZxxkAZ7Gm84umvbvnbdVsq3YXIU5a VovwMg+/W3X+40FsowHwgLx0uSWOU28Q8qPKgspB/gypWgL9jfkxAyOA9uOcxWhzSQYM Vg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2hdrxncdyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Apr 2018 20:03:39 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w3IK3dCG028893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Apr 2018 20:03:39 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3IK3cwY019105; Wed, 18 Apr 2018 20:03:38 GMT Received: from [10.154.178.224] (/10.154.178.224) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 18 Apr 2018 13:03:38 -0700 Subject: Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI driver To: Shuah Khan , davem@davemloft.net Cc: sparclinux@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, allen.pais@oracle.com, khalid.aziz@oracle.com, shannon.nelson@oracle.com, anthony.yznaga@oracle.com, Shuah Khan References: <20180418162958.442909-1-tom.hromatka@oracle.com> <20180418162958.442909-3-tom.hromatka@oracle.com> <6ef81e28-7656-ccf5-5d4d-ef315ae250ce@kernel.org> From: Tom Hromatka Message-ID: Date: Wed, 18 Apr 2018 14:03:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6ef81e28-7656-ccf5-5d4d-ef315ae250ce@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8867 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=776 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804180180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/2018 01:58 PM, Shuah Khan wrote: > Hi Tom, > > On 04/18/2018 10:29 AM, Tom Hromatka wrote: >> Add a selftest for the sparc64 privileged ADI driver. These >> tests verify the read(), pread(), write(), pwrite(), and seek() >> functionality of the driver. The tests also report simple >> performance statistics: >> >> Syscall Call AvgTime AvgSize >> Count (ticks) (bytes) >> ------------------------------- >> read 3 167134 8133 >> pread 4 137217 6741 >> write 3 73787 8133 >> pwrite 4 65832 6741 >> seek 10 2422 0 >> >> Ran 8 tests >> All tests passed >> >> Signed-off-by: Tom Hromatka >> Reviewed-by: Allen Pais > Thanks for the patch. A few comments below: Thanks for the quick turnaround, Shuah.  I'll work through your comments and get a v2 out in the next few days. Regards. Tom