Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 18 Apr 2018 22:38:09 +0200
From:   "Luis R. Rodriguez" <mcgrof@kernel.org>
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw
 path back on exit, second try
Message-ID: <20180418203808.GQ30543@wotan.suse.de>
References: <20180404203712.zecit6po44qsde4c@xylophone.i.decadent.org.uk>
 <20180404203848.3txsangsvaxtxsu4@xylophone.i.decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180404203848.3txsangsvaxtxsu4@xylophone.i.decadent.org.uk>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter.  This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
> 
> Instead, write a null byte.
> 
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>

Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>

Greg, let me know if you want to take these two in now, or if you want me to
queue them up on my own and then send you what I get in the queue later.

  Luis