Received: by 10.192.165.156 with SMTP id m28csp1720249imm; Wed, 18 Apr 2018 14:46:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/PokRkvOFEbUgcRb6QmbJHEArNY3kfE8atFAnG4akAjZBJjig8FdpOIFnN211PsaodgHNj X-Received: by 10.101.64.201 with SMTP id u9mr3031358pgp.142.1524087962810; Wed, 18 Apr 2018 14:46:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524087962; cv=none; d=google.com; s=arc-20160816; b=Tj0P+8KzwDOS1Fi2DXL4ij87juqTqFVhvMW1Ztd++FCl1PG9rBoWK9nKMg3yAAaxOl yTQMbOE4n5uNvNbZV0qaiLLjHsInFc39GAL5oo+eBIt0MqCB6hbaoc1ezTpaAzRLU4ID ut/6Baqtas5o9+93gfBfH2t3BA+gnH7QOdmT+HngD6sjqARfVQnva0OjIyH4CQeFZ5T8 BwSCD99UFxB/fMmG4QqRb2CvLZ7IOcJ3NabTHfE1PmMgmgttYMCeJo2QnDR/4QKe/0LL PpBjGbbRwD3hgCm70uBENJLtxZaebcn8F8KK3xMKvom3Cw9NQeatJ2bPuqUHrkEfm8Lg 44Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=XIYGu81ZURfScCLvBZrmhjCf5gqnSPzNbUrAa5W/KF8=; b=H1LFrJUJA0VIssHQTGuG12lwW+Mx1rZW2d4Ks6xU9QBZMx0kV43F4fKqrfyhUZIakT Ltm26As1JSncncdsZw4r1DILDMdbhg8Mk/OY4mP1cGIYmclm8b5j0lR5/fBJYd4UyE/s XPik1VIWECDnpN+qOsChN7SXSwNE05I+zLdp5vr8rMPfMxzYzo1rgaFIMBNSh/QtQI3q 4365nb5dzVtDJw9lUHCCphW3g1R8NZHdiFhuh8KKteandlPfsN/GL+mY011K3AvSTxCc RjVS5UzU16dGRdeJt81BcL2tAlnKjZ9IX8roLmzmLhRTSO/fEoRLs3G3mPElaWPhaQ8V myzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lSOJbjy6; dkim=pass header.i=@codeaurora.org header.s=default header.b=lSOJbjy6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay12-v6si1797015plb.554.2018.04.18.14.45.45; Wed, 18 Apr 2018 14:46:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lSOJbjy6; dkim=pass header.i=@codeaurora.org header.s=default header.b=lSOJbjy6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbeDRVoO (ORCPT + 99 others); Wed, 18 Apr 2018 17:44:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33876 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbeDRVoM (ORCPT ); Wed, 18 Apr 2018 17:44:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D90A360C64; Wed, 18 Apr 2018 21:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524087851; bh=hWbQgUoL9PsPDUaWIjQmP8aT135AKroqKxrZJy6Ou5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lSOJbjy61hs9BUxWppDUxUzqwd8iXOTKTOv794ChzoD7SxSrb+qURvVhldZUWL5K6 MKmDf6BA5pRTB3IPSI6whgFGylk2JNGXo16x8EoxAUsFdG+LdxU0omxchhk12TIHxS OkkoGLpUD26ZHq951UtTOMz7G+yJGa08RSunScis= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.46.164.143] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: collinsd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6711601E6; Wed, 18 Apr 2018 21:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524087851; bh=hWbQgUoL9PsPDUaWIjQmP8aT135AKroqKxrZJy6Ou5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lSOJbjy61hs9BUxWppDUxUzqwd8iXOTKTOv794ChzoD7SxSrb+qURvVhldZUWL5K6 MKmDf6BA5pRTB3IPSI6whgFGylk2JNGXo16x8EoxAUsFdG+LdxU0omxchhk12TIHxS OkkoGLpUD26ZHq951UtTOMz7G+yJGa08RSunScis= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A6711601E6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=collinsd@codeaurora.org Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings To: Doug Anderson Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd , Matthias Kaehlcke References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org> From: David Collins Message-ID: <0a52dfe6-d1e1-9171-aa20-8e55e47919f4@codeaurora.org> Date: Wed, 18 Apr 2018 14:44:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/17/2018 01:06 PM, Doug Anderson wrote: > [...] >> +- qcom,regulator-initial-voltage > > nit: regulator framework tends to include "microvolt" in the name to > make it really obvious in the device tree what the units are. Can you > do that too? Sure, I'll change the name to be: qcom,regulator-initial-microvolt. >> +- qcom,drms-mode-threshold-currents > > Could use microamp in the name of the property too... Ok, I'll change the name to be: qcom,drms-mode-max-microamps. >> + qcom,allowed-drms-modes = >> + > + RPMH_REGULATOR_MODE_HPM>; >> + qcom,drms-mode-threshold-currents = <10000 1000000>; > > optional nit: to make it match downstream drivers, does it make sense > to change this to: > > <9999 999999> > > ...so if a driver used to request exactly 10000 mA that it will end up > with the same mode (no idea if drivers actually do that). I'd prefer to leave the example with <10000 1000000> as it looks cleaner to me and the example numbers are arbitrary. It would also be good to use <10000 1000000> in actual board DT files. We can address consumers expecting legacy behavior for 10000 uA requests as needed. Take care, David -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project