Received: by 10.192.165.156 with SMTP id m28csp233714imm; Wed, 18 Apr 2018 21:07:37 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/cpnvc9nJv17EYr5vFshiGKDuvD/B+HtkIdcFpn3Hv8z8dHRd+hvP/t+vOucNz4C7lulGE X-Received: by 10.98.247.17 with SMTP id h17mr4245383pfi.165.1524110857207; Wed, 18 Apr 2018 21:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524110857; cv=none; d=google.com; s=arc-20160816; b=LGz/2nFnOOX5tFrLHVPCM846PPcO7+3owlteCnrbCT3tYTAzoTb1p7GTO/LO/I+GqU vB+igwALe97qiVxKJykmEuDZ4Hgxnz04a8MEB8ZDBFRle2lO6HaJEVsVmGEael/60nak C7V794LzMOLDj4qv0dk+ZISYeLBbg4+VjVBFHQ8Jl9Na5A4dC141bYR46vk84yXrsOLF e1LHPvVEVP/yIojfFeWTFSTwXsLTbhjLYpJFOaSUPuuP32Fq/v0X76+en+LSYXyKrvOR N7FhsWlyNOOPXCt2B+AvaJoPXoozkMKlwp5NlcwlEwGUbYgEqBV46oHk6EUYLukJLgAp I9yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=EcWITg8tnyBKc13ukCE89LVDr8iDtip6p1FK7zR+YCM=; b=SCoT8h3NLK2LugixEJ3p4d5u1dxVuiV/mcuFkLdh8wJ8rIZpt8woI4kPtGxFqzet9A t0++JWzuPDupHCYuTMcZ6yenyJWYkD/pLPFxWXbl5YdVB1APloeA+rXatnTDmgyY0ef9 bd1kTyvlY5/zXrescH5dHhA1vBBoT8ODwuUU7egMjl2E6yZJRBLfGtMl3q4kwl7OU5zj WJhXjPxqLUSBwn+X2rxmNFyVgyB8Xko7Vh7FuIeS0eVg9PaHmEhgP14kn/70EDNuiPAk aIvkyn87ZHZg/HyNYhGZfZhPscOJN5110hWZMYB0npRt8sIfJxMMn1OM8otGkYnahKwM gMow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16-v6si2625722plk.79.2018.04.18.21.07.23; Wed, 18 Apr 2018 21:07:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbeDSEGP (ORCPT + 99 others); Thu, 19 Apr 2018 00:06:15 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:12064 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbeDSEGN (ORCPT ); Thu, 19 Apr 2018 00:06:13 -0400 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 909F3A305D8C5D2F3060; Thu, 19 Apr 2018 12:06:11 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id w3J463Zk048390; Thu, 19 Apr 2018 12:06:03 +0800 (GMT-8) (envelope-from jiang.biao2@zte.com.cn) Received: from localhost.localdomain ([10.75.10.200]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018041912061025-6092831 ; Thu, 19 Apr 2018 12:06:10 +0800 From: Jiang Biao To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org, jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn, wen.yang99@zte.com.cn Subject: [PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue Date: Thu, 19 Apr 2018 12:04:26 +0800 Message-Id: <1524110666-106945-1-git-send-email-jiang.biao2@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-04-19 12:06:10, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-04-19 12:05:51, Serialize complete at 2018-04-19 12:05:51 X-MAIL: mse01.zte.com.cn w3J463Zk048390 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comment before blkg_create() in blkcg_init_queue() was moved from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but it does not suit for the new context. Signed-off-by: Jiang Biao Signed-off-by: Wen Yang CC: Tejun Heo CC: Jens Axboe --- block/blk-cgroup.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 2b7f8d0..07e3359 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1134,11 +1134,7 @@ int blkcg_init_queue(struct request_queue *q) preloaded = !radix_tree_preload(GFP_KERNEL); - /* - * Make sure the root blkg exists and count the existing blkgs. As - * @q is bypassing at this point, blkg_lookup_create() can't be - * used. Open code insertion. - */ + /* Make sure the root blkg exists. */ rcu_read_lock(); spin_lock_irq(q->queue_lock); blkg = blkg_create(&blkcg_root, q, new_blkg); -- 2.7.4