Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] prctl: fix compat handling for prctl
To:     Andy Lutomirski <luto@kernel.org>
CC:     Al Viro <viro@zeniv.linux.org.uk>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Hanjun Guo <guohanjun@huawei.com>
References: <1524099966-43544-1-git-send-email-huawei.libin@huawei.com>
 <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>
From:   "Libin (Huawei)" <huawei.libin@huawei.com>
Message-ID: <130bb5d0-e6a8-932b-3f56-ef021f10a8ba@huawei.com>
Date:   Thu, 19 Apr 2018 14:03:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CALCETrUmFfoWE55Nrkiq5cuvPw5oPFJKOg04ky-dJsDVsdSmbg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


在 2018/4/19 10:25, Andy Lutomirski 写道:
>> On Apr 18, 2018, at 9:06 PM, Li Bin <huawei.libin@huawei.com> wrote:
>>
>> The member auxv in prctl_mm_map structure which be shared with
>> userspace is pointer type, but the kernel supporting COMPAT didn't
>> handle it. This patch fix the compat handling for prctl syscall.
> 
> I would propose an alternative fix: change the type to u64. As far as

But we also need to modify the sys/prctl.h in Glibc, right?

> I know, this thing is only used by CRIU, and CRIU doesn’t work (AFAIK)
> on native 32-bit anyway.   Do you know of some reason that this
> wouldn't work?
> 
> .
>