Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAMty3ZAfBZSc9f5mRxSaYzW6W1JkVkJ7+swMAm3Gg_EFWUkULw@mail.gmail.com>
References: <20180316175354.21437-1-icenowy@aosc.io> <20180316175354.21437-4-icenowy@aosc.io>
 <CAMty3ZBOSXu=+jQpsdnykioDGsp=VphSnzQdDDs_hh3Y1FPKyg@mail.gmail.com>
 <CAGb2v64-sWsFfHThVrcE5ivrf6kZSZa_tkB_GtC=Z+1TLpWV_Q@mail.gmail.com> <CAMty3ZAfBZSc9f5mRxSaYzW6W1JkVkJ7+swMAm3Gg_EFWUkULw@mail.gmail.com>
From:   Jagan Teki <jagan@amarulasolutions.com>
Date:   Thu, 19 Apr 2018 12:05:36 +0530
Message-ID: <CAMty3ZBAbMzRaSwWat+irbxALcOCuEHzsL6yOQJ4AkC9N8Ugxg@mail.gmail.com>
Subject: Re: [PATCH 3/7] bus: add bus driver for accessing Allwinner A64 DE2
To:     Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 14, 2018 at 4:16 PM, Jagan Teki <jagan@amarulasolutions.com> wrote:
> On Sat, Apr 14, 2018 at 4:00 PM, Chen-Yu Tsai <wens@csie.org> wrote:
>> On Sat, Apr 14, 2018 at 6:25 PM, Jagan Teki <jagan@amarulasolutions.com> wrote:
>>> On Fri, Mar 16, 2018 at 11:23 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>>>> The "Display Engine 2.0" (usually called DE2) on the Allwinner A64 SoC
>>>> is different from the ones on other Allwinner SoCs. It requires a SRAM
>>>> region to be claimed, otherwise all DE2 subblocks won't be accessible.
>>>>
>>>> Add a bus driver for the Allwinner A64 DE2 part which claims the SRAM
>>>> region when probing.
>>>
>>> Along with this bus driver, we also need
>>> drivers/gpu/drm/sun4i/sun4i_drv.c which can usually drive the
>>> pipelines like mixer0 and 1 are the cases for A64?
>>
>> I imagine that's the next part to be sent out, after the hardware
>> representation in the device tree has been decided on.
>
> Yeah, this hardware representation along with separate bus driver
> going like in another direction especially if we add pipelines support
> to it, may be we can add sram stuff to platdata of existinf
> sun4i_drv.c

Look like SRAM init during sun4i_drv is unable to claim or map the
memory? do we have any suggestion on adding 'allwinner,pipelines' ? is
it ok to add one more de which is compatible with sun4i_drv.c like
this.

de: display-engine {
                compatible = "allwinner,sun8i-a64-display-engine",
"allwinner,sun8i-h3-display-engine";
                allwinner,pipelines = <&mixer0>;
};

Jagan.

-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.