Received: by 10.192.165.156 with SMTP id m28csp383196imm; Thu, 19 Apr 2018 00:18:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx48fGmg7Km7k9MdW3SOHdhl80yNLzKW+P76SpgFZzueYmT/g6izF66wx8b2t8lwDxwLP4vZ1 X-Received: by 10.167.133.66 with SMTP id y2mr4845057pfn.210.1524122324317; Thu, 19 Apr 2018 00:18:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524122324; cv=none; d=google.com; s=arc-20160816; b=ruxbWriYZaKdqeHqnyijzkt35yhVVlkAbQtEITK91aiwVHDG3t7w2RD/V1QjrOXw8w oQZgYNO+9ygSg7bph21xRg3DEYPVhLGaWcPj/3zAqgLNrcanbs0K6kPoATjborIY5QF9 rdI8a0Z7Rk6XcgPDoHGBlCOiZ1Rq55LZIvQ9+6XvfHBArvALhfilYguavpRsYzHlSEKH T0WWiew6YGTdgkqjWsM7UaK2ga+PTRA++weewr2hXvsMrn/q8J6VVev3pcGUClHFCeOX O4a5WRIqVrIT87DZwMxp/HJDKTpuVNkVZ9YdEf9/+727e09XrQ0OA9fgKCuiBd/UDWL6 cvfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=gC5HfWu9MN4rgGEJvSrBc0tHAVh75vqqzP9R2ktQxOU=; b=BXI5EnsMSr/WeATF0WR7ba0C/I2pNNsjXf2o8KqgPIwfsot5/pGIkmg/ioUlr8kFqE tDP2p6DrdTmiH1PLAcMP8JX7ZlZ5oauaMcEcQbiadTRw6hC/9drGNsLtxGIaVdMgRCic Sg2hkJ+wFWpmpNuB+OmLi2VDyXeOaNzU6ijLJ22yEUvaGvBc9uiWe5kisuMffzjJ8Y+Z 17uuUlOMng4Du1XwsJfdmAINvMZiUxDiSGCEncemi8eDR9txJ26p6AdDcJWyMwvkxrB1 Gt6RM7hD8adXVNtVX5spDsIVMLYqNruJDoMcPLS9vIvIZjV2yeB3EiCbMGRB2CZvBeTO h0vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jlZoW3Jr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11si2504996pgz.412.2018.04.19.00.18.30; Thu, 19 Apr 2018 00:18:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jlZoW3Jr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751386AbeDSHRY (ORCPT + 99 others); Thu, 19 Apr 2018 03:17:24 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:34714 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeDSHRX (ORCPT ); Thu, 19 Apr 2018 03:17:23 -0400 Received: by mail-pl0-f66.google.com with SMTP id z12-v6so2698276plo.1; Thu, 19 Apr 2018 00:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gC5HfWu9MN4rgGEJvSrBc0tHAVh75vqqzP9R2ktQxOU=; b=jlZoW3JreFMlYIdNYeRFJ+CFj79iuit5JUhtYKna1DQSA6xzG/a/oifiOzZsvd0wSD Edx4mJtY7Kd34GABA0zLnx6yKDf7X+/xOlRi819Mmgh3/w/y0+S6+E0wPABxym04ZB6K rdnIRbwRJ/KjfXabCTpj7CZKjK/DSlmZyOExKj7BlM89PKLfCQul7ssKMQYSBCLcQNXD 0GieE8tPSlqcpDIQ2oBV75rUYQXC5cVHiPnecS4oSEWsPPG3eQ0I5VYpmNQGCcdPOTDj n4nu+JlL/2GXVAJg1iCbKriMinVwaL6KcAh30y/lM2ObZvdj/V0N/4PtFZ30Zyl4ybFk 3NzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gC5HfWu9MN4rgGEJvSrBc0tHAVh75vqqzP9R2ktQxOU=; b=WrdDXXEGJKoZAAfouLMgfKCtfTXBGVKQbRrVwM2OiLOaCf5HN3P78tSIgvUR3YjYlm TJFnConhY5642Iez3BCLKGt2/TYNAp3FtJpqpHUUC1/G63Tvt2OB0iA0ppfyWepHyIwS dbwWIs1UtTTHG/1MF3abskwsvBXCW8XcanpbKaEL2UM+uukPaZSCHQJdl+sb19FWTgTo tN3T2a3ObNsmvaKpIbjYSDTV+Uo85SAOOZbMAWGJMV6LjrqWqEzGy+nJ/VXUo0LyY1oe DifhsmNKdWuMgpIIz2ym/4mNb/Tg5m7W1qiIOll0u3+dP9D1OuU2Z2uG1dZqXcgQBptK 8ewA== X-Gm-Message-State: ALQs6tB6B2r3xzqjyt5tegnYavgW7aED4va9J4T55gMimJg+77HpvJw0 DSvZlM+DsGnL9ODh/9/szVY= X-Received: by 2002:a17:902:529:: with SMTP id 38-v6mr5105205plf.64.1524122242460; Thu, 19 Apr 2018 00:17:22 -0700 (PDT) Received: from node5.localdomain ([52.229.160.192]) by smtp.gmail.com with ESMTPSA id p8sm4870124pgf.75.2018.04.19.00.17.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 00:17:21 -0700 (PDT) From: ufo19890607 To: guro@fb.com, mhocko@suse.com, vdavydov.dev@gmail.com, penguin-kernel@i-love.sakura.ne.jp, rientjes@google.com, akpm@linux-foundation.org, tj@kernel.org Cc: kernel-team@fb.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhoujian Subject: Some questions about cgroup aware OOM killer. Date: Thu, 19 Apr 2018 08:17:04 +0100 Message-Id: <1524122224-26670-1-git-send-email-ufo19890607@gmail.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: yuzhoujian Hi Roman I've read your patchset about cgroup aware OOM killer, and try to merge your patchset to the upstream kernel(v4.17-rc1). But I found some functions which in your patch([PATCH v13 3/7] mm, oom: cgroup-aware OOM killer) does not exist in the upstream kernel. Which version of the kernel do you patch on? And, do you have the latest patchset? The faults in PATCH v13 3/7: 1. mm/oom_kill.o: In function `out_of_memory': /linux/mm/oom_kill.c:1125: undefined reference to `alloc_pages_before_oomkill' 2. mm/oom_kill.c: In function ‘out_of_memory’: mm/oom_kill.c:1125:5: error: ‘struct oom_control’ has no member named ‘page’ oc->page = alloc_pages_before_oomkill(oc); ^ Best wishes