Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Apr 2018 11:55:37 +0200
Message-ID: <s5hbmefzfja.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc:     Jorge <jorge.sanjuan@codethink.co.uk>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing
In-Reply-To: <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com>
References: <1523658266-2259-1-git-send-email-ruslan.bilovol@gmail.com>
        <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 14 Apr 2018 00:24:23 +0200,
Ruslan Bilovol wrote:
> 
> Offload snd_usb_parse_audio_interface() function which
> became quite long after adding UAC3 spec support.
> 
> Move class-specific parts to separate functions
> which now produce audioformat structure that is
> ready to be fed to snd_usb_add_audio_stream().
> 
> This also broke Blue Microphones workaround (which
> relies on audioformat decoded from previous altsetting)
> into two parts: prepare quirk flag analyzing previous
> altsetting then use it with current altsetting.
> 
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>

Could you try to split this patch to two parts: one is a simple
refactoring to move the code to snd_usb_get_audioformat_uac12(), and
another to add snd_usb_get_audioformat_uac3().

In this way, we can see a problem more clearly if it's in the
refactoring part.


thanks,

Takashi