Received: by 10.192.165.156 with SMTP id m28csp628693imm; Thu, 19 Apr 2018 05:04:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx48SKXg3MYdjD21toptyzFubx09cVvlPliWAPfGyU9/iLwjb9bme6uKl/BMhWdZvitmi878m X-Received: by 2002:a17:902:8:: with SMTP id 8-v6mr5815598pla.287.1524139492190; Thu, 19 Apr 2018 05:04:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524139492; cv=none; d=google.com; s=arc-20160816; b=vxjrC0KJkYKlFd2LfIWfPT9uMgx9IbtjYpidQtk2U6uZ+nrHGMeaURgQ629/AjF0mL FDp3arMZjRHe1E3Vy3lsC3SKl3J7u0SbpLdNP90fIkJXEa1FqrteGakxy+OW2i87nEfI 23b6DrPS8w+PpCE8sco0lateRou2EYJ2+HUX0x1PW+tTQ6j+Zn5ckLac/QUT2nnNF5H4 1AvyyMkUBdsmeEln2AidkA5yRnQ1bYfwiWDXZoiKyt7aDzqTgroc4O22rP9xv3H9RGvl zX/D54vbWcx5ClPual4DZY0SutVhCSgaM+bYkgl2Iq3rj7OwsLH8NbVFmXg+itXt6C5s /XDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=c3X6EZteQQqdGYg0G/Ti6ut+o1p50t0C1baBgsKgGnk=; b=QCryOYvdVmMCv7M96IzBbTWmT9CAcwhoDPrK5RI9f2J7HApM2TEbbb++K9gyAD8uKf IHLELznCWKlv/JYsorFgaZ4z7pD6bxAIN59ukQoVapjwk49zwJHYb9cZj2IBq6as+hDt fWW1MNFMNvJ+QKc16PcKwK0xY8lH371fsD442D50HHF76rV3HEtnU9AH7Bx3SgD6isLB T8UMKbguhOCVd4CKkIWuEWOBMvizqSQpuBh9AbWAujDu6CxL4F8M7OyZniM3HHzhaOgS NdI6sr3k4nuOBky4KzmoGR4BwVXl9IfUPZCm8xQ8tzB+poVo/+XrAm1T08eM6sb6FcM+ mvnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si1191772pfb.327.2018.04.19.05.04.38; Thu, 19 Apr 2018 05:04:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbeDSMC7 (ORCPT + 99 others); Thu, 19 Apr 2018 08:02:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38252 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752322AbeDSMC6 (ORCPT ); Thu, 19 Apr 2018 08:02:58 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3JC2OiE122890 for ; Thu, 19 Apr 2018 08:02:57 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hes6pcnqt-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Thu, 19 Apr 2018 08:02:48 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Apr 2018 13:01:14 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 19 Apr 2018 13:01:10 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3JC19lb14287176; Thu, 19 Apr 2018 12:01:09 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43FA011C069; Thu, 19 Apr 2018 12:53:03 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08E2D11C04A; Thu, 19 Apr 2018 12:53:03 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.152.224.140]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 19 Apr 2018 12:53:02 +0100 (BST) Subject: Re: [PATCH] vfio-ccw: process ssch with interrupts disabled To: Cornelia Huck , Dong Jia Shi , Halil Pasic Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180413140509.9042-1-cohuck@redhat.com> From: Halil Pasic Date: Thu, 19 Apr 2018 14:01:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180413140509.9042-1-cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18041912-0040-0000-0000-0000044F4C52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041912-0041-0000-0000-000020F3A158 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-19_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804190108 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2018 04:05 PM, Cornelia Huck wrote: > When we call ssch, an interrupt might already be pending once we > return from the START SUBCHANNEL instruction. Therefore we need to > make sure interrupts are disabled until after we're done with our > processing. > > Note that the subchannel lock is the same as the ccwdevice lock that > is mentioned in the documentation for ccw_device_start() and friends. > > Signed-off-by: Cornelia Huck Acked-by: Halil Pasic