Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <347705ade75b5901537034561fd67311b1260358.1524143428.git.greentime@andestech.com>
References: <347705ade75b5901537034561fd67311b1260358.1524143428.git.greentime@andestech.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 19 Apr 2018 15:36:36 +0200
Message-ID: <CAK8P3a0xoOd=WRaaL6EurpD3y78XqAJyJryWwfenrze+7O5L1w@mail.gmail.com>
Subject: Re: [PATCH 1/9] nds32: lib: To use generic lib instead of libgcc to
 prevent the symbol undefined issue.
To:     Greentime Hu <green.hu@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greentime <greentime@andestech.com>,
        Guenter Roeck <private@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 19, 2018 at 3:18 PM, Greentime Hu <green.hu@gmail.com> wrote:
> We can use the generic lib to fix these error because the symbol of
> libgcc in toolchain is not exported.
>
> ERROR: "__ucmpdi2" [fs/xfs/xfs.ko] undefined!
> ERROR: "__ashrdi3" [fs/xfs/xfs.ko] undefined!
> ERROR: "__lshrdi3" [fs/xfs/xfs.ko] undefined!
> ERROR: "__ashldi3" [fs/ntfs/ntfs.ko] undefined!
> ...
>
> Signed-off-by: Greentime Hu <greentime@andestech.com>

I looked at all nine patches, they all seem like useful fixes:

Acked-by: Arnd Bergmann <arnd@arndb.de>

For the last patch, I commented separately, we might need an additional
patch on top to make it more robust.

        Arnd