Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Apr 2018 15:05:34 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Charles Keepax <ckeepax@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        patches@opensource.cirrus.com, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 16/21] regulator: wm8994: Pass descriptor instead of GPIO
 number
Message-ID: <20180419140534.GE27188@sirena.org.uk>
References: <20180212131717.27193-1-linus.walleij@linaro.org>
 <20180212131717.27193-17-linus.walleij@linaro.org>
 <20180213111147.kr4kecqbhmcoq6w2@localhost.localdomain>
 <CACRpkdZVoYsdWy6GwnnSfaSc2_wycEse3JswqufqDoz=GFb5FQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pY3vCvL1qV+PayAL"
Content-Disposition: inline
In-Reply-To: <CACRpkdZVoYsdWy6GwnnSfaSc2_wycEse3JswqufqDoz=GFb5FQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--pY3vCvL1qV+PayAL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 19, 2018 at 03:55:35PM +0200, Linus Walleij wrote:

> drivers pass an enable GPIO to the regulator core. The wm2200
> for example is just managing the LDO without the use of the
> regulator framework (I guess this is technically incorrect).

It's fine if it's internal to the chip and there's no realistic
mechanism to replace the regulator with an off-chip one.  The reason
the other two CODECs have explicit regulator drivers is that they're
designed to support using an off-chip regulator instead so they need to
look like external regulators do.

--pY3vCvL1qV+PayAL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrYoi0ACgkQJNaLcl1U
h9AKUAf/UeeGkHpltDIu0mgdXSmkD4XnUmXd50ir2OkW+LyfHCtpdx8OSg6ypSBR
b1YQ4VsJ9W2Rh9MgqW+uo16bx18+BZ7zSI5Q+h+hzm67tdiO69+nABwf2DOJDVMC
T5iQdda1izoT5BX08DI/UhsIenio3TLyshcnZ74bi/KMqLzYd5K2gcttjTd5bWwL
YDzAgYmb1kduryrABK54FPPLvTmnT5Zu03AKQdrLQf2bpk1Y84ViWb7vJU9YSSiU
bcDiB/PrNVLD6gG8UJeuPmulvHHMubbqOMtrxSwSyUgNFVtvdX+VGpLcLVhLiaFg
ooHvLthBRq1n01Zu6DMe+35Fptf0rA==
=UYSt
-----END PGP SIGNATURE-----

--pY3vCvL1qV+PayAL--