Received: by 10.192.165.156 with SMTP id m28csp796274imm; Thu, 19 Apr 2018 07:43:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx494ndK7wHdwtFzjqxhgXlLRqsmEsNI65H0068+eTJuB60gix9XH9c72eZZT6UCQEMHKdSGD X-Received: by 10.99.160.25 with SMTP id r25mr5231470pge.95.1524148987424; Thu, 19 Apr 2018 07:43:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524148987; cv=none; d=google.com; s=arc-20160816; b=CIeg+u9SSYMGIu8vNH09pa5AejHFFZ+L53eIizh3fpahYcp7g36jlTXskY3MMB3R8M 0uE0wflWjK4rHp6a1WJvvOvqJQ7CmPUtRvUFsIKwWw/L4IpPFivf45f8YLWypBGIjA10 fc3JK10mHEAFporeOancI+ZyaMhAip/Cc03rwXoWzvV+dhWgrl2PWeT0SoHgoh/D+BVy FXAg3MKBeo9bmWHmZFpad1vLFABeb1UFAO8t2tGFPnF0nvYmMTuNz1jxWPEJb2LQF2iV wHBzlh+LCQBJllVhmnaAP8usoU4+qV2mGYnenWghLB5kBpvjqbNydvUoSOoXHCfisyGL Loog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=IJod7HHs31ce9AMSnL7XbO4vP5zDrO6wdnjXToA/Qnw=; b=pHu3lRMhPBM4YK3N8mx4sM95r/ioJEkj0LGEwqq7Bd/5qQ0an5zfExOtL4MQetcc8S jABXQ+4CL686j000z/LZVrU7XCPFFzMcXQWXbampDJ9CWMCRuBqV5ekGvzSY24a+ZSDZ yikAXKZeBR17y9sLsFhqNYSa8oh2AD9Yzs9kwvpmHRsD1cJXxOJWV676/hYvHJxZ6G9i QJGUioJAwjSsDqoWtQzQ4fimcemdWI9IgZXVrCqkiPxc9jXqiKBeWdy5H/a4/a6ScOyH pyVdNiOvjkV06S2XvOyDTNK7yHXX2rxC2VKFgyRkLXv3tCzKqIkebNiUbP9f5VzFYKzF q0mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2-v6si3491967plk.94.2018.04.19.07.42.53; Thu, 19 Apr 2018 07:43:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753769AbeDSOla (ORCPT + 99 others); Thu, 19 Apr 2018 10:41:30 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46522 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753041AbeDSOi4 (ORCPT ); Thu, 19 Apr 2018 10:38:56 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B5604074450; Thu, 19 Apr 2018 14:38:55 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-60.rdu2.redhat.com [10.10.121.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2594E10F1BFA; Thu, 19 Apr 2018 14:38:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180413202234.GA4484@amd> References: <20180413202234.GA4484@amd> <152346387861.4030.4408662483445703127.stgit@warthog.procyon.org.uk> <152346392521.4030.5108539377959227838.stgit@warthog.procyon.org.uk> To: Pavel Machek Cc: dhowells@redhat.com, torvalds@linux-foundation.org, linux-man@vger.kernel.org, linux-api@vger.kernel.org, jmorris@namei.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 07/24] hibernate: Disable when the kernel is locked down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27925.1524148733.1@warthog.procyon.org.uk> Date: Thu, 19 Apr 2018 15:38:53 +0100 Message-ID: <27926.1524148733@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 19 Apr 2018 14:38:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 19 Apr 2018 14:38:55 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek wrote: > > There is currently no way to verify the resume image when returning > > from hibernate. This might compromise the signed modules trust model, > > so until we can work with signed hibernate images we disable it when the > > kernel is locked down. > > I'd rather see hibernation fixed than disabled like this. The problem is that you have to store the hibernated kernel image encrypted, but you can't store the decryption key on disk unencrypted or you've just wasted the effort. So the firmware has to unlock the image, asking the user for a password to unlock the key. David