Received: by 10.192.165.156 with SMTP id m28csp904206imm; Thu, 19 Apr 2018 09:24:27 -0700 (PDT) X-Google-Smtp-Source: AIpwx48/tAOJld64cqgqSvlxZXnOE3Kk9dLHkb47ddrtCbVkhh2q0JJs7U9/e/oY3NvaC/yhKi8k X-Received: by 2002:a17:902:e8:: with SMTP id a95-v6mr6723019pla.274.1524155067290; Thu, 19 Apr 2018 09:24:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524155067; cv=none; d=google.com; s=arc-20160816; b=WKJnikCQGb+spdZxVMmhgpZtAVl409HBoo/dQL0stMkansWHb1Xcxfa17vmPirNR8D ztNlBsjVTz2baam37e/II+eIHZR8SxgP8cMHYUn2OYmrc2t/c0ak6iBSM2z7UrnLAs3+ JFXYv6F/UOSULcRT8BdkjFPw7U7uixIfg4MhzzIJS97V+/nuXZJolwZUXVOy5p1YVjgo affZwIS6CSMMcej/yRm6wty1N+8lg6lYp3SDrpLUXhNjmH7Tf7KQHjWhUxKcGda1n+U1 VTRb2VNWbPDujxNwPrQxgeDlLY2BIs4XX20nV5RHz/gvaXYEUwuwFEY30MH1JDe1pxqz JZfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=e5vEzVv+De0XuDBQSmtqxEFqu89D69Q2dnbhATa6D7c=; b=sRpVzGMehpl91mAwWn+ceTi8nRzuvvRPkF+lvSpjPVFR5aL+YCuvxbxFUah9ZJHFC2 7SOrEBh9jsfoClw+OF4ENaSoQ2JP/uX8/UPxw1RBd5dHxYK5qe9Xvz+Oakscs38sCpcM +yC8zbekasDweXB3oRfvSuORZ0HIG833gX/oumth89VYLClJakX+VWzYsuyOE4eyoRmV UxgVJw3p8kD33Y9FaepgLqvCxfYmAs1oDih4OadjKrr2qot0BSt6ShsZ8b593i2pODiM u4KMl++Kww9/YgJlsaCdH+NEDNwX/3vK/67+gQKThNmvhaJgWC3UEK6dFqsHzoYHlJI7 OSsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=TUdXNumh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9si3179550pge.641.2018.04.19.09.24.11; Thu, 19 Apr 2018 09:24:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=TUdXNumh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753914AbeDSQWk (ORCPT + 99 others); Thu, 19 Apr 2018 12:22:40 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33023 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbeDSQWh (ORCPT ); Thu, 19 Apr 2018 12:22:37 -0400 Received: by mail-lf0-f65.google.com with SMTP id d79-v6so1046254lfd.0 for ; Thu, 19 Apr 2018 09:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e5vEzVv+De0XuDBQSmtqxEFqu89D69Q2dnbhATa6D7c=; b=TUdXNumhCm/7QbeES/0bkHIPXaenkbBNFpcmENOiTC5AKxbzH3B/PuWo3TmmWRNQch L9LKQ41ICBYvnoFxfAeusf4LNfUmQWXdx0MONl6/W1lRRBWc+LPJoL6EQFaKa/6yhJvu unbQjmNu3nJNL/OJfUcaMwZcE6lJyj/lB9IxPZqR0o2Gqj2xaR8/gulxU7C8e8vfFh4J PjAsnzyJHKi9S4GcsiSsGe9dtVNudchcjGjvcwfXSG7wzHSqpMZ9Yx3OzajiBfS9QaKh kSlASwnXnjbjqPCgyhK8V1u9a0106yuGY7rs5SPdI/RXenqSebhWrxdnQuTGYyd4PlaF SYGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=e5vEzVv+De0XuDBQSmtqxEFqu89D69Q2dnbhATa6D7c=; b=kgGqRvrYPZFzleo1k4Adz/IXC/pP30ocrrcIdvt1hUeb2vBM7PANaNB2urcuMfz0Nc NN0UwuAIBfh2Ir97yeVqaNt7YWVuZTWEbaUFu2qKBdMljBbYj4sFCnZcJ4cT463+RHo4 4q6poToyOB8rtRojnq6SiwsN9Lh6Zfg9KcPMZ18auG99mr/6Vmvexvc2+tfOm4pQXaXf VuUiQCOluNorsx5GaNO+GIth07Y81IwB/Aiupvxg9GyrzL7ajGyBFHprF+mti+iZDJuM 14AUdcrkk8ZcS1lP3ZjG9Lv8PXqGagh6wY/SM7YSXX3PCv/6ldKkO+x1BqU17YU2Q186 wzEQ== X-Gm-Message-State: ALQs6tAkwSCJogDxTGF4zQpvQK5jP9SGUGmAgv5itQbJb3gG1tEFgMn+ jrTJdKqj4Jah+eYxd6k5Vai/xA== X-Received: by 2002:a19:9f10:: with SMTP id i16-v6mr438801lfe.29.1524154955788; Thu, 19 Apr 2018 09:22:35 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.81.209]) by smtp.gmail.com with ESMTPSA id s89-v6sm829225lfg.19.2018.04.19.09.22.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 09:22:34 -0700 (PDT) Subject: Re: [PATCH 02/61] ata: simplify getting .drvdata To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Tejun Heo , linux-ide@vger.kernel.org References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-3-wsa+renesas@sang-engineering.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Thu, 19 Apr 2018 19:22:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180419140641.27926-3-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 04/19/2018 05:05 PM, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via Note that the name of the field in the 'struct device' is driver_data, not drvdata. Otherwise the patch looks good. > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang [...] MBR, Sergei