Received: by 10.192.165.148 with SMTP id m20csp141239imm; Thu, 19 Apr 2018 18:04:24 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+UQfbJkg+6O5KDTrZTADYDlt7jIoButscywNOshblL3bb5rfQpHjBvnDYYdBaVZvYKBBY6 X-Received: by 10.101.78.134 with SMTP id b6mr6615280pgs.392.1524186264902; Thu, 19 Apr 2018 18:04:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524186264; cv=none; d=google.com; s=arc-20160816; b=kMC9jyxD7yd2uDw0BACfxuPLXbqgCBMFnAFAULwwZ4E4R80FyhNM3X/pyc2CG7mQg4 gwbRn+SUyDls6GqeRoP4XwDmONyWc6kyu+9TAfMcI2DVJPoV1OJfZsNm3o1pNy9sEO5I kKFa3Nr6hs+pe6ArL9v2c/iXV1dSxlMdeHrYGkidfWooQbIYfTFT16kLGHR6BMzh4wI8 tnoStsWPWUSWTWTAXEW+7Womlf1LlTUT6Z+om61mHFuQNBvPeUEppiHwH4KGlkbpWzC3 O6p2qKbCVqgWQs71U1ZuPcn7y8Ua+zPurdbFYbpv+JNJatk2+DDrGM1ta6S3C9OdmIoZ JEww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:date:cc:to:from:arc-authentication-results; bh=ot2D2Xg/ARcCEUy9ZNVQYsWIacfudFRCQDx5Kc0Nyk8=; b=WwYYVHWy4goCmEptl8iTVCK2qCpSUFdImEY78D3ci1MOejW6QYvT8/lv+kuuS/ouGZ I9KBhak/dqRiU4L3f50fLobQF8PFr3gg7w2EqqVyrv3yY48e+D6G5yQysZKxlC0Zyj+u nm+xa2Nc9u8gVHaw2xRawZYx7wSCnJo6oWHDCroBsKzdwEW8379wx5/E9xRf/T0fddqr 6F7MMO4wIaC2gmcoqGGmI/BQhYJEhyYSJ5T2MGm9ymZAdR7c7y6qiKOfCiMbvbUFeIDm l1wOEfZwGZqR9tqm1x17ONWp5YaXSn9ItiWIMoTCCdMNAC9gEZP34tPlQ5/ZJalhlf/C /OqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si4033334pgu.663.2018.04.19.18.04.08; Thu, 19 Apr 2018 18:04:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbeDTBC4 (ORCPT + 99 others); Thu, 19 Apr 2018 21:02:56 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:44297 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753761AbeDTBCx (ORCPT ); Thu, 19 Apr 2018 21:02:53 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9KRn-00066K-1F; Thu, 19 Apr 2018 19:02:43 -0600 Received: from [97.119.174.25] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9KRk-0002fH-Ok; Thu, 19 Apr 2018 19:02:42 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Cc: , , Helge Deller , Richard Henderson , Ivan Kokshaysky , Matt Turner , David Miller , Yoshinori Sato , Rich Felker , Paul Mundt , Vincent Chen , Greentime Hu , Arnd Bergmann , Tony Luck , Fenghua Yu , Paul Mackerras , Kumar Gala , Michael Ellerman , Benjamin Herrenschmidt , Guan Xuetao Date: Thu, 19 Apr 2018 20:01:16 -0500 Message-ID: <878t9ilmhv.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1f9KRk-0002fH-Ok;;;mid=<878t9ilmhv.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.174.25;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19kr8xV2lZ6TeKYZurv3Ni0z0sjREifY8g= X-SA-Exim-Connect-IP: 97.119.174.25 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa06.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,XMNoVowels autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 TR_Symld_Words too many words that have symbols inside * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **; X-Spam-Relay-Country: X-Spam-Timing: total 1391 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.9 (0.2%), b_tie_ro: 1.91 (0.1%), parse: 0.73 (0.1%), extract_message_metadata: 4.3 (0.3%), get_uri_detail_list: 2.7 (0.2%), tests_pri_-1000: 4.5 (0.3%), tests_pri_-950: 1.21 (0.1%), tests_pri_-900: 1.02 (0.1%), tests_pri_-400: 34 (2.5%), check_bayes: 33 (2.4%), b_tokenize: 13 (1.0%), b_tok_get_all: 11 (0.8%), b_comp_prob: 2.5 (0.2%), b_tok_touch_all: 4.2 (0.3%), b_finish: 0.65 (0.0%), tests_pri_0: 1331 (95.7%), check_dkim_signature: 0.51 (0.0%), check_dkim_adsp: 2.4 (0.2%), tests_pri_500: 4.0 (0.3%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 00/17] siginfo bugfixes and cleanups X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mostly this dealing with aliases of SI_USER, that make it impossible for userspace to tell what kind of siginfo it has received. Also in this series is the change to ensure we have siginfo initialized so I can rip out the switch in copy_siginfo_to_user for better performance, and to ensure better backwards compatibility as siginfo as generated in the callers is passed to userspace. There are also fixes for a few other siginfo bugs I have found. There are cleanups of ifdefs on SEGV_BNDERR and BUS_MCERR_AX that are no longer necessary. I plan to merge these bug fixes through my siginfo tree, but if you object to them or would prefer to have them go through your arch tree please let me know. The changes are avaiable as a totality at: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git siginfo-review Dmitry V. Levin (1): sparc: fix compat siginfo ABI regression Eric W. Biederman (16): signal/alpha: Document a conflict with SI_USER for SIGFPE signal/sh: Use force_sig_fault in hw_breakpoint_handler signal/nds32: Use force_sig in unhandled_interruption and unhandled_exceptions signal/nds32: Use force_sig(SIGILL) in do_revisn signal: Ensure every siginfo we send has all bits initialized signal: Reduce copy_siginfo_to_user to just copy_to_user signal: Stop special casing TRAP_FIXME and FPE_FIXME in siginfo_layout signal: Remove SEGV_BNDERR ifdefs signal: Remove ifdefs for BUS_MCEERR_AR and BUS_MCEERR_AO signal/alpha: Replace FPE_FIXME with FPE_FLTUNK signal/ia64: Replace FPE_FIXME with FPE_FLTUNK signal/powerpc: Replace FPE_FIXME with FPE_FLTUNK signal/unicore32: Use FPE_FLTUNK instead of 0 in ucf64_raise_sigfpe signal: Add TRAP_UNK si_code for undiagnosted trap exceptions signal/alpha: Replace TRAP_FIXME with TRAP_UNK signal/powerpc: Replace TRAP_FIXME with TRAP_UNK arch/alpha/include/uapi/asm/siginfo.h | 14 ---- arch/alpha/kernel/osf_sys.c | 3 +- arch/alpha/kernel/signal.c | 2 + arch/alpha/kernel/traps.c | 11 ++- arch/alpha/mm/fault.c | 2 + arch/arc/mm/fault.c | 2 + arch/arm/kernel/ptrace.c | 1 + arch/arm/kernel/swp_emulate.c | 1 + arch/arm/kernel/traps.c | 5 ++ arch/arm/mm/alignment.c | 1 + arch/arm/mm/fault.c | 4 + arch/arm/vfp/vfpmodule.c | 3 +- arch/arm64/kernel/fpsimd.c | 2 +- arch/arm64/kernel/sys_compat.c | 1 + arch/arm64/kernel/traps.c | 1 + arch/arm64/mm/fault.c | 18 +++-- arch/c6x/kernel/traps.c | 1 + arch/hexagon/kernel/traps.c | 1 + arch/hexagon/mm/vm_fault.c | 1 + arch/ia64/include/uapi/asm/siginfo.h | 7 -- arch/ia64/kernel/brl_emu.c | 1 + arch/ia64/kernel/signal.c | 2 + arch/ia64/kernel/traps.c | 31 ++++++-- arch/ia64/kernel/unaligned.c | 1 + arch/ia64/mm/fault.c | 4 +- arch/m68k/kernel/traps.c | 2 + arch/microblaze/kernel/exceptions.c | 1 + arch/microblaze/mm/fault.c | 4 +- arch/mips/mm/fault.c | 1 + arch/nds32/kernel/traps.c | 19 ++--- arch/nds32/mm/fault.c | 1 + arch/nios2/kernel/traps.c | 1 + arch/openrisc/kernel/traps.c | 5 +- arch/openrisc/mm/fault.c | 1 + arch/parisc/kernel/ptrace.c | 1 + arch/parisc/kernel/traps.c | 2 + arch/parisc/kernel/unaligned.c | 1 + arch/parisc/math-emu/driver.c | 1 + arch/parisc/mm/fault.c | 1 + arch/powerpc/include/uapi/asm/siginfo.h | 15 ---- arch/powerpc/kernel/process.c | 1 + arch/powerpc/kernel/traps.c | 13 ++-- arch/powerpc/mm/fault.c | 1 + arch/powerpc/platforms/cell/spufs/fault.c | 2 +- arch/riscv/kernel/traps.c | 1 + arch/s390/kernel/traps.c | 5 +- arch/s390/mm/fault.c | 2 + arch/sh/kernel/hw_breakpoint.c | 9 +-- arch/sh/kernel/traps_32.c | 2 + arch/sh/math-emu/math.c | 1 + arch/sh/mm/fault.c | 1 + arch/sparc/include/uapi/asm/siginfo.h | 7 -- arch/sparc/kernel/process_64.c | 1 + arch/sparc/kernel/sys_sparc_32.c | 1 + arch/sparc/kernel/traps_32.c | 12 ++- arch/sparc/kernel/traps_64.c | 16 +++- arch/sparc/kernel/unaligned_32.c | 1 + arch/sparc/mm/fault_32.c | 1 + arch/sparc/mm/fault_64.c | 1 + arch/um/kernel/trap.c | 2 + arch/unicore32/kernel/fpu-ucf64.c | 8 +- arch/unicore32/mm/fault.c | 3 + arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- arch/x86/kernel/ptrace.c | 2 +- arch/x86/kernel/signal_compat.c | 2 +- arch/x86/kernel/traps.c | 3 + arch/x86/kernel/umip.c | 1 + arch/x86/kvm/mmu.c | 1 + arch/x86/mm/fault.c | 1 + arch/xtensa/kernel/traps.c | 1 + arch/xtensa/mm/fault.c | 1 + fs/signalfd.c | 15 +--- include/linux/ptrace.h | 1 - include/linux/tracehook.h | 1 + include/uapi/asm-generic/siginfo.h | 3 +- kernel/signal.c | 123 +++--------------------------- virt/kvm/arm/mmu.c | 1 + 77 files changed, 194 insertions(+), 231 deletions(-)