Received: by 10.192.165.148 with SMTP id m20csp143719imm; Thu, 19 Apr 2018 18:07:45 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/znOjgYPXYzRX89WlA2GTyWkHc2ZOKKD+KSvP7on8BCqBouDVuPDi1ther7Tt3x7kzUl8m X-Received: by 2002:a17:902:bd4a:: with SMTP id b10-v6mr8186441plx.271.1524186465073; Thu, 19 Apr 2018 18:07:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524186465; cv=none; d=google.com; s=arc-20160816; b=UG8ahf1Ffu5smWPS0lOuCX6wh8nsy57cuT5cS/g/Vbcfw6D0TAjPvsVUN+pI1AThHV CHr5MSwtad2PfLUVfIZip4fb/Baeqk/SOfq5OLJosAZpsmGUPpMTq0XqKivcHhMTAA2V HtSxOQjwnWZvAHhu0ilhZAVFFsyqP4/udLzTEB9MNniumm84tgqgryzPV2HaSwxaIK8u Z9NdKvoCuj+zLLYP9oktjpdR4VSYaO2zmtx5uXz2xqCLp5RoR1v6EDDCLour/E6l+A+J 7J+24C8ructRUngf+7onXXxGKJkmaW0NibcoAiPRP7NaIC/5b+K6VcjG7GOC7gR7CJo4 9u+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=AJXtQOBoo6yDpzbqBrhy9FHX4io9gvkTX7l0sU4n1wI=; b=UHHJw2aH7kQlqZlbAtvUXbxsp9Kz3ZXY/0cXVWtpMQLtozmp4DPHjgkQ0o/aEYMdj1 eYAV3V6u7jAySUIDdckZzeSP7HrjslOR5oiAnGVtTgaPV0lhAw/QqRXJfWgrNQvK0yow e96zBnin2VwtfapdmKL0JPsnDWp/U4MUSw+rvJFw/gbIexkv+2XgloKtQ9hrozAf8g/5 XBgtodzdLOD9poSeqITWbpx9aKKrLXTD3oTHUBfhrfDoQr5txWSJlm9BALxThcmXk43f J2LOmcY/eclv7eQ6nT76zvsKoXqvrHm8dNHfe7v98fkBfYMiV/F+dlIKxUOVgnzu3Vv+ Mtqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si4033334pgu.663.2018.04.19.18.07.30; Thu, 19 Apr 2018 18:07:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbeDTBG2 (ORCPT + 99 others); Thu, 19 Apr 2018 21:06:28 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:50066 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753761AbeDTBGZ (ORCPT ); Thu, 19 Apr 2018 21:06:25 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9KVN-0006il-3G; Thu, 19 Apr 2018 19:06:25 -0600 Received: from [97.119.174.25] (helo=x220.int.ebiederm.org) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9KV7-00014u-MZ; Thu, 19 Apr 2018 19:06:24 -0600 From: "Eric W. Biederman" To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Eric W. Biederman" , Helge Deller , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Date: Thu, 19 Apr 2018 20:03:52 -0500 Message-Id: <20180420010408.24438-1-ebiederm@xmission.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <878t9ilmhv.fsf@xmission.com> References: <878t9ilmhv.fsf@xmission.com> X-XM-SPF: eid=1f9KV7-00014u-MZ;;;mid=<20180420010408.24438-1-ebiederm@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.174.25;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+YEgApePL4+/oeBn5U62uh+ghuglh3t5I= X-SA-Exim-Connect-IP: 97.119.174.25 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa07.xmission.com X-Spam-Level: *** X-Spam-Status: No, score=3.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, XMNoVowels,XMSubLong autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 1.5 TR_Symld_Words too many words that have symbols inside * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ***;linux-arch@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 15029 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 2.9 (0.0%), b_tie_ro: 2.1 (0.0%), parse: 0.69 (0.0%), extract_message_metadata: 18 (0.1%), get_uri_detail_list: 1.57 (0.0%), tests_pri_-1000: 3.0 (0.0%), tests_pri_-950: 1.18 (0.0%), tests_pri_-900: 0.96 (0.0%), tests_pri_-400: 22 (0.1%), check_bayes: 21 (0.1%), b_tokenize: 8 (0.1%), b_tok_get_all: 6 (0.0%), b_comp_prob: 2.1 (0.0%), b_tok_touch_all: 2.9 (0.0%), b_finish: 0.62 (0.0%), tests_pri_0: 138 (0.9%), check_dkim_signature: 0.41 (0.0%), check_dkim_adsp: 8 (0.1%), tests_pri_500: 14841 (98.7%), poll_dns_idle: 14830 (98.7%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 01/17] signal/alpha: Document a conflict with SI_USER for SIGFPE X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Setting si_code to 0 is the same as setting si_code to SI_USER. This is the same si_code as SI_USER. Posix and common sense requires that SI_USER not be a signal specific si_code. As such this use of 0 for the si_code is a pretty horribly broken ABI. Cc: Helge Deller Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: linux-alpha@vger.kernel.org History Tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git Ref: 0a635c7a84cf ("Fill in siginfo_t.") Signed-off-by: "Eric W. Biederman" --- arch/alpha/kernel/osf_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index 89faa6f4de47..2e02aef5a334 100644 --- a/arch/alpha/kernel/osf_sys.c +++ b/arch/alpha/kernel/osf_sys.c @@ -872,7 +872,7 @@ SYSCALL_DEFINE5(osf_setsysinfo, unsigned long, op, void __user *, buffer, fex = (exc >> IEEE_STATUS_TO_EXCSUM_SHIFT) & swcr; if (fex) { siginfo_t info; - int si_code = 0; + int si_code = FPE_FIXME; if (fex & IEEE_TRAP_ENABLE_DNO) si_code = FPE_FLTUND; if (fex & IEEE_TRAP_ENABLE_INE) si_code = FPE_FLTRES; -- 2.14.1