Date: Thu, 21 Aug 2003 01:08:12 +0200
From: Francois Romieu <romieu@fr.zoreil.com>
To: Ronald Bultje <rbultje@ronald.bitfreak.net>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@odsl.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.0-test3 zoran driver update
Message-ID: <20030821010812.A6961@electric-eye.fr.zoreil.com>
References: <1061414594.1320.97.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <1061414594.1320.97.camel@localhost.localdomain>; from rbultje@ronald.bitfreak.net on Wed, Aug 20, 2003 at 11:23:15PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1476
Lines: 42

Ronald Bultje <rbultje@ronald.bitfreak.net> :
[...]

- {adv7170/adv7175/bt819/saa7110/saa7185}_detect_client()
  for each of these functions, two error exit path leak on locally allocated
  variable "channel".

- {adv7170/adv7175/bt819/saa7111/saa7185}_write_block()
  The code duplication could surely be avoided.

- always put a blank line between variables declaration and code pleae

- find_zr36057():
  what about replacing pci_find_device() by the modern pci insertion/removal
  api (which has been standing there for ~3 years)

- pci_enable_device() in find_zr36057() isn't balanced by pci_disable_device()
  in zoran_release()

- +irqreturn_t
  +zoran_irq (int             irq,
[...]
  +                                               for (i = 0; i < 4; i++) {
  +                                                       if (zr->
  +                                                           stat_com[i] &
  +                                                           1)
  +                                                               sv[i] =
  +                                                                   '1';
  +                                               }

  Post-modernism ?


It looks interesting.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/