Received: by 10.192.165.148 with SMTP id m20csp28182imm; Fri, 20 Apr 2018 02:22:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx49Jei54kUno3lEgt57ztMVzFn5ggC7FWimLd1uvMu0L65IAWXOhtkbEoCqeQZHXxBgzMAaN X-Received: by 10.98.67.217 with SMTP id l86mr9066850pfi.40.1524216154982; Fri, 20 Apr 2018 02:22:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524216154; cv=none; d=google.com; s=arc-20160816; b=nshVkshqsXUflm4LPxFB2EmmWEN0yYGIisJEcOxUg47NMZ5tMYKrZYTrZeDJh5u4AZ 2bKM4Vw2jCAl9wFZZbNx41ztX1CbzWiwoSWwOdTaATp+YTpxHyacM6yZE9FWroaaDCrU /k0q1bvpoXJ+V2tFgrM4d792crO6Sz1JPGMdR+pwp5pktc5Y5jsmxQgIrnP25VBGt/zU SEj4NhCTNAGckmHSXRHRRBKUtiBoARO/bvwT2StJTDHRhz+MBjveB9+m9JYsf3RebjQ5 KmWdVk2HNPy3zrAy63PxducYMrpQiezeRdk/M7WYNqzBXQlgdU19Q/gp/u/40bm4qEqB tHQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=9w+c2O588G8YQ8qjkQ6bLw0nnTTyu0POtK8Q0Iq9i2Y=; b=0CaSy5HB+EcXMYis0t03+b1ypObAtCeElVUTX7dtxIIgej2U9g+504zmlo/xyKQCVs ipvS62TBuFf3bH5Sfh9FHaXbcHszFv96PdQzgrZbocz0eJ98aR7rrGEtGyqeKJlnpvfW FY96E054aBtt4Y5AALgST1N+bY5bKxuSdhc/9TNGWYPPF67DmleU0ySjx5WrwGxlQa/r pRlt74E/OL9uWcUlHM8hXvVrXiXFPyRATJUrCzLsK49UsG6/ayenNd7xPlohg9SGK0HU dGjhI5pk/3HbhGWx2bsRQyaXm4oFFkMqNAjIk34SODmOxvOSR9f1GwYwsBMxcKCmFsWX RKVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=btKVzFqs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si5298284plr.225.2018.04.20.02.22.20; Fri, 20 Apr 2018 02:22:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=btKVzFqs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbeDTJVR (ORCPT + 99 others); Fri, 20 Apr 2018 05:21:17 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:41514 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193AbeDTJVP (ORCPT ); Fri, 20 Apr 2018 05:21:15 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3K9Bkgv104596; Fri, 20 Apr 2018 09:21:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=9w+c2O588G8YQ8qjkQ6bLw0nnTTyu0POtK8Q0Iq9i2Y=; b=btKVzFqsH5rl/nyrP8GHgEgvoy/CcSxuonCyqfCIVVkEJGtavqmU1YXqgtIrk6jMXFx0 MocJw/zk659W8ARhdz5I3FLH9wWYEwTvmPcGJ9ZL9/7ymHb+sJUSyhPBYw9IHyULYy2v PKSrMOujR5XeuUafuZtMcpW3jYBDhe9sknDTXFCKQo6mM3ZWOhXUQXiZUsmH7ZIBPdgU 2JBoxNcf5IgACDvyrs3DEVkrLkF51yDOAo5vu24KNkR6V5RpaJpxovcz5bHeR6ozffFk OqtV81sWiZ1OzaVLKkfo6xejPibsG9hLZcA1Mh9Qs44ZewjKOOu2N6/uPMBLBZvUJCwl Jg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2hf7ams527-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Apr 2018 09:21:13 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w3K9LCB7012953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Apr 2018 09:21:12 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3K9LBYY007325; Fri, 20 Apr 2018 09:21:12 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 20 Apr 2018 02:21:11 -0700 Date: Fri, 20 Apr 2018 12:21:05 +0300 From: Dan Carpenter To: Lee Jones , Rhyland Klein Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] mfd: tps65911-comparator: Fix a build error Message-ID: <20180420092105.GA28058@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180420085938.ymf2jc46dswylxh4@mwanda> X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8868 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=904 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804200092 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In 2012, we changed the tps65910 API and fixed most drivers but forgot to update this one. Fixes: 3f7e82759c69 ("mfd: Commonize tps65910 regmap access through header") Signed-off-by: Dan Carpenter diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c index 887409c3938d..90cfdd1f88c6 100644 --- a/drivers/mfd/tps65911-comparator.c +++ b/drivers/mfd/tps65911-comparator.c @@ -74,7 +74,7 @@ static int comp_threshold_set(struct tps65910 *tps65910, int id, int voltage) return -EINVAL; val = index << 1; - ret = tps65910->write(tps65910, tps_comp.reg, 1, &val); + ret = tps65910_reg_write(tps65910, tps_comp.reg, val); return ret; } @@ -82,10 +82,10 @@ static int comp_threshold_set(struct tps65910 *tps65910, int id, int voltage) static int comp_threshold_get(struct tps65910 *tps65910, int id) { struct comparator tps_comp = tps_comparators[id - 1]; + unsigned int val; int ret; - u8 val; - ret = tps65910->read(tps65910, tps_comp.reg, 1, &val); + ret = tps65910_reg_read(tps65910, tps_comp.reg, &val); if (ret < 0) return ret;