Received: by 10.192.165.148 with SMTP id m20csp39244imm; Fri, 20 Apr 2018 02:37:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/6y6OD5JahQHQm0n2QfebSjXDb8EPcdmEX+q55jXMb+mtcSFPMWEXJy+jNhy0B8Qu4OdOS X-Received: by 10.98.1.68 with SMTP id 65mr9131753pfb.64.1524217046059; Fri, 20 Apr 2018 02:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524217046; cv=none; d=google.com; s=arc-20160816; b=lP8E4G8FxWdiGiqBzxESrx3F1LBnogoHGYfAj3X//vBeXf59JAcSJ/qTDyGV2mNLsw aZyzd9LNiZbtjcB15uRSmTe5k57V/fCXZyQmZhidNMrD3maVMRnLo8EpMW4Zzo8MjuiF vMgUlfs2QyUX/rvXfTtcSrL8aWtcJBF7gl6TlkXthgEaYyq/4y8fjmsgXjIDR6UueUHl kpN87AG97PCtlnCWtWu3LYTnchDIy/d0HpmLV/EW10kt7ZRDPqWcR3KSlvU6WhLlP/cA x9KODXmjSnfJYjfeW1zS88WerXdxKRZkzy245xIp2TcEBNhcIOwiOoli9nWInnuTInhU 9qbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=0wmeJSRZp+y3Ms26wucjphUVaR0Xh8btiYnYsU+vzFs=; b=tK3n8rNaRhLlb/uOayL+DtaRV7JKcz258y2GzIKWifxkIPX1cbsLcD/ZWGUEtArtxu 9u5C9uDJUSC0uMy74tmUzjtRZ+mkGDv2NIeg8aBZjwY77v/ZW92C40Q+tHKpRsOyUSEB 37LgPLdH7Ubgomec/Qq7zNoZhVYiCuTQfmtCwN0+yU+l3QY990xqIN6sxy8A458k6HI0 Y/IsTvBhhJFFL41dcT28AjGgFGNuYlYx39PrSvDNw7PBdHhnwhv211KCVB85R+LDTOt4 vbhJdCtYYuu5wWXpK98AkUKHeFTPeIaZPZgSNynLI5r8XdCRP/Utdh8WDvD2ikB6WlUm h0eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=uIKUbYRJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12-v6si2112795plg.463.2018.04.20.02.37.12; Fri, 20 Apr 2018 02:37:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=uIKUbYRJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754408AbeDTJgB (ORCPT + 99 others); Fri, 20 Apr 2018 05:36:01 -0400 Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68]:19822 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754335AbeDTJf5 (ORCPT ); Fri, 20 Apr 2018 05:35:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0wmeJSRZp+y3Ms26wucjphUVaR0Xh8btiYnYsU+vzFs=; b=uIKUbYRJJ1HEY7W3uz7xP8QSfOYANil+QOhc0BdYYZRTHF1sKy+veW2foIO3kRwfYSIIObX7SUBipQO8ovUHnY9zQXR3KnrZsEiL/XnvKfDIZjzGe3XXRma0BxdcT5HkVMj1CvIubjY0+mJ8IfMRX++cEjvMQhnuwQZffJwjoDQ= Received: from VI1PR04MB1455.eurprd04.prod.outlook.com (10.163.166.147) by VI1PR04MB2175.eurprd04.prod.outlook.com (10.166.43.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Fri, 20 Apr 2018 09:35:54 +0000 Received: from VI1PR04MB1455.eurprd04.prod.outlook.com ([fe80::74e9:269d:7a78:8923]) by VI1PR04MB1455.eurprd04.prod.outlook.com ([fe80::74e9:269d:7a78:8923%13]) with mapi id 15.20.0696.013; Fri, 20 Apr 2018 09:35:54 +0000 From: Peter Chen To: Jisheng Zhang CC: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-kernel Subject: RE: [PATCH resend] usb: chipidea: Don't select EXTCON Thread-Topic: [PATCH resend] usb: chipidea: Don't select EXTCON Thread-Index: AQHT17S23GjAgRoHOUOzcNsdlHwgEKQI32DwgAB9iQCAAAaj0A== Date: Fri, 20 Apr 2018 09:35:54 +0000 Message-ID: References: <20180419160144.0412a510@xhacker.debian> <20180420170126.732e093b@xhacker.debian> In-Reply-To: <20180420170126.732e093b@xhacker.debian> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: synaptics.com; dkim=none (message not signed) header.d=none;synaptics.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB2175;7:8Y1xpqVGYKDXa3ySD0z8XSSDB2WzVhnOoDob8gsfy76AHD12jO+blvmUrfkinR25nN5vN/1uiNg+bHzAD1/39ZotNpZ4mjWecSGVb9wZuuNeUMQ+wcfO7+poVc9iHO4KH25RxPXgTacFTefgsWtHsrV/wzc/DpwF0bdkSI6pq8J2gcwo6ryghdj2/xeMi3ZyeY2lhCxE9TcGCV1i42Bs20G5GreCm29OUefpRSCefG+8FhTflq3OP7VWcc9nFNtu x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB2175; x-ms-traffictypediagnostic: VI1PR04MB2175: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231232)(944501392)(52105095)(10201501046)(93006095)(93001095)(6055026)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:VI1PR04MB2175;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB2175; x-forefront-prvs: 0648FCFFA8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39380400002)(346002)(39860400002)(376002)(396003)(366004)(25786009)(6436002)(5660300001)(7696005)(76176011)(4326008)(59450400001)(33656002)(5250100002)(6116002)(53936002)(305945005)(2900100001)(9686003)(478600001)(3846002)(6246003)(316002)(26005)(8936002)(2906002)(54906003)(3280700002)(74316002)(3660700001)(81166006)(7736002)(11346002)(229853002)(55016002)(446003)(8676002)(102836004)(44832011)(86362001)(6506007)(476003)(186003)(66066001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB2175;H:VI1PR04MB1455.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;MLV:sfv; x-microsoft-antispam-message-info: UYRgzxmihUPVwPZQSj5gHXHdl+1YrxxkEybpOSnyYogmwCFtcGkqfmXaDuFs8Q971nAXPLTd6sD4Imt9yvFh4dbLaGD4EyPddThOeSgNdPWFxnDIBunYJ6ayRt00nWerZooa9EoHGkijTSOt0qqS406ZEBatpRxSGW15Lvp//7IElkBp7lSCKLBrL6Z+0++0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1bc5fac3-8153-44c2-79e7-08d5a6a21cf4 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc5fac3-8153-44c2-79e7-08d5a6a21cf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2018 09:35:54.2708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2175 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =20 > > > > Sorry to reply late, are you really care 2KB code side? Since many > > users use EXTCON to handle vbus and id, it is hard just delete it. I > > could accept patch for your specific platforms, like: > > > > + select EXTCON if !ARCH_XXXX >=20 > The patch doesn't remove extcon support from chipidea driver. > I just want to not select EXTCON unconditionally, but let the users choos= e. If the > users need extcon, they could enable EXTCON themselves >=20 > I just searched all the dts in arch/arm/boot/dts and arch/arm64/boot/dts = only the four > dts give extcon phandle to chipidea host, other users don't make use of i= t: >=20 > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi >=20 > arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >=20 > arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts >=20 > arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dts >=20 I see, but I do not want to break msm platforms. You may try to create Glue= driver Kconfig entry for chipidea like dwc3, and let msm depends on EXTCON. Peter