Received: by 10.192.165.148 with SMTP id m20csp48110imm; Fri, 20 Apr 2018 02:49:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/3wDYG7tymI81gCiGaOthhul13oEuTgg5M6YNn2RxCnmADFbOwb9L7XJ0CStapEgfJBWHX X-Received: by 10.98.137.16 with SMTP id v16mr8956516pfd.13.1524217744096; Fri, 20 Apr 2018 02:49:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524217744; cv=none; d=google.com; s=arc-20160816; b=xYymm6SFOhaYRdcz5KuZLi85fVYqsLusRMOA0WUJ47uJMO8cuolCRpNy2Pf32prYzY SzbABvu8jAamwvCcwJKPLsccJyrOvfi8+cfosXpLdTvUWOLAU6tnIPSGos9BkcZOVJ/g E8/f5J7iNZKon+chgTTudl/bRbfJtg2+78ozyjXtctIRxOtvI52rDDriDb5UuQegCzUg lovkRSN0CWuCjzV9ML4ld/zPr70+63vNrqyaLC4aLMwlL9UwD28/tDDXRogCyrwpKUSW B5Dt4yC7oEuAZ38svbYtBjaaEoGBwsRXjhpk73GDkuUUcQMFfxLazgXK18S5nIkmXaA8 leVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=NxYFpiaFUVeYvS4oFyM9P7YJriay8BubWMDVxruWic0=; b=dOFnrWlS4ZAMrXVu1YS6rl1LYHLT87u97QxKK/eppvynzvZysSLYQnGIMSv5VhA85w uRDIMFMMV4YmjXFCBcKwGwluvZhvJUsWONVIQODYiZ2Ac66ASbKpd8bO6dkW8h7tX4k/ dl4Af31CCjJ9WQs5uotkNzn+W0aQtrCr8VryeI2MzMhLRzIcL/s+xhh3iV1zx0oLkksa XviW+eHi2jEX2NsnLn/056YNs9zahkW+tmoK3kx7EF2vn+KBWZ0oqzglpCUF/VsH4YAG dETG4CyJeGJ+8G4U7z6zIi+coYbm1eS+vaYoFRwXKFbqUW3EK1c4vFndm/t81IjUKUHk pVVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si4545902pgv.512.2018.04.20.02.48.49; Fri, 20 Apr 2018 02:49:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754513AbeDTJrT convert rfc822-to-8bit (ORCPT + 99 others); Fri, 20 Apr 2018 05:47:19 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:44573 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbeDTJrS (ORCPT ); Fri, 20 Apr 2018 05:47:18 -0400 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1f9SdO-0001p1-Ho; Fri, 20 Apr 2018 11:47:14 +0200 Date: Fri, 20 Apr 2018 11:47:14 +0200 From: Sebastian Andrzej Siewior To: Tobias Regnery Cc: joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: fix unused-variable warning Message-ID: <20180420094714.kjir26edq34i6ktq@linutronix.de> References: <20180420092836.12219-1-tobias.regnery@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20180420092836.12219-1-tobias.regnery@gmail.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-04-20 11:28:36 [+0200], Tobias Regnery wrote: > The iommu_table_lock is only used by code inside an ifdef CONFIG_IRQ_REMAP > block. This leads to the following warning with CONFIG_IRQ_REMAP=n: > > amd_iommu.c:86:24: warning: 'iommu_table_lock' defined but not used [-Wunused-variable] > > Guard the spinlock definition with the same ifdef. > > Fixes: ea6166f4b83e9 ("iommu/amd: Split irq_lookup_table out of the amd_iommu_devtable_lock") > Signed-off-by: Tobias Regnery Thank you for spotting this, I am waiting for Jörg to pick up this instead: http://lkml.kernel.org/r/20180404105713.633983-1-arnd@arndb.de Sebastian