Received: by 10.192.165.148 with SMTP id m20csp341537imm; Fri, 20 Apr 2018 07:39:22 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/iC8ZTomHHUSSPs+2dfFsA3npIPjasrMt7WHZKY9IYINIs1pCfuYUGEa6ud7IoddVrV69Z X-Received: by 2002:a17:902:5581:: with SMTP id g1-v6mr10550157pli.351.1524235162503; Fri, 20 Apr 2018 07:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524235162; cv=none; d=google.com; s=arc-20160816; b=a8+8BliOIgoSeaQDuJjAXz/qyoCz39UvFKrY3FuYIh9SCSc853180d2T4azt+51ehk 2zhDzD3MFTaIgqSKRQOmF0oONakLtrGa68ow77JM6WkluP0abEtg2ylezaOaZlijpToW PrR8s3St7cF/vtiJrzdGEIWheD71CgC3wnC1sfem129qqX+E4vTfXNT2PIAnoQjkyix6 fqzx3AIXKcF+vbVSnTJP0kQV5+ckVoe0xCxVpqoOuGrqS9P6aD1kLV0n8orMBTPuch6R QvbIxO5msENhC3Q+Opkjs4QXUQXbAdVFIYR+04TEEDLeO1ols2YP3He39XKKFljsLeJJ XXGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from :arc-authentication-results; bh=nSwHxl8AYQxkOdgmPC502OcbykXRtLDtDFUiU4EbMtw=; b=G7g05qTCJS8ANUcWM8yi1PizoRhdap49GiVh0jr3ksbDcnmawLDg6cXs3KoP4XpW/O 901/qBOktqcUZxy5MUPDLHTjTcX2vGij7dee4dITCDhM2vORJefmicHZqAlw1litr2nV rwTAF+5w3QWeqtSRUjLRPdVOPVgN5gjWtIZzviZmVLMGyTnAMGvyBck0XFYLSm4VR5Sm 2FQlQMLqYtRjZdYzeBXl19/ekf9K//HCkvcxQGPV4vbEx15OotEhju9SHVS33HRbakGg gp1YOOZ9SA4UV/7sAi/b5u/WAoXDsrDbwPtZtooGv8t7+zQOJI5JetBCPNkYE/YF2kAz yR+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i124si2170122pgd.111.2018.04.20.07.39.08; Fri, 20 Apr 2018 07:39:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755383AbeDTOht (ORCPT + 99 others); Fri, 20 Apr 2018 10:37:49 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:35340 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755338AbeDTOhp (ORCPT ); Fri, 20 Apr 2018 10:37:45 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XAN-0002SB-Cn; Fri, 20 Apr 2018 08:37:35 -0600 Received: from [97.119.174.25] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XA6-00064a-5p; Fri, 20 Apr 2018 08:37:33 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Cc: , Albert Ou , Aurelien Jacquiot , Chris Zankel , David Miller , Geert Uytterhoeven , Greentime Hu , Heiko Carstens , Helge Deller , Ivan Kokshaysky , James Bottomley , James Hogan , Jeff Dike , Jonas Bonn , Ley Foon Tan , Mark Salter , Martin Schwidefsky , Max Filippov , Michal Simek , nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, Palmer Dabbelt , Ralf Baechle , Richard Henderson , Richard Kuo , Richard Weinberger , Rich Felker , sparclinux@vger.kernel.org, stable@vger.kernel.org, Stafford Horne , Stefan Kristiansson , user-mode-linux-devel@lists.sourceforge.net, Vincent Chen , Yoshinori Sato References: <878t9ilmhv.fsf@xmission.com> Date: Fri, 20 Apr 2018 09:35:52 -0500 In-Reply-To: <878t9ilmhv.fsf@xmission.com> (Eric W. Biederman's message of "Thu, 19 Apr 2018 20:01:16 -0500") Message-ID: <87604mhrnb.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1f9XA6-00064a-5p;;;mid=<87604mhrnb.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.174.25;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+071iPiIPCK/nXuGRyDSgK32+6mbXObVc= X-SA-Exim-Connect-IP: 97.119.174.25 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa07.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.9 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,XMNoVowels,XMSolicitRefs_0 autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 1.5 TR_Symld_Words too many words that have symbols inside * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.1 XMSolicitRefs_0 Weightloss drug X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **; X-Spam-Relay-Country: X-Spam-Timing: total 15023 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 6 (0.0%), b_tie_ro: 4.9 (0.0%), parse: 0.82 (0.0%), extract_message_metadata: 3.8 (0.0%), get_uri_detail_list: 2.2 (0.0%), tests_pri_-1000: 6 (0.0%), tests_pri_-950: 1.19 (0.0%), tests_pri_-900: 1.03 (0.0%), tests_pri_-400: 32 (0.2%), check_bayes: 31 (0.2%), b_tokenize: 13 (0.1%), b_tok_get_all: 9 (0.1%), b_comp_prob: 2.4 (0.0%), b_tok_touch_all: 3.8 (0.0%), b_finish: 0.63 (0.0%), tests_pri_0: 366 (2.4%), check_dkim_signature: 0.51 (0.0%), check_dkim_adsp: 3.1 (0.0%), tests_pri_500: 14598 (97.2%), poll_dns_idle: 14591 (97.1%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 00/22] Simplifying siginfo users X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset is almost completely updating the various pieces of architecture code from filling out a struct siginfo and then calling force_sig_info. To using the helper force_sig_fault instead. Which takes the values that would have gone in siginfo as arguments. As the diffstat below shows this noticeable reduces the amount of code. There are a couple of minor and straight forward bug fixes as well that I came across while working on the aforementioned changes. This applies on my last round of siginfo changes simply to remove the possibility of conflicts. The changes should be semantically separate. I intend to merge these changes through my siginfo tree. If you have any objections or would prefer to carry these changes in your architecture trees please let me know. The changes are also available at: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git siginfo-review2 Eric W. Biederman (22): signal/alpha: Use send_sig_fault where appropriate signal/alpha: Use force_sig_fault where appropriate signal/c6x: Use force_sig_fault where appropriate signal/hexagon: Use force_sig_fault as appropriate signal/m68k: Use force_sig_fault where appropriate signal/microblaze: Remove the commented out force_sig_info in do_page_fault signal/microblaze: Use force_sig_fault where appropriate signal/mips: Use force_sig_fault where appropriate signal/nds32: Use force_sig_fault where appropriate signal/nios2: Use force_sig_fault where appropriate signal/openrisc: Use force_sig_fault where appropriate signal/parisc: Use force_sig_mceerr where appropriate signal/parisc: Use force_sig_fault where appropriate signal/riscv: Use force_sig_fault where appropriate signal/s390: Use force_sig_fault where appropriate signal/sh: Use force_sig_fault where appropriate signal/sparc: Use send_sig_fault where appropriate signal/sparc: Use force_sig_fault where appropriate signal/um: Use force_sig_fault in relay_signal. signal/um: Use force_sig_fault where appropriate signal/xtensa: Consistenly use SIGBUS in do_unaligned_user signal/xtensa: Use force_sig_fault where appropriate arch/alpha/kernel/osf_sys.c | 10 +-- arch/alpha/kernel/signal.c | 22 +----- arch/alpha/kernel/traps.c | 80 +++++--------------- arch/alpha/mm/fault.c | 15 +--- arch/c6x/kernel/traps.c | 10 +-- arch/hexagon/kernel/traps.c | 10 +-- arch/hexagon/mm/vm_fault.c | 21 ++---- arch/m68k/kernel/traps.c | 60 +++++++-------- arch/m68k/mm/fault.c | 25 +++---- arch/microblaze/kernel/exceptions.c | 9 +-- arch/microblaze/mm/fault.c | 14 +--- arch/mips/kernel/traps.c | 65 +++++----------- arch/mips/mm/fault.c | 19 ++--- arch/nds32/kernel/traps.c | 20 +---- arch/nds32/mm/fault.c | 19 ++--- arch/nios2/kernel/traps.c | 9 +-- arch/openrisc/kernel/traps.c | 33 +------- arch/openrisc/mm/fault.c | 19 ++--- arch/parisc/kernel/ptrace.c | 11 +-- arch/parisc/kernel/traps.c | 63 +++++----------- arch/parisc/kernel/unaligned.c | 16 +--- arch/parisc/math-emu/driver.c | 9 +-- arch/parisc/mm/fault.c | 55 +++++++------- arch/riscv/kernel/traps.c | 9 +-- arch/s390/kernel/traps.c | 32 ++------ arch/s390/mm/fault.c | 23 ++---- arch/sh/kernel/traps_32.c | 19 ++--- arch/sh/math-emu/math.c | 9 +-- arch/sh/mm/fault.c | 10 +-- arch/sparc/kernel/process_64.c | 10 +-- arch/sparc/kernel/sys_sparc_32.c | 9 +-- arch/sparc/kernel/sys_sparc_64.c | 8 +- arch/sparc/kernel/traps_32.c | 114 +++++----------------------- arch/sparc/kernel/traps_64.c | 145 +++++++----------------------------- arch/sparc/kernel/unaligned_32.c | 12 +-- arch/sparc/mm/fault_32.c | 13 +--- arch/sparc/mm/fault_64.c | 9 +-- arch/um/kernel/ptrace.c | 13 +--- arch/um/kernel/trap.c | 54 ++++++-------- arch/xtensa/kernel/traps.c | 10 +-- arch/xtensa/mm/fault.c | 19 ++--- 41 files changed, 280 insertions(+), 852 deletions(-) Eric