Received: by 10.192.165.148 with SMTP id m20csp345907imm; Fri, 20 Apr 2018 07:43:31 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+5tziM0mEl358Gjtiq5E8Us5kW7PW9Yl4q1JdyXOrFN8xEZQ9m1b2TFKv9m7BEOimURyqm X-Received: by 10.101.99.90 with SMTP id p26mr8732035pgv.188.1524235411609; Fri, 20 Apr 2018 07:43:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524235411; cv=none; d=google.com; s=arc-20160816; b=BIdn9iirHJOmEp4ALTDtWPrQR0wQMsISkmNWWK5m90oqf0u8Tw4K70KQa2AoZl/rbg /BXq4NH0eED07vK5h9iAOhzFag9gwHPVCGc3kLySERcq1kI2pXm3t8ND791mJ1qbKxIw B20x2RUFdZZXfCihWldMB/Yt4DK9HP/Dmn3CvgpNtNVAEADN2J/JAU4+I7Mwob3epJ9f gxn17gl8MrFwyTesyxfw444Esvg8Np4G2zJ8/3LoZOntxZ1sYfruhyjUERVmNy6Udv+v 1xYQHZhKXhbXnXzB0jbrDw3gFVmuERDEYWNRz5awI2+rIo3EAy9IASdgpoc3x3QuO+RJ /6ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=Sbl0Yg5E5wJ/WJC0P5EpvFoZyGlsNLNm9aF63VuaRww=; b=zHP1gE31/KZV4A4MCeHCRF2lSRKVdtZt/Fg8VKwXB4PdV2AtmlG4NXqWpgHRGVVzBe f347QQn0MFP+yLo0Kbc4nUylQOxacaY6FApPuTtTft17lNMtaR8r91ISf4zLRAyyt8Wg x6JRXxek97kmaA+itd6UJeuZ3L7j3xqHVCR9L3jgLF51C1iNUN5Ic5KGIPMvQOIUh8Yv eHssDWc0IfVNjuM8EfYNXCZuo1SMYO3AtiMMQv92/abNMX1/0sMzNKfLcgeYfpCg5qZB 36UNd0hMShcmR5ol5BiKL0pessMh7tCZLe8tb5SL4x95cdO77pNk2qRHNCu+Ox+tVW6L 7T4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c129si5647100pfa.99.2018.04.20.07.43.17; Fri, 20 Apr 2018 07:43:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbeDTOl5 (ORCPT + 99 others); Fri, 20 Apr 2018 10:41:57 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:44238 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755165AbeDTOkn (ORCPT ); Fri, 20 Apr 2018 10:40:43 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XDO-0007W2-R8; Fri, 20 Apr 2018 08:40:42 -0600 Received: from [97.119.174.25] (helo=x220.int.ebiederm.org) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XDO-0006Ha-8t; Fri, 20 Apr 2018 08:40:42 -0600 From: "Eric W. Biederman" To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" , Michal Simek Date: Fri, 20 Apr 2018 09:37:55 -0500 Message-Id: <20180420143811.9994-6-ebiederm@xmission.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <87604mhrnb.fsf@xmission.com> References: <87604mhrnb.fsf@xmission.com> X-XM-SPF: eid=1f9XDO-0006Ha-8t;;;mid=<20180420143811.9994-6-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.174.25;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18Hyx9ICHN8PIGMd+4W7xawfPRAC8wOmR8= X-SA-Exim-Connect-IP: 97.119.174.25 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa08.xmission.com X-Spam-Level: *** X-Spam-Status: No, score=3.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, XMNoVowels,XMSubLong autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 1.5 TR_Symld_Words too many words that have symbols inside * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa08 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa08 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ***;linux-arch@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 129 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 4.2 (3.3%), b_tie_ro: 3.1 (2.4%), parse: 0.98 (0.8%), extract_message_metadata: 13 (10.0%), get_uri_detail_list: 1.31 (1.0%), tests_pri_-1000: 6 (4.4%), tests_pri_-950: 1.04 (0.8%), tests_pri_-900: 0.89 (0.7%), tests_pri_-400: 16 (12.1%), check_bayes: 15 (11.4%), b_tokenize: 3.2 (2.5%), b_tok_get_all: 4.4 (3.4%), b_comp_prob: 1.05 (0.8%), b_tok_touch_all: 3.8 (3.0%), b_finish: 0.73 (0.6%), tests_pri_0: 81 (62.6%), check_dkim_signature: 0.35 (0.3%), check_dkim_adsp: 2.9 (2.3%), tests_pri_500: 4.5 (3.5%), poll_dns_idle: 0.41 (0.3%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 06/22] signal/microblaze: Remove the commented out force_sig_info in do_page_fault X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the commented out call to force_sig_info right after a call to _exception in do_page_fault. The function _exception does exactly the work the commented out code does so there is no reason for the commented out code. Cc: Michal Simek Signed-off-by: "Eric W. Biederman" --- arch/microblaze/mm/fault.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/microblaze/mm/fault.c b/arch/microblaze/mm/fault.c index 43d92167012a..1251d380df47 100644 --- a/arch/microblaze/mm/fault.c +++ b/arch/microblaze/mm/fault.c @@ -268,11 +268,6 @@ void do_page_fault(struct pt_regs *regs, unsigned long address, /* User mode accesses cause a SIGSEGV */ if (user_mode(regs)) { _exception(SIGSEGV, regs, code, address); -/* info.si_signo = SIGSEGV; - info.si_errno = 0; - info.si_code = code; - info.si_addr = (void *) address; - force_sig_info(SIGSEGV, &info, current);*/ return; } -- 2.14.1