Received: by 10.192.165.148 with SMTP id m20csp347706imm; Fri, 20 Apr 2018 07:45:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx48el6Nfk5Pb2AK7xxTWN2aaFQXd9VH3zoZKI23vZI2QwCAnBSYynChiLZFvX7kQiZ7Zv9Ak X-Received: by 10.98.102.79 with SMTP id a76mr9985622pfc.162.1524235521240; Fri, 20 Apr 2018 07:45:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524235521; cv=none; d=google.com; s=arc-20160816; b=IGwXE6hzfMpSX6AClEiKhdP70soV4Fwl+wdATNMUv0NxYuWqPiIb/Juw1EXqbskIno GVmVc+cGbgGdG1Rrm1eSQxet3UWqdwaIarDT3iaVF/BJvyecnwFm+FAvm8kPIZfkPgHe nurZFMESFpRtXP7kJkSKyOHx8zH5cueHkFZj1huwk69lxwAJ+YEEoLk+ktiCfrF20xjg HSb9wlEOYm40QMsSqUhx12UZrKD9FIewL/Zg7q0hZti5Mf2pHC6AxesIV/ZdG3g3WTn0 /PgaiN2h8+YCCMZsT+KlU27u7pL2oKQC1cYXK8RlhiGD2W1kG8+drsoFHHKz0vjcS8G1 lShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=IUnlF9vPjyoQZeo5gr+hMGdTQT15KkIVyOyTqTbTRTo=; b=nlM8NE19p80DeJf5RJIBp7Hrxe+NMiRt1C+XtOfTG4DZU+D8FDb3CDveu35Wg55Vg7 Sd7HFRJBTCej9FJOPZ34oOLNqqE2cxiBfvSlWwW4HZ+kuexSCL8d4Yy/wvPDRK2sD+IE OOPRtkYN+lmP7d0hvwjYHruUPnu4JMkXVQdIZ9PbIGhH/ChV4UheU/vLi3zmcOHvf6jC NHZvCzi8TT2HKgs4Dtf26EUr/IRVdALeWARZVidWURqGYYgoZP2qbmvt+DO9o9CR8E+M v1JHLZXkZaKd5OAfXFQAmLpnm1xBj2fKpDR3REZeqFuhkNEes76aUS6nHgt0pt23OGTe DBTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16-v6si5538053pll.325.2018.04.20.07.45.06; Fri, 20 Apr 2018 07:45:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755298AbeDTOoH (ORCPT + 99 others); Fri, 20 Apr 2018 10:44:07 -0400 Received: from muru.com ([72.249.23.125]:37424 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755191AbeDTOoF (ORCPT ); Fri, 20 Apr 2018 10:44:05 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id B1DF58105; Fri, 20 Apr 2018 14:45:45 +0000 (UTC) Date: Fri, 20 Apr 2018 07:44:01 -0700 From: Tony Lindgren To: Daniel Stone Cc: Tomi Valkeinen , Sebastian Reichel , Sebastian Reichel , Pavel Machek , Laurent Pinchart , Rob Herring , Mark Rutland , dri-devel , devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Linux Kernel Mailing List , kernel@collabora.com Subject: Re: [PATCHv3 3/8] drm/omap: add support for manually updated displays Message-ID: <20180420144401.GO5671@atomide.com> References: <20180330171822.25896-1-sebastian.reichel@collabora.co.uk> <20180330171822.25896-4-sebastian.reichel@collabora.co.uk> <20180420142533.GN5671@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Stone [180420 14:41]: > Hi Tony! > > On 20 April 2018 at 15:25, Tony Lindgren wrote: > > * Daniel Stone [180420 10:21]: > >> On 20 April 2018 at 08:09, Tomi Valkeinen wrote: > >> > It's actually not quite clear to me how manual update displays work with > >> > DRM... > >> > > >> > As far as I see, we have essentially two cases: 1) single buffering, > >> > where the userspace must set an area in the fb dirty, which then > >> > triggers the update, 2) multi buffering, which doesn't need fb dirty, > >> > but just a page flip which triggers the update. > >> > > >> > In the 2) case (which I think is the optimal case which all the modern > >> > apps should use), there's no need for delayed work or any work, and the > >> > code flow should be very similar to the auto-update model. > >> > >> Correct. There's been talk (and I think patches?) of adding a > >> per-plane dirty property, so userspace can as an optimisation inform > >> the kernel of the area changed between frames. But short of that, a > >> pageflip needs to trigger a full-plane update, with no dirtyfb > >> required. > > > > For per-plane dirty property patches, which ones do you refer to? > > Here's the latest iteration of that series: > https://lists.freedesktop.org/archives/dri-devel/2018-April/171900.html > <1522885748-67122-1-git-send-email-drawat@vmware.com> OK thanks for the link. > > Then for xorg, there's my second attempt on fixing the command mode > > rotation at [0]. Not sure if that's enough for a fix? > > > > It seems not very efficient to me and I don't really know where > > the the per crtc dirty flag should be stored.. > > I try to deny all knowledge of X11 these days, I'm afraid. :) Tony