Received: by 10.192.165.148 with SMTP id m20csp353901imm; Fri, 20 Apr 2018 07:51:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+//XagaBasYR153Vtvy7WzXNujyZ89CZ2MPTIpGMLcaagDi/mgXL4iN1zH2/pCYoZ/qC43 X-Received: by 10.99.51.137 with SMTP id z131mr8869018pgz.386.1524235896574; Fri, 20 Apr 2018 07:51:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524235896; cv=none; d=google.com; s=arc-20160816; b=mZ9nUjK+ZDStvfAIR2LWZSwP3/Sw1PcDZCCxvx00T1L2joTde88qgBCktRakIGa98U cb/fOEtVnBMKODNk7rgQzvSeVaEZurj9YcVmnuwzO0UNgLqtU8gJogENtG1mmHRloeH6 Wg+gH9Wsb4ZuTImQgsxV+7DbROpETObX2uL3eyTgc8CYxP6NMY/FXb90Goon/daMLfiB aEbo4SapkXA7+eCnhxwkcafK2vtM3nI7gwMOc/i1RisIj2Qb29AjqnA06lNEQGMVuWjz tAda8CR9dTDsmBkovlohIYFSnEvm9EELVlxWgaMME7uTRSAisTgngq5YiKqlm7A4El9S XDhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=eGW4kbTZ2xZ0p9ArOU6JJQfvPyrFDVN1KVxaBkq1BgU=; b=Ei5DIPLYsYxp9B1x+ciJqZU2rc53WkFtpVlO3ARUYyufRERpsYPr53RmrjNxK/ejoQ TyEbzEabBUnAsbpmN93V8E3FLd/tXkwHXGi2yf5ShJcrJtcBuWMYWoalwYE6isWVMrus apDfAg0xMn6ztj0+yENfY3liTNP2/Qf/E1XfC0Szsp3kngAsLw093ETca1Rv4PV8F+tf cfFluOvhr+Z6QrogLNmZgZZmcj6y/jp0HtcT+T4dtoAKUjrDW4rG40Rl/JzKcYn8pmuF QXsapbMsl3LfskdkakUg/9Awp59l4vwtO9CkHgXfU3qxRYjjsgkt4ttWnVzXhAXmz563 WOQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si5624317pfg.222.2018.04.20.07.51.21; Fri, 20 Apr 2018 07:51:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323AbeDTOtW (ORCPT + 99 others); Fri, 20 Apr 2018 10:49:22 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:44843 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755199AbeDTOqD (ORCPT ); Fri, 20 Apr 2018 10:46:03 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XIZ-00087j-2s; Fri, 20 Apr 2018 08:46:03 -0600 Received: from [97.119.174.25] (helo=x220.int.ebiederm.org) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f9XFL-0006Ha-Ej; Fri, 20 Apr 2018 08:42:43 -0600 From: "Eric W. Biederman" To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, stable@vger.kernel.org Date: Fri, 20 Apr 2018 09:38:10 -0500 Message-Id: <20180420143811.9994-21-ebiederm@xmission.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <87604mhrnb.fsf@xmission.com> References: <87604mhrnb.fsf@xmission.com> X-XM-SPF: eid=1f9XFL-0006Ha-Ej;;;mid=<20180420143811.9994-21-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.119.174.25;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18i8hJSYIdg6fuMl9u1yXGnn+6OXyrVp48= X-SA-Exim-Connect-IP: 97.119.174.25 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa06.xmission.com X-Spam-Level: *** X-Spam-Status: No, score=3.9 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,FVGT_m_MULTI_ODD,TR_Symld_Words,T_TM2_M_HEADER_IN_MSG, T_TooManySym_01,XMNoVowels,XMSubLong autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 TR_Symld_Words too many words that have symbols inside * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4997] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.4 FVGT_m_MULTI_ODD Contains multiple odd letter combinations X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ***;linux-arch@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 193 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 2.5 (1.3%), b_tie_ro: 1.80 (0.9%), parse: 0.64 (0.3%), extract_message_metadata: 14 (7.5%), get_uri_detail_list: 1.26 (0.7%), tests_pri_-1000: 8 (3.9%), tests_pri_-950: 1.19 (0.6%), tests_pri_-900: 0.97 (0.5%), tests_pri_-400: 16 (8.4%), check_bayes: 15 (7.9%), b_tokenize: 5 (2.7%), b_tok_get_all: 5 (2.7%), b_comp_prob: 1.45 (0.8%), b_tok_touch_all: 1.68 (0.9%), b_finish: 0.53 (0.3%), tests_pri_0: 115 (59.6%), check_dkim_signature: 0.43 (0.2%), check_dkim_adsp: 2.2 (1.1%), tests_pri_500: 32 (16.7%), poll_dns_idle: 25 (13.1%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 21/22] signal/xtensa: Consistenly use SIGBUS in do_unaligned_user X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While working on changing this code to use force_sig_fault I discovered that do_unaliged_user is sets si_signo to SIGBUS and passes SIGSEGV to force_sig_info. Which is just b0rked. The code is reporting a SIGBUS error so replace the SIGSEGV with SIGBUS. Cc: Chris Zankel Cc: Max Filippov Cc: linux-xtensa@linux-xtensa.org Cc: stable@vger.kernel.org Fixes: 5a0015d62668 ("[PATCH] xtensa: Architecture support for Tensilica Xtensa Part 3") Signed-off-by: "Eric W. Biederman" --- arch/xtensa/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/xtensa/kernel/traps.c b/arch/xtensa/kernel/traps.c index 51771929f341..90b509f65b6f 100644 --- a/arch/xtensa/kernel/traps.c +++ b/arch/xtensa/kernel/traps.c @@ -339,7 +339,7 @@ do_unaligned_user (struct pt_regs *regs) info.si_errno = 0; info.si_code = BUS_ADRALN; info.si_addr = (void *) regs->excvaddr; - force_sig_info(SIGSEGV, &info, current); + force_sig_info(SIGBUS, &info, current); } #endif -- 2.14.1