Received: by 10.192.165.148 with SMTP id m20csp393707imm; Fri, 20 Apr 2018 08:25:55 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/9kG/UbdkQEEf6pog+JWawoMrww6MZFuhxkvWDxVgh1w4+x83wbyyizTvE91h2L0zX1rvJ X-Received: by 2002:a17:902:7004:: with SMTP id y4-v6mr10993692plk.3.1524237955494; Fri, 20 Apr 2018 08:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524237955; cv=none; d=google.com; s=arc-20160816; b=Wt2BRfe3KlSZz0m1inzXul013XQA/Yg5Ee9fOP1yrL3ADKfuImmTbyPyIzdls9azVZ IPNtQkAlPufjHod5pZdd6P6wGzl1pQs1urL3DeFPvZwROfuEgf2Ky413+iIr1FANaIpz 9jN+lxBAFzzIi86m/hpi25RzbFHsdUrAb9id9/cHeP5SE19juI3ppzm8BuRkz+Uzz/PB gewmnqF/VcU+e2snLksM80NCvFG4CpKUqiKCc2ZFpYsO+Xs5tWAYvPim9JYK3DIBDDng hIWmpsF3qOTZ0j3YB/c85WUPiJd1BoUCdKPOjFsLbtHdUxiyMSS/0YzgDCEbIg8MIVYj TxqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dmarc-filter:arc-authentication-results; bh=+zqAPJOANFtsNO7Y1Jhbo+/aE49mnTniZBoB792rbBc=; b=xImFVZP3uj7fJwCEierWSw4xUCkDb/5rqB6CzY8FR5QVIVg223dp5YW80vaaeaHclu 0IfxIUZTHsvKI7FP8QStGZ9BO1JaQ0OMbbR5ZY8hcf4Jhcgym0ivFZWON8ap/IhCU6Mr mZfeiO4/PFGAasToJjwyrc7HYaTSyGQpm//fzhwfDjumaL2vV6CHcb/ejwlzBuzT7Bqq b1zkBLOfYbAnteL2Iri3wJXZ40FoqIzD/GSL6x////kIjZ1OIkmcw2OBweZNE/VS86si +QxqJBZqnnNA28dxzsZAYuOwSfLzUKLJ42HXSuivgwQflGszIXx69IHP7OrMzbTPYTGC 0CRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si4986355pgq.76.2018.04.20.08.25.41; Fri, 20 Apr 2018 08:25:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780AbeDTPYf (ORCPT + 99 others); Fri, 20 Apr 2018 11:24:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755566AbeDTPYe (ORCPT ); Fri, 20 Apr 2018 11:24:34 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7476720652; Fri, 20 Apr 2018 15:24:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7476720652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 20 Apr 2018 11:24:31 -0400 From: Steven Rostedt To: Miklos Szeredi Cc: Song Liu , LKML , Kernel Team , Ingo Molnar , Howard McLauchlan , Josef Bacik , Srikar Dronamraju Subject: Re: [PATCH v2] tracing: fix bad use of igrab in trace_uprobe.c Message-ID: <20180420112431.42762006@gandalf.local.home> In-Reply-To: References: <20180418174014.1592871-1-songliubraving@fb.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Apr 2018 16:34:25 +0200 Miklos Szeredi wrote: > This corner case is simply not interesting (modifying a binary while > it is being debugged with uprobe). Let's just concentrate on making > this crash and leak free. Yes please. I'm waiting for a final patch to run my tests. I have other patches that need to go mainline as well, and I'll start testing all of them when I get the final version of this one. -- Steve