Received: by 10.192.165.148 with SMTP id m20csp411511imm; Fri, 20 Apr 2018 08:43:22 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+UdfWR5jYIAiE/O8PcnorW0zcDvFJQR2qMbDNhmAGddOCIkTmZkMB/vC6bW/CGG7veOGzV X-Received: by 10.101.78.134 with SMTP id b6mr8734041pgs.392.1524239002866; Fri, 20 Apr 2018 08:43:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524239002; cv=none; d=google.com; s=arc-20160816; b=JwjuxFNaZvCHUbFg9V5J3ttZ+xHz8ABP3zT+nRN5Eh/m7zaRDZ8c/fZv8S163X5NmG wjERMpNOyjmtqtKVnqBnrr6XknzeUCVcN4Pp6YXeh1RyznshK6puFa5KQiI1bKxIIScA 9wXQ6h/vOdnv+Dpz4dYiYvbAlt5fQQNG4rxP+7PrWS3d9PN0ttL8Ml8G9bgo+AL0khOD CI4HRe81Sem+lNVCCu0RuoxXf7K9awgxj2U5ftfKpck2zu+yZDQu/ROGY8x/jm/alzGN 9zPvc6JVLMHGXkmc0uEWEYs/EqlUJf3g9okWYEjhzMKKr4aoD8S0DPUVT6hi9lP7nKHA oWeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=VNmR0nypBnxqzLhvMYLnc3XEbICPgDjSHI4iV2NwDR0=; b=nel4tCRzhLomyruwhQsWZyWfB+G7a6jSaY4mHAVjgZSJO6tTLEfeP2G8FnX2DB0tNB ECMXrmCGw7Xvp5/vNEDpDxYQ6QBaft8qtl3d5IdPeO1kyxZ2MPoARtUBr8J8yXMVUl7q ceLvZ57wuYZEpHrJ1do93LTGkczuKlQafjz0ij8b61fLQvP+yCIHRyhDtJNOL57pvSgf 4ny+gX6qUNao72soLBxMTF2MZSikowqGFmXONzpef+mkjdf4lDyz7ZB3aKFq1JvOLR5o BQX9fhPaAizXJWm8FVZRJ/0n4FSZY0/P654mE4GRQPI5sgDwXCl91trf83Kourbv8aGs 2GsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8-v6si6191970plk.550.2018.04.20.08.42.38; Fri, 20 Apr 2018 08:43:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755836AbeDTPjX (ORCPT + 99 others); Fri, 20 Apr 2018 11:39:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:42839 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755683AbeDTPjW (ORCPT ); Fri, 20 Apr 2018 11:39:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2D937ADFD; Fri, 20 Apr 2018 15:39:21 +0000 (UTC) Date: Fri, 20 Apr 2018 08:25:07 -0700 From: Davidlohr Bueso To: peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org Cc: longman@redhat.com, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 3/2] rtmutex: Use waiter debug init,free magic numbers Message-ID: <20180420152507.sn2ozymqvefvxuci@linux-n805> References: <20180410162750.8290-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180410162750.8290-1-dave@stgolabs.net> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... we already use these for regular mutexes, rtmutex can also use it, and while at it rename the whole thing since this is specific to waiters. Signed-off-by: Davidlohr Bueso --- include/linux/poison.h | 4 ++-- kernel/locking/mutex-debug.c | 4 ++-- kernel/locking/rtmutex-debug.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/poison.h b/include/linux/poison.h index 15927ebc22f2..99119d34857e 100644 --- a/include/linux/poison.h +++ b/include/linux/poison.h @@ -79,8 +79,8 @@ #define ATM_POISON 0xdeadbeef /********** kernel/mutexes **********/ -#define MUTEX_DEBUG_INIT 0x11 -#define MUTEX_DEBUG_FREE 0x22 +#define MUTEX_WAITER_DEBUG_INIT 0x11 +#define MUTEX_WAITER_DEBUG_FREE 0x22 #define MUTEX_POISON_WW_CTX ((void *) 0x500 + POISON_POINTER_DELTA) /********** lib/flex_array.c **********/ diff --git a/kernel/locking/mutex-debug.c b/kernel/locking/mutex-debug.c index 9aa713629387..79b71421d763 100644 --- a/kernel/locking/mutex-debug.c +++ b/kernel/locking/mutex-debug.c @@ -29,7 +29,7 @@ */ void debug_mutex_lock_common(struct mutex *lock, struct mutex_waiter *waiter) { - memset(waiter, MUTEX_DEBUG_INIT, sizeof(*waiter)); + memset(waiter, MUTEX_WAITER_DEBUG_INIT, sizeof(*waiter)); waiter->magic = waiter; INIT_LIST_HEAD(&waiter->list); } @@ -45,7 +45,7 @@ void debug_mutex_wake_waiter(struct mutex *lock, struct mutex_waiter *waiter) void debug_mutex_free_waiter(struct mutex_waiter *waiter) { DEBUG_LOCKS_WARN_ON(!list_empty(&waiter->list)); - memset(waiter, MUTEX_DEBUG_FREE, sizeof(*waiter)); + memset(waiter, MUTEX_WAITER_DEBUG_FREE, sizeof(*waiter)); } void debug_mutex_add_waiter(struct mutex *lock, struct mutex_waiter *waiter, diff --git a/kernel/locking/rtmutex-debug.c b/kernel/locking/rtmutex-debug.c index fd4fe1f5b458..95e9d8efce60 100644 --- a/kernel/locking/rtmutex-debug.c +++ b/kernel/locking/rtmutex-debug.c @@ -157,14 +157,14 @@ void debug_rt_mutex_proxy_unlock(struct rt_mutex *lock) void debug_rt_mutex_init_waiter(struct rt_mutex_waiter *waiter) { - memset(waiter, 0x11, sizeof(*waiter)); + memset(waiter, MUTEX_WAITER_DEBUG_INIT, sizeof(*waiter)); waiter->deadlock_task_pid = NULL; } void debug_rt_mutex_free_waiter(struct rt_mutex_waiter *waiter) { put_pid(waiter->deadlock_task_pid); - memset(waiter, 0x22, sizeof(*waiter)); + memset(waiter, MUTEX_WAITER_DEBUG_FREE, sizeof(*waiter)); } void debug_rt_mutex_init(struct rt_mutex *lock, const char *name, struct lock_class_key *key) -- 2.13.6