Received: by 10.192.165.148 with SMTP id m20csp484305imm; Fri, 20 Apr 2018 09:53:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+fC7k2AxSHJNZp+5dNjSc3/DWp2VlNJIrzk3+AO01JWH1fvAYWMVkPOn6CC2dgywEholkN X-Received: by 2002:a17:902:51ce:: with SMTP id y72-v6mr10735588plh.157.1524243215691; Fri, 20 Apr 2018 09:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524243215; cv=none; d=google.com; s=arc-20160816; b=jkeL7Hb4IQX16fMacO4XS0I/t63ISdM8MYHAtSzW8wlUGS0uaBHmM3ffMsCHvWnrhA BVau3av5Qus3gYjnJIPSTzcV5RVDP2JWcHmxGFZjp+3ALIxfGExVhjQYorjFeE7GO9DZ ZQUEF4GweGt59T2aDDfan1tfArXzO5on4rIuMqH6w5zNqUEyir1PkHr5GCkil4oL5ng+ EgiK/UlT3R7VCOu3HQqZTzmjTvjjZ5G8SPThSyR3dNjNT6wgBzWW2y5WwB5HmKjh7QY7 agKHg5xaOYj3OBRTurLdpFfaa0Tc/fckMHprQMtRAnjA/RlVcMC5A0JPBp+2sucV6LUp 87xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=IzTtJ+CYGFlpyB4eLSDXUuAR8Xqk8FKE82q2mSwpcIU=; b=Y1jpjd51nsO4QBA90UnGJfzgJK8T4It61rjPiO0teKlW7SB3l6ft0KhkR34xO19C68 4Ufw9eRJmFkPXMgQ4/hNs7ufUtPe4iXZ2m3ZZEJwuNCd6cMNz/IUxSYjVEVVL/msPpGs FHp7DY2en+VR5T++MwJ73FZx7NWp/ZL1aCTDSluBVvloFHqEIxNv9n0tjzCFhIOR3wxw LoXliDy1AhxchZRXDbo/cLAHBaP2EQj+v7bcwPW0o871qWzCIsiJPyhKgSQpKugp3DoZ 6ae5dJB2IIeSFxXE2ZGM69FwUptRjUegMXKo1lMXk5olt+MxO07a4coImMtOJ3BNXTn9 ustA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si5522357pfh.3.2018.04.20.09.53.21; Fri, 20 Apr 2018 09:53:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbeDTQvt (ORCPT + 99 others); Fri, 20 Apr 2018 12:51:49 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34376 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbeDTQvr (ORCPT ); Fri, 20 Apr 2018 12:51:47 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1f9ZGD-0001ht-Bh; Sat, 21 Apr 2018 00:51:45 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1f9ZGB-0002EE-KN; Sat, 21 Apr 2018 00:51:43 +0800 Date: Sat, 21 Apr 2018 00:51:43 +0800 From: Herbert Xu To: Salvatore Mesoraca Cc: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-crypto@vger.kernel.org, "David S. Miller" , Kees Cook , Eric Biggers , Laura Abbott Subject: Re: [PATCH v2 0/2] crypto: removing various VLAs Message-ID: <20180420165143.mwcxwkf6j7ddckdt@gondor.apana.org.au> References: <1523282087-22128-1-git-send-email-s.mesoraca16@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523282087-22128-1-git-send-email-s.mesoraca16@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 09, 2018 at 03:54:45PM +0200, Salvatore Mesoraca wrote: > v2: > As suggested by Herbert Xu, the blocksize and alignmask checks > have been moved to crypto_check_alg. > So, now, all the other separate checks are not necessary. > Also, the defines have been moved to include/crypto/algapi.h. > > v1: > As suggested by Laura Abbott[1], I'm resending my patch with > MAX_BLOCKSIZE and MAX_ALIGNMASK defined in an header, so they > can be used in other places. > I took this opportunity to deal with some other VLAs not > handled in the old patch. > > [1] http://lkml.kernel.org/r/4e536889-439a-49e6-dd95-2d4286913202@redhat.com > > Salvatore Mesoraca (2): > crypto: api - laying defines and checks for statically allocated > buffers > crypto: remove several VLAs > > crypto/algapi.c | 10 ++++++++++ > crypto/cfb.c | 7 +++---- > crypto/cipher.c | 3 ++- > crypto/ctr.c | 4 ++-- > crypto/cts.c | 5 +++-- > crypto/pcbc.c | 5 +++-- > include/crypto/algapi.h | 8 ++++++++ > 7 files changed, 31 insertions(+), 11 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt