Received: by 10.192.165.148 with SMTP id m20csp502439imm; Fri, 20 Apr 2018 10:10:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx48EFLed94rAPMNZt0nWCrdp/wEcX+iYhtfExHnSE+4EASymGtfIkLDveGfNq36MLd5lKUI+ X-Received: by 10.167.128.81 with SMTP id y17mr10294820pfm.194.1524244204200; Fri, 20 Apr 2018 10:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524244204; cv=none; d=google.com; s=arc-20160816; b=G9hfAhmuluI8Tr42crzvj+USbs3cBHCU/cGfLrpVOwGi2j3lLQykq/T1WVzjwDMiR9 BHIyVrv7qv+M0/lWv4neppIrbV8S6ZNpclWe+ewE1z9iL7WsRSj6L2sp1Ng/1WEhuK1m uueBWMU5mF2WsOYzsDlwAY+SxER2kLq2XMFqUDexbD9+lO/i7X7ujITzUsF5OnYDdQre jgPhZNs2az6nRT+WHsi70UZfN6mMpeTG/TVTwp8T05fak4UoXpS68VR8tr6YP2wQUHId eSIn4Y/7kDuaS7HOZ4ULOJoTAT624k8OtHOGlXYVOy2z5FzoDeTdQdGpAP2P0hqWopHE O6/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=9HgxRl6q1ZDJTjBVW2OSCHkLGPA30NnNW+KWsy25ulU=; b=V9I6O1KCeyuV1uvcMoGeKD6Hpd2OQISztBY/SYj801QiY9EahyfdZ/Q/qeed6e8nhL I823ZmzbG5PyZAIcTQ6QOij7FHcg0CSEIP96VInQymnntqMJVq0UcwJJwaYKtHVAj6bf GSiLkyN9/cT5DQhHKYFaIk9Pnu2uznnOjX8mfapSHyJ9lynge8FsTc6VIu9hz25yrIeT BBo9YZQ4+Zj7stJ9Klse5nUdcx4wu5T28mrntcIAq2LVaMMuN9u99D/l5uiOUOzvUSfF pKPWzTaLmKcPaiYEy380PyPtRTv/GgGbLQC+AQW3Czqmh7Q71ugeoekP0o90GS+HYj2F r4Iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si5031532pgv.487.2018.04.20.10.09.49; Fri, 20 Apr 2018 10:10:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753824AbeDTRHx (ORCPT + 99 others); Fri, 20 Apr 2018 13:07:53 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:47049 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbeDTRDl (ORCPT ); Fri, 20 Apr 2018 13:03:41 -0400 Received: from 167-98-27-229.cust-167.exponential-e.net ([167.98.27.229] helo=ct-lt-1121.codethink.co.uk) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1f9ZRh-0007hw-SU; Fri, 20 Apr 2018 18:03:38 +0100 From: Jorge Sanjuan To: tiwai@suse.com Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Jorge Sanjuan Subject: [PATCH 1/4] ALSA: usb-audio: UAC3. Add support for mixer unit. Date: Fri, 20 Apr 2018 18:03:24 +0100 Message-Id: <20180420170327.31569-2-jorge.sanjuan@codethink.co.uk> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180420170327.31569-1-jorge.sanjuan@codethink.co.uk> References: <20180420170327.31569-1-jorge.sanjuan@codethink.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds support for the MIXER UNIT in UAC3. All the information is obtained from the (HIGH CAPABILITY) Cluster's header. We don't read the rest of the logical cluster to obtain the channel config as that wont make any difference in the current mixer behaviour. The name of the mixer unit is not yet requested as there is not support for the UAC3 Class Specific String requests. Tested in an UAC3 device working as a HEADSET with a basic mixer unit (same as the one in the BADD spec) with no controls. Signed-off-by: Jorge Sanjuan --- include/uapi/linux/usb/audio.h | 13 +++++++-- sound/usb/mixer.c | 64 ++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 71 insertions(+), 6 deletions(-) diff --git a/include/uapi/linux/usb/audio.h b/include/uapi/linux/usb/audio.h index 3a78e7145689..f9be472cd025 100644 --- a/include/uapi/linux/usb/audio.h +++ b/include/uapi/linux/usb/audio.h @@ -285,9 +285,16 @@ static inline __u8 uac_mixer_unit_iChannelNames(struct uac_mixer_unit_descriptor static inline __u8 *uac_mixer_unit_bmControls(struct uac_mixer_unit_descriptor *desc, int protocol) { - return (protocol == UAC_VERSION_1) ? - &desc->baSourceID[desc->bNrInPins + 4] : - &desc->baSourceID[desc->bNrInPins + 6]; + switch (protocol) { + case UAC_VERSION_1: + return &desc->baSourceID[desc->bNrInPins + 4]; + case UAC_VERSION_2: + return &desc->baSourceID[desc->bNrInPins + 6]; + case UAC_VERSION_3: + return &desc->baSourceID[desc->bNrInPins + 2]; + default: + return NULL; + } } static inline __u8 uac_mixer_unit_iMixer(struct uac_mixer_unit_descriptor *desc) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index 301ad61ed426..738ca37e6d6e 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -719,6 +719,35 @@ static int get_term_name(struct mixer_build *state, struct usb_audio_term *iterm } /* + * Get logical cluster information for UAC3 devices. + */ +static int get_cluster_channels_v3(struct mixer_build *state, unsigned int cluster_id) +{ + struct uac3_cluster_header_descriptor c_header; + int err; + + err = snd_usb_ctl_msg(state->chip->dev, + usb_rcvctrlpipe(state->chip->dev, 0), + UAC3_CS_REQ_HIGH_CAPABILITY_DESCRIPTOR, + USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN, + cluster_id, + snd_usb_ctrl_intf(state->chip), + &c_header, sizeof(c_header)); + if (err < 0) + goto error; + else if (err != sizeof(c_header)) { + err = -EIO; + goto error; + } + + return c_header.bNrChannels; + +error: + usb_audio_err(state->chip, "cannot request logical cluster ID: %d (err: %d)\n", cluster_id, err); + return err; +} + +/* * parse the source unit recursively until it reaches to a terminal * or a branched unit. */ @@ -865,6 +894,19 @@ static int check_input_term(struct mixer_build *state, int id, term->name = le16_to_cpu(d->wClockSourceStr); return 0; } + case UAC3_MIXER_UNIT: { + struct uac_mixer_unit_descriptor *d = p1; + unsigned int cluster_id = le16_to_cpu(d->baSourceID[d->bNrInPins]); + + err = get_cluster_channels_v3(state, cluster_id); + if (err < 0) + return err; + + term->channels = err; + term->type = d->bDescriptorSubtype << 16; /* virtual type */ + + return 0; + } default: return -ENODEV; } @@ -1801,7 +1843,7 @@ static void build_mixer_unit_ctl(struct mixer_build *state, struct usb_audio_term *iterm) { struct usb_mixer_elem_info *cval; - unsigned int num_outs = uac_mixer_unit_bNrChannels(desc); + unsigned int num_outs; unsigned int i, len; struct snd_kcontrol *kctl; const struct usbmix_name_map *map; @@ -1814,6 +1856,14 @@ static void build_mixer_unit_ctl(struct mixer_build *state, if (!cval) return; + if (state->mixer->protocol == UAC_VERSION_3) { + num_outs = get_cluster_channels_v3(state, + le16_to_cpu(desc->baSourceID[desc->bNrInPins])); + if (num_outs < 0) + return; + } else /* UAC_VERSION_1/2 */ + num_outs = uac_mixer_unit_bNrChannels(desc); + snd_usb_mixer_elem_init_std(&cval->head, state->mixer, unitid); cval->control = in_ch + 1; /* based on 1 */ cval->val_type = USB_MIXER_S16; @@ -1878,8 +1928,16 @@ static int parse_audio_mixer_unit(struct mixer_build *state, int unitid, int input_pins, num_ins, num_outs; int pin, ich, err; - if (desc->bLength < 11 || !(input_pins = desc->bNrInPins) || - !(num_outs = uac_mixer_unit_bNrChannels(desc))) { + if (state->mixer->protocol == UAC_VERSION_3) { + err = get_cluster_channels_v3(state, + le16_to_cpu(desc->baSourceID[desc->bNrInPins])); + if (err < 0) + return err; + num_outs = err; + } else /* UAC_VERSION_1/2 */ + num_outs = uac_mixer_unit_bNrChannels(desc); + + if (desc->bLength < 11 || !(input_pins = desc->bNrInPins) || !num_outs) { usb_audio_err(state->chip, "invalid MIXER UNIT descriptor %d\n", unitid); -- 2.11.0