Received: by 10.192.165.148 with SMTP id m20csp554340imm; Fri, 20 Apr 2018 11:05:51 -0700 (PDT) X-Google-Smtp-Source: AIpwx48DXqlL5hhi87ZziJb+qzknf+oXm7E+KvIU0o3lLoFyLf1cn76qW+oQU9zd+0rA2nczQoM/ X-Received: by 2002:a17:902:e8:: with SMTP id a95-v6mr11124341pla.274.1524247551468; Fri, 20 Apr 2018 11:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524247551; cv=none; d=google.com; s=arc-20160816; b=d+OLfGTkVsI92R5cV8ZIXk7PouIkMQWVF2ayaYhTv5v3o5m2YSwEm65gPnUqi3EF7T GREAbK/H+1uJvblV8GPO8EMqEFjZ7w1LuEIg/z00q7WTYxQYCVL3s0GVvCB/3inl9YYz oVYVFAUSDmBY7WTC0zckHhmZHdnTkBpJ/G/brEC2G9KCMoDlPJP1cJrgXTUYCGts2QQe mVb6BINnPHgsIPL0UxeQu8c45StKoI6YQcAkXG6sHaeZZGOAAEdI/NqvvKx3PAlaEtXH 97U9XcUIy08z945gPmMfsJ5Jy6ZVzCsZ60aSXov7NPjWnzS+VLHOBCib+bdEmaJd5zkS CeUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=MLuO98QZznfIjZQDkAzGcivgoHMB1a7ofR6EJMLkRIc=; b=t6vYiqS2OFuVdNFYkcaKQPwTx5S4HuyWgnYHxBdtoAeORn7QPfdZP+OYRSSLEHsECY /JjpgWvy1aMxiLD7ZPhlMXaOtqbKcBaCWlNDv7+ynPX3NQe5xw6uc/2FzjZn2R3rZJLd 4yfYUTlZMklLPpiPxzwOYfuCExIMFg1PIIQecrpo5G0VGx5JWahbxLNg5E5D7A1KPZ3x ZcAeuVrVtLaf1rBvCUwgskV5I/0/fn7SgIfEbAyXBKMJg3bhdLNHXptc4AXAWEz5ElaA +wiB8va6cg2LQdmpRq6HGJBTIpoNzcStEm/WRpihZehtzAyVx0XD3QW1Kh71fD7dBXq9 4A7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oNdfy54k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7-v6si6335213plt.358.2018.04.20.11.05.14; Fri, 20 Apr 2018 11:05:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oNdfy54k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753583AbeDTSCW (ORCPT + 99 others); Fri, 20 Apr 2018 14:02:22 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:36108 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbeDTSCU (ORCPT ); Fri, 20 Apr 2018 14:02:20 -0400 Received: by mail-lf0-f50.google.com with SMTP id d20-v6so6343819lfe.3; Fri, 20 Apr 2018 11:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MLuO98QZznfIjZQDkAzGcivgoHMB1a7ofR6EJMLkRIc=; b=oNdfy54kgCOzBL2vTsKaXJgUBdaPIV+/kHoIJkxv7RvhmdcZ9Tok6MZwW9Ao5cwWo4 iAZXcHwaugicqqezYResAUa8jLKOaFbdJVYSi9bfSh/P0RXBvhMZgXXE2XJxYxrndMAk pCFGKp3WZco4LLupL9BZHjQKGNOUhLajuCIaOND0FUsPtk3FQrXc83b1amTeQ/xxuJJn +InjFIJ5LWo7PkRxPnaJfiV1h98K9NZeko5bkmPS1MhIiPtfWLIiON/f+TOQP9h5+pte Z72dKYT7vHfn886x+6/NHKrFQVE4yXKzIlyVMAD101ksRoogRsOQ/dmLcoWII4qz8bqg q7sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MLuO98QZznfIjZQDkAzGcivgoHMB1a7ofR6EJMLkRIc=; b=DkDbRyvxUlrDfihCzuCod5g9GM0rztt04cFk2OuRjiv6RsHWLE4QITHWJl3koFLatd aKdZUZ00GjE0kzmX6FvQnIoLi2rN3UYq08vRbqMFTa7QfTmyNxOlBWqDL/FDElIScHFO ncEk81JGoClRp/fpDoVWkAJVjNluyVKZEdn/b4RatUG32fPbqp4zpP3n4kZ7uhRlN5xc S9cdGCoWPv4mScF25NcMalxtV3QyzHF/GhzCiayWCBSMP79FxyqhdsTSY0tIhJVBuQAO JeQ9saNjI7xYX2GuKGNSlQ5aJ5hgfaJRGOBynU2v4OYdKEjuseNA/XXdm7UX9Wk12+fz 2BFA== X-Gm-Message-State: ALQs6tAL0BrNyAEpdb4CwPBp4Vq6lwxGFmka2J4CPf+ocK86anVwr0Bi 5We1HfGZ8cRwasO6yYXatHgZXZrzqwtBzVwx0A== X-Received: by 10.46.67.148 with SMTP id z20mr7976656lje.103.1524247338433; Fri, 20 Apr 2018 11:02:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:d203:0:0:0:0:0 with HTTP; Fri, 20 Apr 2018 11:02:17 -0700 (PDT) In-Reply-To: References: <20180420131919.GA1766@embeddedor.com> From: Pavel Shilovsky Date: Fri, 20 Apr 2018 11:02:17 -0700 Message-ID: Subject: Re: [PATCH] cifs: dir: fix memory leak in cifs_mknod To: Steve French Cc: "Gustavo A. R. Silva" , Colin King , Ronnie Sahlberg , Steve French , CIFS , samba-technical , LKML , kernel-janitors Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-04-20 10:37 GMT-07:00 Steve French : > I noticed a similar problem with the tcon link leak on that (which > Colin and Gustavo pointed out - thank you!) but also in another return > statement, so updated the original patch of Ronnie's merging the fixes > > https://git.samba.org/sfrench/cifs-2.6.git/?p=sfrench/cifs-2.6.git;a=commit;h=167bc5de08dc97695f9d5c7069c3e69f409ff80b > > > Let me know if you see any problems with it. > Looks good. Reviewed-by: Pavel Shilovsky -- Best regards, Pavel Shilovsky