Received: by 10.192.165.148 with SMTP id m20csp668439imm; Fri, 20 Apr 2018 13:18:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx4995iQ/+Lhd2c4KXmuH6UpoHi0rcNW8VeeJIcfaJR6iuATyHuQRqQ/lWg9VTya4yCUHKfR/ X-Received: by 10.98.174.5 with SMTP id q5mr10884265pff.155.1524255487648; Fri, 20 Apr 2018 13:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524255487; cv=none; d=google.com; s=arc-20160816; b=JnbTbK+FqmFJuDbqMpfHftFLWAM1ao9l6lN9Hz5FodmrqWWsc1FJGOjP4hTkf5icnB QpzLSRifxltoe+4NSJ9LPf+fH8TB9R3PROsdK6dus/ygYLRcubsAPraecdcrNn0VddNG MfMKDfmjuhf6LcmXsLC9I9NxjQkDyY6r8K81P5xrQNo7DVn7o5asywuhdK+kGX9E2/xQ 5q6dCRjHniMh3mQ9V2Eq+cHTOpJUnOFbNI1mJv0k1v32PfznTtX1igd/s8LIXS/YHCyC Gjn2IRNWWTEiIShss/HZdYQIheNipUYlsi4zRClTtRUE4Ih+QOpR0N4NDzT7Y1t/+teO bKog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:arc-authentication-results; bh=c34++9xN/va1ZFCcWvTxI4EjoyFjgqFjnw41R+gd3TY=; b=IcBi690KU/bflf9IiCQZ7wepIyarcKK8JqVonoSbj5aBdeXaAwemwB24ViG8eLY2Ti Ntygk8ZZKx62o5H+1EBvlNiaxk4u1SmbvymMXW8zN0t6cZ1l5f5EYX95QslyUpAotPYV uM69HKKBzHaGkv/QUjnLiYWZ9yzIqSd7o14XSr1YKWpCZqfGGNYk0E8CD9h1iRykkUMb tDPkX0fOKlRyp/1zRL3HXgV3I9OWucnFO/Q+qicYlqT5C9CfwWmKuMuMAo4TvkK6rmQA X9jgmss4G7hRfvYCtXgVNoxtHWcy+wa7aTl8hpaNbd97MYyQ0u1Ja9jl1PHm+TdM7pia 5q/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y73si5374710pgd.390.2018.04.20.13.17.30; Fri, 20 Apr 2018 13:18:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbeDTUNp (ORCPT + 99 others); Fri, 20 Apr 2018 16:13:45 -0400 Received: from www62.your-server.de ([213.133.104.62]:56300 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbeDTUNo (ORCPT ); Fri, 20 Apr 2018 16:13:44 -0400 Received: from [62.202.221.10] (helo=linux.home) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256) (Exim 4.85_2) (envelope-from ) id 1f9cPe-0005kF-2e; Fri, 20 Apr 2018 22:13:42 +0200 Subject: Re: [PATCH net] bpf: sockmap remove dead check To: Jann Horn , ast@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john.fastabend@gmail.com References: <20180420161630.233178-1-jannh@google.com> From: Daniel Borkmann Message-ID: <0cbbddea-adb7-71ab-fc3a-167896aeda61@iogearbox.net> Date: Fri, 20 Apr 2018 22:13:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180420161630.233178-1-jannh@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.99.3/24497/Fri Apr 20 14:25:28 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2018 06:16 PM, Jann Horn wrote: > Remove dead code that bails on `attr->value_size > KMALLOC_MAX_SIZE` - the > previous check already bails on `attr->value_size != 4`. > > Signed-off-by: Jann Horn Applied to bpf tree, thanks Jann!