Received: by 10.192.165.148 with SMTP id m20csp777184imm; Fri, 20 Apr 2018 15:52:11 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/VCHsFpbEKi9SPSX11Xg4i7EM3LhnyjAp+kYWhNJZ8NUZjQlJRST3ea12iFAM4W90iqlID X-Received: by 10.99.126.92 with SMTP id o28mr9632030pgn.194.1524264731191; Fri, 20 Apr 2018 15:52:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524264731; cv=none; d=google.com; s=arc-20160816; b=ikIFkSl4ATHTz5T+l8XBW+70L65E1hVsmACvu6XotcmX0pNNGRmdaMsTbQSUy0a7A0 zNI9bkh/qxK2neM++F87KrKCOsO+5YZuJ4Uut+qmhNYam/Xrk+KAw3STSTI42Vktk5Vp /xHU6ijYsxb+eTOYpNO69RlQTZ6HUi4EGQYMpTSv3zhX3v8XRqfk92RGx7h0CnjfB5/5 IQCjhh5hHcu8HMd+IqMpAFprYchHE5H8pXxSDBv54iFuv+E87a6PtwEKQboc94YZKUgr pe/+AIT6+uSwqpT+u7CTAugyKeL2jZcKYNP6uZAOXAlMu03TZRc9quSpF5LIs7yDX/AR oXDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=+h1qjgfg9GYXZ+p0D3w68emDO6uaZBe4u9Zzb+sz/OA=; b=dLkCfzxfr4glKAVNiCC0qHwZOjmCEFcleUPS/ndb/NLND3HCxjkChFNT4JkAlfLx7d IaBZ2rUM1Adb4buwhNHsfP7jzI8HcLac+6cyikKbzgwss+iNR7NOy7YTrvgoW2jG0VuG ahXkL31/XxDW+YXQulGRXwYYwRa/bmRdncLAojD2G9dtBkZXjASfE3aMQGNy+ed0g4fE b7q6oItCdLoz2gdyCXdJ8x9o3gE+Xus1wUN3lGlzcbDrrq1pvQRA5caCIdGlnPIm4JY7 GhJQmSH1UFCCMTcKEH7LmcX3JgLArcRETgbs58G2dEyKNd9KRyTGcQFqqHsYbcJYQYKa JBfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pfq6cXCc; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pfq6cXCc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f12si1678405pgp.298.2018.04.20.15.51.34; Fri, 20 Apr 2018 15:52:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pfq6cXCc; dkim=pass header.i=@codeaurora.org header.s=default header.b=Pfq6cXCc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679AbeDTWot (ORCPT + 99 others); Fri, 20 Apr 2018 18:44:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45250 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752192AbeDTWor (ORCPT ); Fri, 20 Apr 2018 18:44:47 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id ED5A56071A; Fri, 20 Apr 2018 22:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524264286; bh=IdblVLbNwURhT9175mXCS+RIQjlmQn6ZHigNhTyWqxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pfq6cXCcWS80iRnXpEOxrDUW4V8XsZcOOsFK05S5ShDw9+YlTt/pCH3gKAhekcr2k WufVqgQ+uALaJf0HLG/4X+mF8n6MKropdulV9CxyvjZQgNW8s8jkcD0c/Gsg3eQVgs XutzdetBahaUZfR/nTq+76uQ8S0S/ibvNjv5NGgg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 05DE560310; Fri, 20 Apr 2018 22:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524264286; bh=IdblVLbNwURhT9175mXCS+RIQjlmQn6ZHigNhTyWqxk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pfq6cXCcWS80iRnXpEOxrDUW4V8XsZcOOsFK05S5ShDw9+YlTt/pCH3gKAhekcr2k WufVqgQ+uALaJf0HLG/4X+mF8n6MKropdulV9CxyvjZQgNW8s8jkcD0c/Gsg3eQVgs XutzdetBahaUZfR/nTq+76uQ8S0S/ibvNjv5NGgg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 05DE560310 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Fri, 20 Apr 2018 16:44:45 -0600 From: Lina Iyer To: David Collins Cc: Stephen Boyd , broonie@kernel.org, lgirdwood@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180420224445.GB18235@codeaurora.org> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <152165924074.91116.13025068669916027026@swboyd.mtv.corp.google.com> <493c1f5d-df99-ca68-0f90-a7937a696f5d@codeaurora.org> <152411734938.46528.9676451637772936597@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20 2018 at 13:07 -0600, David Collins wrote: >On 04/18/2018 10:55 PM, Stephen Boyd wrote: >> Quoting David Collins (2018-03-22 18:30:06) >>> On 03/21/2018 12:07 PM, Stephen Boyd wrote: >>>> Quoting David Collins (2018-03-16 18:09:10) >>>>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig >>>>> index 097f617..e0ecd0a 100644 >>>>> + ret = cmd_db_ready(); >>>>> + if (ret < 0) { >>>>> + if (ret != -EPROBE_DEFER) >>>>> + dev_err(dev, "Command DB not available, ret=%d\n", ret); >>>>> + return ret; >>>>> + } >>>> >>>> We should just make rpmh parent device call cmd_db_ready() so that these >>>> devices aren't even populated until then and so that cmd_db_ready() is >>>> only in one place. Lina? >>> >>> Let's see if Lina has qualms about this plan. >> >> Sounds like you're ok with it. > >Sure, I'll remove this check if Lina agrees to add it in the rpmh driver. > We want to make the RSC nodes child of Command DB? That way we probe the controllers only if the command DB is ready? I could do that. Just so you know, there is are no strict directives to use Command DB. If a driver knows the information it needs to pass to the accelerator, it may choose to skip command DB completely. Thanks, Lina