Received: by 10.192.165.148 with SMTP id m20csp1146410imm; Sat, 21 Apr 2018 02:08:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/OxjJZ0LYR6IbGzf48m30MSUxLETsP9dtVZr5Nq3h1C5+urZaim2QbYEsCiNvet7PCmZvC X-Received: by 10.99.124.20 with SMTP id x20mr10960986pgc.161.1524301691980; Sat, 21 Apr 2018 02:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524301691; cv=none; d=google.com; s=arc-20160816; b=iwL67Qga+Xq9rqKq8ZDj2k12WNRNxsplTd7qKfVKuq7JXFUJrHLeIpPjGFDbzuODQm sWSSDo1xEE3pGkV405GWGXf3PVcdfG7vpVXngEhZHMk1S+J+DGsCKi7FUsyDyUDRfYZ4 IotcTavHuA8afNJZVoMYBiYH1BCbq0UzDGceq+01CKsl/GhyZhJhDdr+9w9VzhJTsbZ6 fzNj0k/iSaEYmdcKYWyZ68f0xX44ROfZLCQ9X2bPbVus+J38IUxkeAbZEmEraxx5G+su 9KjgC/lM7a0Ty96xJ3mr24LmHLZ04AZYeNwFT6G49xEoZkto56BL7lmCRNAISQ9Wkrt3 02fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=396LWGKB696kIEPXJql7j+31p+mdD7d5g4ODkcJ4Xyk=; b=YXzCt9yb8Ye9LEfFWE1W9M5bxO+8SvsmZdCFYFNffFLCU+uueOTekLr3j+MQwUjg2O syCWtGTgue0SX5sBV7GIfrX/A82gfbMLIsSALwVlU378+PdiO2wq0zwQ/+0jH2STFFYS RfQNPRPyQox7phDpJTQrg//zNaOAs9tmKbBt/2IzkwcBoH5+XqkUxxWpvB17oUuhzLUB SkS2Tk1bQ1KKShvYk+Pw4fRM1rD9VI7GqZWBLlcabUXu9rxCAQe9hWCEDyB9buGE5p+2 0DSuZxXW2QoWosciy0w6GGaEhw8q/6CA6/rx5ScslhldLHFzT4mdXStOn/HPE3o3HkWP pBnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2-v6si8026155plz.226.2018.04.21.02.07.34; Sat, 21 Apr 2018 02:08:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbeDUJE5 (ORCPT + 99 others); Sat, 21 Apr 2018 05:04:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42374 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbeDUJE4 (ORCPT ); Sat, 21 Apr 2018 05:04:56 -0400 Received: from localhost (ip-213-127-148-58.ip.prioritytelecom.net [213.127.148.58]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4FE5DDD9; Sat, 21 Apr 2018 09:04:55 +0000 (UTC) Date: Sat, 21 Apr 2018 11:04:49 +0200 From: Greg KH To: Tom Hromatka Cc: davem@davemloft.net, sparclinux@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, allen.pais@oracle.com, khalid.aziz@oracle.com, shannon.nelson@oracle.com, anthony.yznaga@oracle.com Subject: Re: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver Message-ID: <20180421090449.GA8194@kroah.com> References: <20180420205221.488589-1-tom.hromatka@oracle.com> <20180420205221.488589-2-tom.hromatka@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180420205221.488589-2-tom.hromatka@oracle.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20, 2018 at 02:52:20PM -0600, Tom Hromatka wrote: > --- /dev/null > +++ b/drivers/char/adi.c > @@ -0,0 +1,240 @@ > +// SPDX-License-Identifier: GPL-2.0 Good, but: > +MODULE_LICENSE("GPL"); That's the wrong line :( Read include/linux/module.h for the correct string to put here for a GPL version 2 only module. thanks, greg k-h