Received: by 10.192.165.148 with SMTP id m20csp2473986imm; Sun, 22 Apr 2018 07:47:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx49IpBMPBkbZ1zW4PnZPK/Xt46aC6jEk1TNHpaSySC1bfWaYgJ5xirLOKiiDmgGeghkvxfkC X-Received: by 10.99.112.70 with SMTP id a6mr14249877pgn.294.1524408464443; Sun, 22 Apr 2018 07:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524408464; cv=none; d=google.com; s=arc-20160816; b=z4WcTFl/sFYjYF/ld3mqlBLAoMDwcw9PijJRJFKtDJfwgNkZT9afPbWrXtRN6dwV+4 LOE6PcqlH6o4qmULXMeAhppUQoYU4SHj3oDHKlggtmC1do0SkyGYUDbMT1s6qMuHfsGc DPkb/vhVZ8mAWO/vEuKOLdE9hA2yJ3N3JnC0JByxBAMgVJCpmqkTcGuwHJ0grY9dORGl /bVi1mOwacpJtkQwL/bB1YVWNNZWLybDwBSb7ALQKKWsYFDBXUR+/Ig5JG5W23VAa26n gmfBBHUcq/Po6AK7LZpMqdHYK+nHDJv8GCZx8yC1TXLB/qU9X7ibuY+2EdqqTu08O0W9 HumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=4GsVPi3Vm9NY8AX6aR5z9FOx3fKfsS7C7bBkLDRZxHI=; b=ouSP8RARoNKUooCouy2OYklSFnXawNtNw9+hEXpU2SOT89PScyk61YTfktX9l2lCqx fLtXQ1W38+tz5gyTjND372XwQkvojBes0NAu3npgzYabpm/5ANXvFHmozJ09fQHIrVYv KSAEoSFGAlnw4B9temBPmAPhJ1GJ4HaimqGHo+pVcqTvlyUPnuaqISc9TH/SW7lThnoJ uQluchAvh6wPg+ulMTPo/+/iiOgSbVelwYlpNSMLMXtnO19lWBGfv5pO2URqOT49lCDE ya+o5W+oPWaKJioArP/C+m5M7T57v1mpxlonD01XdfZ1GkWLUXwKsYMPO2Yn3jce+Jjs M1BA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si8079002pgo.85.2018.04.22.07.47.29; Sun, 22 Apr 2018 07:47:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932354AbeDVOQw (ORCPT + 99 others); Sun, 22 Apr 2018 10:16:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57704 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbeDVOQr (ORCPT ); Sun, 22 Apr 2018 10:16:47 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CD89E4A5; Sun, 22 Apr 2018 14:16:46 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavlos Parissis , Lei Chen , Maxime Hadjinlian , Namhyung Kim , Adrian Hunter , Jiri Olsa , David Ahern , Peter Zijlstra , Wang Nan , kernel-team@lge.com, Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.4 08/97] Revert "perf tests: Decompress kernel module before objdump" Date: Sun, 22 Apr 2018 15:52:46 +0200 Message-Id: <20180422135305.110944943@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135304.577223025@linuxfoundation.org> References: <20180422135304.577223025@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman This reverts commit b0761b57e0bf11ada4c45e68f4cba1370363d90d which is commit 94df1040b1e6aacd8dec0ba3c61d7e77cd695f26 upstream. It breaks the build of perf on 4.4.y, so I'm dropping it. Reported-by: Pavlos Parissis Reported-by: Lei Chen Reported-by: Maxime Hadjinlian Cc: Namhyung Kim Cc: Adrian Hunter Cc: Jiri Olsa Cc: David Ahern Cc: Peter Zijlstra Cc: Wang Nan Cc: kernel-team@lge.com Cc: Arnaldo Carvalho de Melo Cc: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- tools/perf/tests/code-reading.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) --- a/tools/perf/tests/code-reading.c +++ b/tools/perf/tests/code-reading.c @@ -182,8 +182,6 @@ static int read_object_code(u64 addr, si unsigned char buf2[BUFSZ]; size_t ret_len; u64 objdump_addr; - const char *objdump_name; - char decomp_name[KMOD_DECOMP_LEN]; int ret; pr_debug("Reading object code for memory address: %#"PRIx64"\n", addr); @@ -244,25 +242,9 @@ static int read_object_code(u64 addr, si state->done[state->done_cnt++] = al.map->start; } - objdump_name = al.map->dso->long_name; - if (dso__needs_decompress(al.map->dso)) { - if (dso__decompress_kmodule_path(al.map->dso, objdump_name, - decomp_name, - sizeof(decomp_name)) < 0) { - pr_debug("decompression failed\n"); - return -1; - } - - objdump_name = decomp_name; - } - /* Read the object code using objdump */ objdump_addr = map__rip_2objdump(al.map, al.addr); - ret = read_via_objdump(objdump_name, objdump_addr, buf2, len); - - if (dso__needs_decompress(al.map->dso)) - unlink(objdump_name); - + ret = read_via_objdump(al.map->dso->long_name, objdump_addr, buf2, len); if (ret > 0) { /* * The kernel maps are inaccurate - assume objdump is right in