Received: by 10.192.165.148 with SMTP id m20csp2495649imm; Sun, 22 Apr 2018 08:12:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+pFATZ9RImSFMSzmw45wWj/ofPdiy4fvE2OZCRAdll8ynTvgodXU4k7RV6xxyIW57a6Lxq X-Received: by 10.99.126.92 with SMTP id o28mr14160641pgn.194.1524409940072; Sun, 22 Apr 2018 08:12:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524409940; cv=none; d=google.com; s=arc-20160816; b=h2kxTeDD7feJDkRuyjSIof5YC6N3GKjUayz9Qx+Xced1+iyIgPPsZZeLzQQclAUxEo 2kFFgEdKq0cHpNyLbImRIqEeOnLtwUdUe9fY/k6jnblWNnVf1Vn+g/I3mnzHFuZFXkFA IuY/Rp/MeU6Yup6JIberR2QP3U5DgXBaCE5wmxRTLhXy2kr5OyjJ/ogsGGVM3o3QTPVl jD8Y5ZrsjlXLQm6oUqx8D0pd5BvxsNaScwB37pJi5GKg0WVSX+6GtTwpRe2TO4Z7TSBa cTCVal++2EhhEdjT/1bK9pekHjXrEeagerV80pFJD785O2I/+L3OeP48gCwRzKviFbrX KIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=crmXjCUU92bGss1jXrV+4J6TxQNaEhFGI5QsVa1Uczo=; b=hOclABGcRrYMRcZbAxlq45y8K7uEqem35AMWNlm6QzCS7mpeOvJ6pUQQm7tfP+Qyi6 Uw32TA+cq9a2RZMY2+PLK+ZiE01fJyYrVHZec2DpgRERNrhY+0Q7CoCQi07wLKumklXG WzNnqMy0BC73aaFL+vrygE3wnwCCkCh+F0cRXrBaHJfa5bxHCLNJyeOhSF7ONcSNPoRF eweJ+ai3W/Am27yhawqphG1C58ergiBrhV/D4h6KF+4pVyLlRkIiBk73mzbYWwhVfedj VU3MkPSrHdKy4VYwZFQrDM8X59enESIazNSGzFbeGLyWIedWWxksD/hQGddkzj9uFMij CoCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u36si2611775pgn.213.2018.04.22.08.12.06; Sun, 22 Apr 2018 08:12:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756393AbeDVPKz (ORCPT + 99 others); Sun, 22 Apr 2018 11:10:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50884 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756312AbeDVPKu (ORCPT ); Sun, 22 Apr 2018 11:10:50 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3MF9gKv031689 for ; Sun, 22 Apr 2018 11:10:50 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hgk2keytb-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Sun, 22 Apr 2018 11:10:50 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 22 Apr 2018 11:10:48 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 22 Apr 2018 11:10:46 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3MFAkjp50200814; Sun, 22 Apr 2018 15:10:46 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D4249AE043; Sun, 22 Apr 2018 11:12:35 -0400 (EDT) Received: from oc8043147753.ibm.com (unknown [9.85.166.77]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 21FF5AE03B; Sun, 22 Apr 2018 11:12:35 -0400 (EDT) Subject: Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus To: Janosch Frank , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: borntraeger@de.ibm.com, cohuck@redhat.com, pmorel@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, pbonzini@redhat.com, rkrcmar@redhat.com References: <1524172432-26211-1-git-send-email-akrowiak@linux.vnet.ibm.com> <870459b4-228d-0be3-5dd3-48ab480b46de@linux.ibm.com> From: Tony Krowiak Date: Sun, 22 Apr 2018 11:10:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18042215-0056-0000-0000-000004432C1F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008900; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000257; SDB=6.01021661; UDB=6.00521400; IPR=6.00800896; MB=3.00020714; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-22 15:10:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18042215-0057-0000-0000-0000088734F2 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-22_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804220172 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2018 08:15 AM, Janosch Frank wrote: > On 20.04.2018 13:59, Janosch Frank wrote: >> Thanks, applied. >> > Well this does not compile, as you use kvm_s390_vcpu_crypto_setup before > declaration. Please fix, then I'll take the patch. Stupid mistake. I'll fix it. > > >> On 19.04.2018 23:13, Tony Krowiak wrote: >>> Introduces a new function to reset the crypto attributes for all >>> vcpus whether they are running or not. Each vcpu in KVM will >>> be removed from SIE prior to resetting the crypto attributes in its >>> SIE state description. After all vcpus have had their crypto attributes >>> reset the vcpus will be restored to SIE. >>> >>> This function is incorporated into the kvm_s390_vm_set_crypto(kvm) >>> function to fix a reported issue whereby the crypto key wrapping >>> attributes could potentially get out of synch for running vcpus. >>> >>> Reported-by: Halil Pasic >>> Signed-off-by: Tony Krowiak >>> --- >>> arch/s390/kvm/kvm-s390.c | 18 ++++++++++++++---- >>> arch/s390/kvm/kvm-s390.h | 13 +++++++++++++ >>> 2 files changed, 27 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >>> index fa355a6..4fa3037 100644 >>> --- a/arch/s390/kvm/kvm-s390.c >>> +++ b/arch/s390/kvm/kvm-s390.c >>> @@ -789,6 +789,19 @@ static int kvm_s390_set_mem_control(struct kvm *kvm, struct kvm_device_attr *att >>> return ret; >>> } >>> >>> +void kvm_s390_vcpu_crypto_reset_all(struct kvm *kvm) >>> + { >>> + int i; >>> + struct kvm_vcpu *vcpu; >>> + >>> + kvm_s390_vcpu_block_all(kvm); >>> + >>> + kvm_for_each_vcpu(i, vcpu, kvm) >>> + kvm_s390_vcpu_crypto_setup(vcpu); >>> + >>> + kvm_s390_vcpu_unblock_all(kvm); >>> +} >>> + >>> static void kvm_s390_vcpu_crypto_setup(struct kvm_vcpu *vcpu); >>> >>> static int kvm_s390_vm_set_crypto(struct kvm *kvm, struct kvm_device_attr *attr) >>> @@ -832,10 +845,7 @@ static int kvm_s390_vm_set_crypto(struct kvm *kvm, struct kvm_device_attr *attr) >>> return -ENXIO; >>> } >>> >>> - kvm_for_each_vcpu(i, vcpu, kvm) { >>> - kvm_s390_vcpu_crypto_setup(vcpu); >>> - exit_sie(vcpu); >>> - } >>> + kvm_s390_vcpu_crypto_reset_all(kvm); >>> mutex_unlock(&kvm->lock); >>> return 0; >>> } >>> diff --git a/arch/s390/kvm/kvm-s390.h b/arch/s390/kvm/kvm-s390.h >>> index 1b5621f..981e3ba 100644 >>> --- a/arch/s390/kvm/kvm-s390.h >>> +++ b/arch/s390/kvm/kvm-s390.h >>> @@ -410,4 +410,17 @@ static inline int kvm_s390_use_sca_entries(void) >>> } >>> void kvm_s390_reinject_machine_check(struct kvm_vcpu *vcpu, >>> struct mcck_volatile_info *mcck_info); >>> + >>> +/** >>> + * kvm_s390_vcpu_crypto_reset_all >>> + * >>> + * Reset the crypto attributes for each vcpu. This can be done while the vcpus >>> + * are running as each vcpu will be removed from SIE before resetting the crypt >>> + * attributes and restored to SIE afterward. >>> + * >>> + * Note: The kvm->lock must be held while calling this function >>> + * >>> + * @kvm: the KVM guest >>> + */ >>> +void kvm_s390_vcpu_crypto_reset_all(struct kvm *kvm); >>> #endif >>> >> >