Received: by 10.192.165.148 with SMTP id m20csp2527603imm; Sun, 22 Apr 2018 08:54:55 -0700 (PDT) X-Google-Smtp-Source: AIpwx49t3z1L0V54zPO4q0kf10xsZ+Qz70p95Ew1RjFeRBG9Mgrg6Lthk0oqY/8XWhtqQloDHEJK X-Received: by 2002:a17:902:708a:: with SMTP id z10-v6mr18129982plk.315.1524412495168; Sun, 22 Apr 2018 08:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524412495; cv=none; d=google.com; s=arc-20160816; b=aUgCA7+XbqqqW5aUcKAuQNFl13NpY8CDt9CjUFKWprMjbCwufdDpmD60FtKFD/zxdT Eto5dHAjFFQkeO/B5uETATxWTcTGlVlUstnCoCOhBcJ0u/1hLDEovuHQxu8FtsYS33s7 dYH3tXYVHVHhT+opQpc6uQ3lCeDFnvAV3D0nYjy89R6JJzPv6zMZI+hbzwdM16DazaKG bwFbWPmyF02fIbA1sS9SIkyaxcQlQJeBJVh0r7X64ZU6SMAMxZJ7/PKmW70vjFoxlFWy rI+isVurgrFx4zAKa2AV7+i6+pOPoYlDIMd4wLMdwyJGwFqUfAneIW3/jEngtxUKbYF4 5ozQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=BMkFieyNa777VKULpukRcoJ+Qx4/HuimswJfjkW6kfA=; b=Sa2kkFTyBkZXMVvh5e9Uup87NqvcM/mbEMcgtEZOSAXTCtHBYSGkkLq5w4vi40G3iz VtbNe2nyYMP9Hg69I3YEFPYcx8MvNwMfaWh6duHS4iXiAAoD6pITZGFz8RMkm1VS9JCn S4DoSfJMMOqMHvHbuJobz8NTqWeHep8YQ2agh76PhvrDq0Ed+4/r1A1O18IyZzwcMD3L eJRWcMU2a+U9FUTaKDMAcDSCnVPtzq8xgVd6OG+hmBsjMsbVHXLAfkLrl7LOIi11/MGM 4tHtAr+Z8tD0vl0fQFS+j6+Qviceen1KuXSgGKnRx8XYxJARZ5YjJVdGm3PWyjQA9wGP jecA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69-v6si9350871plc.436.2018.04.22.08.54.41; Sun, 22 Apr 2018 08:54:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbeDVPxi (ORCPT + 99 others); Sun, 22 Apr 2018 11:53:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39332 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbeDVPxe (ORCPT ); Sun, 22 Apr 2018 11:53:34 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3MFmY8r138418 for ; Sun, 22 Apr 2018 11:53:34 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hgk2rqsrr-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Sun, 22 Apr 2018 11:53:33 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 22 Apr 2018 16:53:31 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 22 Apr 2018 16:53:22 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3MFrMjq4718974; Sun, 22 Apr 2018 15:53:22 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 973AC11C04C; Sun, 22 Apr 2018 16:45:11 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BD6C11C04A; Sun, 22 Apr 2018 16:45:10 +0100 (BST) Received: from oc3836556865.ibm.com (unknown [9.145.181.223]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 22 Apr 2018 16:45:10 +0100 (BST) Subject: Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus To: Tony Krowiak , David Hildenbrand , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: borntraeger@de.ibm.com, cohuck@redhat.com, pmorel@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, pbonzini@redhat.com, rkrcmar@redhat.com References: <1524172432-26211-1-git-send-email-akrowiak@linux.vnet.ibm.com> From: Halil Pasic Date: Sun, 22 Apr 2018 17:53:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18042215-0040-0000-0000-00000431B1A6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18042215-0041-0000-0000-00002635D393 Message-Id: <28eacee1-eafe-dc95-c008-61bc656b931c@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-22_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804220180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/22/2018 05:06 PM, Tony Krowiak wrote: > On 04/20/2018 08:26 AM, David Hildenbrand wrote: >> On 19.04.2018 23:13, Tony Krowiak wrote: >>> Introduces a new function to reset the crypto attributes for all >>> vcpus whether they are running or not. Each vcpu in KVM will >>> be removed from SIE prior to resetting the crypto attributes in its >>> SIE state description. After all vcpus have had their crypto attributes >>> reset the vcpus will be restored to SIE. >>> >>> This function is incorporated into the kvm_s390_vm_set_crypto(kvm) >>> function to fix a reported issue whereby the crypto key wrapping >>> attributes could potentially get out of synch for running vcpus. >>> >>> Reported-by: Halil Pasic >> A reported-by for a code refactoring is strange. > > I was asked to include this. Is this a refactoring or a fix? I the message you state that you are fixing an issue (aka bug). If you are not, fixing an issue, but indeed just refactoring, Suggested-by would be more appropriate. Regards, Halil