Received: by 10.192.165.148 with SMTP id m20csp2536661imm; Sun, 22 Apr 2018 09:05:10 -0700 (PDT) X-Google-Smtp-Source: AIpwx491buP+U931ZvgEREJxcv6ABw3Rv49M8dDtD318Ju3wQPrYXTA6BiJTdrKMw6QM73LbnaGJ X-Received: by 2002:a17:902:1c7:: with SMTP id b65-v6mr15589757plb.298.1524413110199; Sun, 22 Apr 2018 09:05:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524413110; cv=none; d=google.com; s=arc-20160816; b=nxhqWdZqYBGM0fIH4fq9HZHscCZRReaTMngqSsGFlQVDVpEqca/SjeJr6gUFdO1q00 DIP5l4Gld1opTph9leqlboDnZsxOHp/EYO8hKBAvxn+oQjRB00zwAuR62MrBbw/Qj/BE QfSJuKKOwgUW7ZvGqzg/M8/R5AIOJAWguIZ8IVwN+ZFJXUzDWmjjZ/kYlaQ3CHl9rTOV ppjACvg4+Nt6aau+fGP0ry8SmFR+JaihncB1NO/mDI3pXEY4/dSeq+CrDx8IwEYob7Kp TJW/3MJRZfYEjl8wkv///jQLtq7Onop9AXVTjMLAcXsPLZ+Phalot3/T3Cw07n3qH+uL mxaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=0qPIxFxMAB/cr3SeCdsxBH+bysnBboWJomLFIhARBHw=; b=fp75Eyq8jjCrU+XxS0UFyLvlvZHfOpUA0ldL4DEsTsCcI/gJliLf3/hrUiY30YerUo R+i5mj/kaAOKBc1sw9bgc1N+ffOUi2BAwohwDmLRG6idMkVs/Mj9nHVi2RTyPrg9iDAq X+tPDqAQkwngRUWiPjlhGr//Qji8UMAv4pXDmSlYPiA1WobdHhM8rJtspj1OhGA/y8Bl Hwt3aIWU3b/wxSXyvmpgKQZ5dsbyFlp+YsUR8A+R2pGw3JXHZJVNKOrg8LvQo4r5MtUd fqHIwP4aIxS4FACtQSIHYOf55uz5OkxhJ9Sca7lZJP/W1Eroimu+nQp1xeaufNZwGyu4 sIAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a61-v6si10102572pla.271.2018.04.22.09.04.55; Sun, 22 Apr 2018 09:05:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbeDVQDx (ORCPT + 99 others); Sun, 22 Apr 2018 12:03:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45930 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754032AbeDVN5u (ORCPT ); Sun, 22 Apr 2018 09:57:50 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 753D49CE; Sun, 22 Apr 2018 13:57:49 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mika Westerberg , Andy Shevchenko Subject: [PATCH 4.16 077/196] thunderbolt: Resume control channel after hibernation image is created Date: Sun, 22 Apr 2018 15:51:37 +0200 Message-Id: <20180422135108.224384580@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135104.278511750@linuxfoundation.org> References: <20180422135104.278511750@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mika Westerberg commit f2a659f7d8d5da803836583aa16df06bdf324252 upstream. The driver misses implementation of PM hook that undoes what ->freeze_noirq() does after the hibernation image is created. This means the control channel is not resumed properly and the Thunderbolt bus becomes useless in later stages of hibernation (when the image is stored or if the operation fails). Fix this by pointing ->thaw_noirq to driver nhi_resume_noirq(). This makes sure the control channel is resumed properly. Fixes: 23dd5bb49d98 ("thunderbolt: Add suspend/hibernate support") Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/nhi.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -1064,6 +1064,7 @@ static const struct dev_pm_ops nhi_pm_op * we just disable hotplug, the * pci-tunnels stay alive. */ + .thaw_noirq = nhi_resume_noirq, .restore_noirq = nhi_resume_noirq, .suspend = nhi_suspend, .freeze = nhi_suspend,