Received: by 10.192.165.148 with SMTP id m20csp2545836imm; Sun, 22 Apr 2018 09:16:25 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+G3HuHWS05Xo7U+vdfVfVHh/3IEWoJN8gYKghpoWkJHdiOobOUb+UJCorqYmbZ8jzSFTfO X-Received: by 10.101.100.203 with SMTP id t11mr14818879pgv.417.1524413785008; Sun, 22 Apr 2018 09:16:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524413784; cv=none; d=google.com; s=arc-20160816; b=C8b0C14hTdUNAxyem5nBOH67660x0K9M1ORokittoRQTFhGHDQ9PQSqUQ1J/MzvyYM nOUR6rK9PTWMtw1WWFIySCYrEPzEYSxk0tvMieIUOvZNid7kD7KREmv9pL8UECNRF5pq tbAlVgrCFVTnbPta5A4HxL4qrSAvm4X5MvkH2GONXsND7cBtlE8N9oWoOD00Yt8tQ1ph l96NEveuk26V48OwM9qAeRsaHtzddPe+K9jp3rJyC3iL2yuP4sHFkRclLfT1RRYYcu/n 41byqGiU1P/H7wtxmJBftGKkk+HRhO/dZlDS3iLikgvicahh52f6SY3Y8YNKUNpfnWwD ZQHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=CnHSD0zYetGk6lnbZQnDBgQC9rEnOKayUYxan4TDHoQ=; b=bDdmgMYt7r3bNgtT0YwCd606iBemTkvHQaOjb+Z4mIwOnWTXWXHtnucLzmYMRQGebR tlGruzhmgn2FDZt9YXrrDd3oMqbjQwjxu2fP1x5AdpHzqBqWzcgQUnhtmVnenILZEsCZ HiEO9elb7xlLdgnHJ/pmVbOQXvBvo7wYZxCHJlqYoMaI/X46lYcalRfH/a+52rY6x3rT wFVYu9hWD2QmTxDCmND9M3XmBH5auV2ygjW8sDJAPQzqcd/RZO7Oswdq+pCoGZDdZWRw UoLTJj71cz9DvngIh9cSfozj0Iru9CMTwgZVvQG6Fps4I+o8+jP+V5SqpR1pWZF0czoV 4gzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x9-v6si10041174plv.159.2018.04.22.09.16.11; Sun, 22 Apr 2018 09:16:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbeDVQO6 (ORCPT + 99 others); Sun, 22 Apr 2018 12:14:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44462 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbeDVNzH (ORCPT ); Sun, 22 Apr 2018 09:55:07 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 77A79710; Sun, 22 Apr 2018 13:55:06 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felipe Balbi Subject: [PATCH 4.16 019/196] usb: gadget: udc: core: update usb_ep_queue() documentation Date: Sun, 22 Apr 2018 15:50:39 +0200 Message-Id: <20180422135105.122012819@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180422135104.278511750@linuxfoundation.org> References: <20180422135104.278511750@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felipe Balbi commit eaa358c7790338d83bb6a31258bdc077de120414 upstream. Mention that ->complete() should never be called from within usb_ep_queue(). Signed-off-by: Felipe Balbi Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/core.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -238,6 +238,9 @@ EXPORT_SYMBOL_GPL(usb_ep_free_request); * arranges to poll once per interval, and the gadget driver usually will * have queued some data to transfer at that time. * + * Note that @req's ->complete() callback must never be called from + * within usb_ep_queue() as that can create deadlock situations. + * * Returns zero, or a negative error code. Endpoints that are not enabled * report errors; errors will also be * reported when the usb peripheral is disconnected.