Date: Thu, 21 Aug 2003 12:14:36 -0400
From: Jeff Garzik <jgarzik@pobox.com>
To: torvalds@osdl.org
Cc: len.brown@intel.com, andrew.grover@intel.com, zwane@linuxpower.ca,
       linux-kernel@vger.kernel.org
Subject: [PATCH] 'noapic' already handled elsewhere
Message-ID: <20030821161436.GA15610@gtf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1152
Lines: 35

I sent a previous patch to s/LOCAL_APIC/IO_APIC/, as Zwane noticed
my first patch needed that.  In that patch, I commented __setup()
would be better.

Well... line 718 of arch/i386/kernel/io_apic.c _already_ handles this
case, using __setup() properly.

Word of warning... patch only compile tested, but seems obvious from
looking at io_apic.c.

BTW, why isn't ACPI using __setup() as well?  I don't see that ACPI
needs to patch arch/i386/kernel/setup.c at all.


===== arch/i386/kernel/setup.c 1.94 vs edited =====
--- 1.94/arch/i386/kernel/setup.c	Thu Aug 21 01:32:04 2003
+++ edited/arch/i386/kernel/setup.c	Thu Aug 21 12:09:13 2003
@@ -544,12 +544,6 @@
 			if (!acpi_force) acpi_disabled = 1;
 		}
 
-#ifdef CONFIG_X86_LOCAL_APIC
-		/* disable IO-APIC */
-		else if (!memcmp(from, "noapic", 6)) {
-			skip_ioapic_setup = 1;
-		}
-#endif /* CONFIG_X86_LOCAL_APIC */
 #endif /* CONFIG_ACPI_BOOT */
 
 		/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/