Received: by 10.192.165.148 with SMTP id m20csp3039592imm; Sun, 22 Apr 2018 22:37:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx485Fq9sOIRFPaVZWHOJpsBjqTM4+EOOQ2QkbKtOdV7BLpv84vq8MraOmiiy2zL053vHWGzL X-Received: by 10.99.119.195 with SMTP id s186mr15365944pgc.296.1524461837044; Sun, 22 Apr 2018 22:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524461836; cv=none; d=google.com; s=arc-20160816; b=GEugAFU9nvPkCk4AEBRSNb3peV3RDuX5Cocepn5kfndYaBOVzPKboa7AxL3iCdpS+k sggIha/sqvtDGJXTPu7VMx/j3mmviyTCkyBx/SoWrvEZVJjTQLUJvFS5BnFCg4sdPA3p go6Am55oJfU67Q7Mb7tWspyPK6m900mDZb2WBphhj/mjTroctFeub1uwMSwwYZI4qtU5 DOpahfClgMkQZ3lCygOJH49/+VLLheBBt93y3CoHtM/noSKIQG6gKg6CSsyEgXDQacKM F09sGHH49eZEUyOwPn61Stt6Cs3B+KVJsG4/hbl/7sjFTW+nyUG/UK1+J4Yv43Arx7aq pRPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=SkJnlWhseNJHuL+lGRKac9p3ICFK8q9e05vUb/YFEjY=; b=HWVi/orq232B7JKkZhgDRtX0ADeFJPRHQlZ2vdFDcAOZc8p7plBTDn8cKFjZKgZiU3 2sxBEsoSZZRxRK9L+bYywnxxMDfGwBRVPhlPTXI9bW/1+53I+fm8YGYoFI41eFKncXdd e/Y6XRLcGkEHWACCaxK+EK4vdcmjA603YfV0rzlfX9IyobMfziD2jeXPxhBYG5EHAkIK Y4RCph2CI1P/r/9EMidX4ghkwawgh8VgnXD8/9Y7G7MKi+iWqwsyd7c9u9ppp4u11r/O I4XCm8FQK2C5mHQLnbZYqtP3LrwhbxawsOG5W7OPfxRWA/CA2x54Ewces/YT1NOcOtvG egWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kvUqfCKa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3-v6si10567999pld.9.2018.04.22.22.37.01; Sun, 22 Apr 2018 22:37:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kvUqfCKa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbeDWFfm (ORCPT + 99 others); Mon, 23 Apr 2018 01:35:42 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34096 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeDWFfg (ORCPT ); Mon, 23 Apr 2018 01:35:36 -0400 Received: by mail-pg0-f67.google.com with SMTP id p10so7598827pgn.1 for ; Sun, 22 Apr 2018 22:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SkJnlWhseNJHuL+lGRKac9p3ICFK8q9e05vUb/YFEjY=; b=kvUqfCKaDGwOzbnmlVaogf+X4OBtSotDXy7fw/yKKEaSmR4aNQPCcrniSBkz+NN3WQ wFW30WszFN/FeQ2BjucJW0LlyFSkt8tbFyFZb+FYZ8103R5Q3uwVFt6zsZFOQ+ARaLmK QEvPH0lgIUIFpXtQEUWEMsYxbpHTjCIBjQfdbRET49r7fKwlJroLkvpZ9nDJe45D5uqQ 45jkDUEkc6F+LegTlImmnbe5xG5CR63MxIiuRqDapCZSuU0d3nJeswj4H0s135BjhjC6 mxRoURWX5tK7mUzgb0KD6v9PkEN3Gy80EO5AAYHZGyHJK2aFt01l5Kawk+AAREJNhqKv t6Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SkJnlWhseNJHuL+lGRKac9p3ICFK8q9e05vUb/YFEjY=; b=E2+xbraBDrjsQgHU4hWUezUdgvm2+tCDWDR/80ImtQJf/8mRFLPn6REkUX8C3QZmZF ENJMhj1NWNsy53hICdCSCMw1XSDYtVQryMzvXotGqd7q8lu8+HxBHiNDoBnXiA27JREf AJ5ZksQLOQOohraE8Hd2D4LQqCGSfrCdkoNrYzZuRSzgFvwYN6aApvAwhqWwsQFQAH38 GheyzLhUSyOK5Eo9vz9uXAQXNY6GtsVfRisb1Ss1ozKvlFqFZQ+TQobZuPyXtJI21Wrq sIvWIwFbjt3G/nMGhmU673Ne4oE+/I9ANbVZL6rfQPc2rMqWMQq5C96tIjF3EIENE4hf rDOA== X-Gm-Message-State: ALQs6tC0w2VTT7R4qaBsbOzIL0bWvz5Sd2HvTA0yqr0wkSgB4yYjY8bn WborzuN+OcRYPVWm9aWq9xc= X-Received: by 10.99.109.138 with SMTP id i132mr16211726pgc.314.1524461735983; Sun, 22 Apr 2018 22:35:35 -0700 (PDT) Received: from localhost ([175.223.26.235]) by smtp.gmail.com with ESMTPSA id n4sm19704926pfn.2.2018.04.22.22.35.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Apr 2018 22:35:34 -0700 (PDT) Date: Mon, 23 Apr 2018 14:35:31 +0900 From: Sergey Senozhatsky To: Tejun Heo Cc: Steven Rostedt , Sergey Senozhatsky , Sergey Senozhatsky , Petr Mladek , akpm@linux-foundation.org, linux-mm@kvack.org, Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Linus Torvalds , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , rostedt@home.goodmis.org, Byungchul Park , Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup Message-ID: <20180423053531.GB3643@jagdpanzerIV> References: <20180117134201.0a9cbbbf@gandalf.local.home> <20180119132052.02b89626@gandalf.local.home> <20180120071402.GB8371@jagdpanzerIV> <20180120104931.1942483e@gandalf.local.home> <20180121141521.GA429@tigerII.localdomain> <20180123064023.GA492@jagdpanzerIV> <20180123095652.5e14da85@gandalf.local.home> <20180123152130.GB429@tigerII.localdomain> <20180123104121.2ef96d81@gandalf.local.home> <20180123154347.GE1771050@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123154347.GE1771050@devbig577.frc2.facebook.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/23/18 07:43), Tejun Heo wrote: > > > > We can have more. But if printk is causing printks, that's a major bug. > > And work queues are not going to fix it, it will just spread out the > > pain. Have it be 100 printks, it needs to be fixed if it is happening. > > And having all printks just generate more printks is not helpful. Even > > if we slow them down. They will still never end. > > So, at least in the case that we were seeing, it isn't that black and > white. printk keeps causing printks but only because printk buffer > flushing is preventing the printk'ing context from making forward > progress. The key problem there is that a flushing context may get > pinned flushing indefinitely and using a separate context does solve > the problem. Hello Tejun, I'm willing to take a look at those printk()-s from console drivers. Any chance you can send me some of the backtraces you see [the most common/disturbing]? -ss