Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/bridge/sii8620: fix link error
To:     Tobias Regnery <tobias.regnery@gmail.com>, architt@codeaurora.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     m.purski@samsung.com
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <b3a6953d-024d-e350-0729-bfbfcbbd8321@samsung.com>
Date:   Mon, 23 Apr 2018 11:22:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180423084700.27888-1-tobias.regnery@gmail.com>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20180423085639epcas3p13d9c120cba4c41bf3f0f18be25f83590@epcas3p1.samsung.com>
        <20180423084700.27888-1-tobias.regnery@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tobias,

On 23.04.2018 10:47, Tobias Regnery wrote:
> With CONFIG_EXTCON=m and CONFIG_DRM_SIL_SII8620=y we see the following link
> error:
>
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_remove':
> sil-sii8620.c:(.text+0xd5): undefined reference to `extcon_unregister_notifier'
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_probe':
> sil-sii8620.c:(.text+0x2a4b): undefined reference to `extcon_find_edev_by_node'
> sil-sii8620.c:(.text+0x2af4): undefined reference to `extcon_register_notifier'
> drivers/gpu/drm/bridge/sil-sii8620.o: In function `sii8620_extcon_work':
> sil-sii8620.c:(.text+0x2b94): undefined reference to `extcon_get_state'
>
> Fix this by selecting EXTCON.
>
> Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

There is already pending patch[1].

[1]: https://patchwork.kernel.org/patch/10330653/

Regards
Andrzej

> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 3aa65bdecb0e..ab99e36ee034 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -74,6 +74,7 @@ config DRM_SIL_SII8620
>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"
>  	depends on OF && RC_CORE
>  	select DRM_KMS_HELPER
> +	select EXTCON
>  	help
>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
>