Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Miklos Szeredi <miklos@szeredi.hu>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        "Howard McLauchlan" <hmclauchlan@fb.com>,
        Josef Bacik <jbacik@fb.com>,
        "Srikar Dronamraju" <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] tracing: remove igrab() iput() call from uprobes.c
Thread-Topic: [PATCH v3 2/2] tracing: remove igrab() iput() call from
 uprobes.c
Thread-Index: AQHT2MiZgYNckPh3sEiboRaQbyIOwKQOIy6AgAAWVYA=
Date:   Mon, 23 Apr 2018 11:23:44 +0000
Message-ID: <7D7229C8-C85F-4BE0-BBFC-4184858C311D@fb.com>
References: <20180420165625.129593-1-songliubraving@fb.com>
 <20180420165625.129593-2-songliubraving@fb.com>
 <CAJfpegu7Xogom_vMOYNaYKN4f+2h8Se94VVii2ufxaMeWhcxbQ@mail.gmail.com>
In-Reply-To: <CAJfpegu7Xogom_vMOYNaYKN4f+2h8Se94VVii2ufxaMeWhcxbQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BF071AC914E89545A2AEF10225C9ADD7@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc82f95-3a5d-4ec5-4c2f-08d5a90caca1
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 11:23:44.3278
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1482
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-23_05:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 23, 2018, at 3:03 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>=20
> On Fri, Apr 20, 2018 at 6:56 PM, Song Liu <songliubraving@fb.com> wrote:
>> Caller of uprobe_register is required to keep the inode and containing
>> mount point referenced.
>>=20
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Howard McLauchlan <hmclauchlan@fb.com>
>> Cc: Josef Bacik <jbacik@fb.com>
>> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>> Cc: Miklos Szeredi <miklos@szeredi.hu>
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> kernel/events/uprobes.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>=20
>> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
>> index ce6848e..20486bb 100644
>> --- a/kernel/events/uprobes.c
>> +++ b/kernel/events/uprobes.c
>> @@ -491,7 +491,6 @@ static struct uprobe *alloc_uprobe(struct inode *ino=
de, loff_t offset)
>>        if (!uprobe)
>>                return NULL;
>>=20
>> -       uprobe->inode =3D igrab(inode);
>=20
> Where has the assignment gone?
>=20
> Testing your changes would not hurt...
>=20
> Thanks,
> Miklos

Oops.. I tested the trace_uprobe to uprobe part of it, but didn't test
the uprobe itself. (Tested) fix coming soon.

Song=