Received: by 10.192.165.148 with SMTP id m20csp3313934imm; Mon, 23 Apr 2018 04:34:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx480iNM8hPUmD+ZOh5FFL+Y+uA4jt7y0+EqzWCvdsnH/sKkCqk1SnmqIbyxjuU48rB5FZbMW X-Received: by 2002:a17:902:b604:: with SMTP id b4-v6mr20838085pls.109.1524483266779; Mon, 23 Apr 2018 04:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524483266; cv=none; d=google.com; s=arc-20160816; b=kUhGAT1k5ggCb2Rpw76x5D180vKqSFK84WKjRk4cwUU9csx2vxpMRKHcYpEc5GO9d5 hEzceRKY9YvGE92rp7tY/JFd8F8C+erSmLBd0icziQYrd6+T2bX/cDAUImbgahGiIKMh wuD/Zm9Y0uxxIkfxNjH8RHFrkTjxW8eWC4kYAiQGFC4nnyNLJ5fyfM5TNCF/J2GlXmwE aCccJeFdTjheOHV+k2z08buCLPnU0Z0vukSSV2XRYjg+p73uDjpILBL3RCuoN+Bo5o2H j1YJQ9nJ/yr3CtfLpddFjwHTD+bW7HBvdkaKCrLdiU97ZxgHELoLQTmAW4nv7kPhJyMt 3CVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=68aCXGWS5nUs9/NkwCJ42gqcRHO5ivVcoc936G7i2no=; b=ZaSp2yG9QipJRTXoiJw68rGENkZUi+0FSH6wBJbguY+7NPVd7ijUowPh8fOBxoG4qt IslUsKDC5Izh5awIUcBGsnvLeYKCl7KK0n4hwdI35eReuhyfii/QqCypKSLn5SWP0kcA GV5sW1vGIgbHJZWFxWCe9Gl/mjPwFAbC12SN7Mwde/Z2EhMYkESMefV7ffiHntYnfB8q YAHLcxi9UL6mPR5rE1d6D5iEyjgeakKqbp3nWcpGn0FtjQGt+JcVt+40MxcMIqh1T0CR wKB3JTNlxfUPWWces7L1zJhcOLknh3/eOCsY4ynGRsIe7u4AQkTh6IZQ6u1TYnhRII2f aVxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d125si10779925pfa.263.2018.04.23.04.34.12; Mon, 23 Apr 2018 04:34:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754792AbeDWLcz (ORCPT + 99 others); Mon, 23 Apr 2018 07:32:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36554 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754624AbeDWLcv (ORCPT ); Mon, 23 Apr 2018 07:32:51 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79E44406C792; Mon, 23 Apr 2018 11:32:50 +0000 (UTC) Received: from gondolin (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB0412026DFD; Mon, 23 Apr 2018 11:32:48 +0000 (UTC) Date: Mon, 23 Apr 2018 13:32:45 +0200 From: Cornelia Huck To: Dong Jia Shi Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, borntraeger@de.ibm.com, bjsdjshi@linux.ibm.com, pasic@linux.ibm.com, pmorel@linux.ibm.com Subject: Re: [PATCH v2 0/5] vfio: ccw: error handling fixes and improvements Message-ID: <20180423133245.164c64b4.cohuck@redhat.com> In-Reply-To: <20180423110113.59385-1-bjsdjshi@linux.vnet.ibm.com> References: <20180423110113.59385-1-bjsdjshi@linux.vnet.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 23 Apr 2018 11:32:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 23 Apr 2018 11:32:50 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Apr 2018 13:01:08 +0200 Dong Jia Shi wrote: > Dear Reviewers, > > Here is a new version for this patch series. > > We didn't get agreement on patch #5 (#4 in v1) in the former cycle though, > I made it based on my understanding. We can continue discussing on it. > > Changelog: > v1->v2: > - #1. Reworded commit message and comment, plus some typo fixes. > - #2. New patch. > - #3. Added the missing suggested-by Pierre. > Fixed typos. > Added sanity check on pa->pa_iova_pfn and updated comments accordingly. > - #4. Removed unused idaw_nr. > - #5. Replaced leading white spaces with TABs. > Traced the function in anycase. > > Dong Jia Shi (3): > vfio: ccw: shorten kernel doc description for pfn_array_pin() > vfio: ccw: refactor and improve pfn_array_alloc_pin() > vfio: ccw: set ccw->cda to NULL defensively > > Halil Pasic (2): > vfio: ccw: fix cleanup if cp_prefetch fails > vfio: ccw: add traceponits for interesting error paths > > drivers/s390/cio/Makefile | 1 + > drivers/s390/cio/vfio_ccw_cp.c | 134 ++++++++++++++++++++------------------ > drivers/s390/cio/vfio_ccw_fsm.c | 16 ++++- > drivers/s390/cio/vfio_ccw_trace.h | 77 ++++++++++++++++++++++ > 4 files changed, 164 insertions(+), 64 deletions(-) > create mode 100644 drivers/s390/cio/vfio_ccw_trace.h > Out of this series, patch 1 is a fix, while the rest are improvements, correct? So patch 1 would be material for 4.17 (and maybe stable?), the rest for 4.18?