Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 23 Apr 2018 14:11:10 +0200
Message-ID: <s5hsh7mruld.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Jorge Sanjuan" <jorge.sanjuan@codethink.co.uk>
Cc:     <alsa-devel@alsa-project.org>,
        "Michael Drake" <michael.drake@codethink.co.uk>,
        <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3.
In-Reply-To: <20180420170327.31569-3-jorge.sanjuan@codethink.co.uk>
References: <20180420170327.31569-1-jorge.sanjuan@codethink.co.uk>
        <20180420170327.31569-3-jorge.sanjuan@codethink.co.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 20 Apr 2018 19:03:25 +0200,
Jorge Sanjuan wrote:
> 
> From: Michael Drake <michael.drake@codethink.co.uk>
> 
> The channel mapping is defined by bChRelationship, not bChPurpose.
> 
> Signed-off-by: Michael Drake <michael.drake@codethink.co.uk>

The change looks OK, but your sign-off is missing.
If you submit a patch, please give always your signed-off-by tag, no
matter whether it's your original patch or not.

Also, the Fixes tag would be helpful for such a correction.


thanks,

Takashi