Received: by 10.192.165.148 with SMTP id m20csp3412335imm; Mon, 23 Apr 2018 06:13:54 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/8xboRhO0iHvvK5d4ksFA8Oejj6Id1SUn80Kx/Jj8p7groKNTgYwROwlmaf0AIsZiEcMx2 X-Received: by 10.101.87.201 with SMTP id q9mr17398135pgr.215.1524489233927; Mon, 23 Apr 2018 06:13:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524489233; cv=none; d=google.com; s=arc-20160816; b=hEAUonbiMnArlkC3u+7wNI7ujV80gU/Maf00XZFfeqa+XmBCrHU9zbJgdlwbYdkKZb 7+q0h4mI4B917y/8U7Jn+QlzBqS1WTADwmVAo+KSgzjbtiK1pDTrLYwhLAEULfNotqkx Q5hK38kpJ6/Z6Ox4Yg09QK1Nk5TYPJe0xs7YFEwBfMuToln2bOTbczow2jFyw4N2Jy8k Mu0qqSSJ7QoyaT5dfAjzRu5Sz0qV+UM0oeKQVgaSoLCZ8XWLUhVwjUnRu9F6jyAMUpNN +4Zihq8x2pTmQoTCNuVcwj+BjjH+riyu1CuL5HyA5sI9WfWOnY4d14d+Ato5W31fcGp+ //OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+DjLuK/PoSrvaR9or9hwn3DhGZ/3jVQd0y+eUNs9xDI=; b=h0HaVKrVMh0YEZVsViH0C6tX/Ea7zDWfq+5kugrtGuFcsNYpsktoboAzFJ0ZP4PM45 IHRuGJ0EcWNiWRnCm6MjLIx63lkDIG0UyzQ5TbPHiUBepFNRtHjUul6bL5Ei2UC2ENAC B3dFJRLjajO8l/HpcfXSsTn517F3gUeGU1WC+CzvLfrSlSPyOe0l4TMGoBI9v/zXO2E+ Su/iFp9CdcgQFNcARI0EKGFe74ZX8QiDO7sXShA4ePRg0jzao44mhhlopZgsagMxoDfr pqoLdr2BevfUAn25VroB4MoFwHpIa+CWIPkZ2/yC9cLJWo2TAqORTl4RxDe5gtMkxX4B L/Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j22-v6si12115413pll.223.2018.04.23.06.13.39; Mon, 23 Apr 2018 06:13:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755144AbeDWNMe (ORCPT + 99 others); Mon, 23 Apr 2018 09:12:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60052 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825AbeDWNMd (ORCPT ); Mon, 23 Apr 2018 09:12:33 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id BB225D49; Mon, 23 Apr 2018 13:12:32 +0000 (UTC) Date: Mon, 23 Apr 2018 15:12:27 +0200 From: Greg Kroah-Hartman To: NeilBrown Cc: Oleg Drokin , James Simmons , Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 5/6] staging: lustre: move misc-device registration closer to related code. Message-ID: <20180423131227.GA7401@kroah.com> References: <152383910760.23409.2327082725637657049.stgit@noble> <152383935745.23409.17743342143483291145.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152383935745.23409.17743342143483291145.stgit@noble> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2018 at 10:42:37AM +1000, NeilBrown wrote: > The ioctl handler for the misc device is in lnet/libcfs/module.c > but is it registered in lnet/libcfs/linux/linux-module.c. > > Keeping related code together make maintenance easier, so move the > code. > > Signed-off-by: NeilBrown This and patch 6/6 did not apply due to something else changing these files before these were sent in. Can you rebase and resend? thanks, greg k-h