Received: by 10.192.165.148 with SMTP id m20csp3414104imm; Mon, 23 Apr 2018 06:15:32 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+WxGcOl2WxGIsPprnI2NgtFZCvFPRYZXNq/jGAaN++YY3cNVUMTA0aAkPCxZvqT/tVMs4e X-Received: by 10.99.165.79 with SMTP id r15mr17537793pgu.236.1524489332046; Mon, 23 Apr 2018 06:15:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524489332; cv=none; d=google.com; s=arc-20160816; b=gYy7OuP3BqPwF9Z3ME7GDP7UlTfSVGmHq7r5bWtLuzIehCQan10Kw4PTfSjO9QrdW1 0z2G3mPaVhD9oUqZgZNEBMpeN4KtUjI3Vfp+Fks5FyuI1ldDONUxC13JlSzkhYn9X28B HsI4tm7+Ih3PtqAbsx/A7cCtsLJDj9duNBx4HFimohxjO16cw2qWLFc8ZL79i76QZKXX ZVKTBaLR8hjbpjLmajvVq6F4bYw21rf40PSlLNoOsQDP5rGJ7mfvZ+Gz0hw9kTcjA3o5 ndVEBwyYNc9SZmyMUvLgRjuNc4bzhYuh+PFA/oDbPgGTo0tRrkOk5A29AO40iE4+qqK3 WP1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qL7fUeZWaH1Mkr3F9Jpn/NtBQ6P8gNsMh6XAQiqZK9o=; b=NS/AcVpc/zfs4mVRi1YAhCCY98QTand+H48XryivwKl1YKvmXmS5gEVi7ftAkr780A dcRYf0++ptqlA6lyA/PWzxSdxEtSz8mGPpCiQ9395emsu556MvatCx8MJsnYegR9bp86 UBQexWQtQDUZWpy/efTPVsGS9m/tfDk6p4UVjrJEoaWdkmp5UB1adtIu6seW+BW9DTj+ c68NE1BKEpn0+r/YdwxM9JcxvxZvnxaOyQ17kGGw+M1NvzFAHp7uh4LFkw8+Eu1MwxAL yrMpHIcrPaBlFNV6Zj8WT6zaHvEjI4137BCoJGu3eYjXhmmhbTklC4x5iwha9mGKjZwy H0iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si10780423pfh.3.2018.04.23.06.15.17; Mon, 23 Apr 2018 06:15:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755107AbeDWNOG (ORCPT + 99 others); Mon, 23 Apr 2018 09:14:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60208 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825AbeDWNOF (ORCPT ); Mon, 23 Apr 2018 09:14:05 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id AC2EBD50; Mon, 23 Apr 2018 13:14:04 +0000 (UTC) Date: Mon, 23 Apr 2018 15:13:59 +0200 From: Greg Kroah-Hartman To: James Simmons Cc: NeilBrown , Oleg Drokin , Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 3/6] staging: lustre: remove include/linux/libcfs/linux/linux-cpu.h Message-ID: <20180423131359.GA11836@kroah.com> References: <152383910760.23409.2327082725637657049.stgit@noble> <152383935737.23409.2271901486597092772.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 16, 2018 at 04:52:55AM +0100, James Simmons wrote: > > > This include file contains definitions used when CONFIG_SMP > > is in effect. Other includes contain corresponding definitions > > for when it isn't. > > This can be hard to follow, so move the definitions to the one place. > > > > As HAVE_LIBCFS_CPT is defined precisely when CONFIG_SMP, we discard > > that macro and just use CONFIG_SMP when needed. > > Nak. The lustre SMP is broken and needed to badly be reworked. I have it > ready and can push it. I was waiting to see if I had to rebase it once > the rc1 stuff but since their is a push to get everything out their I will > push it. A NAK on some future code that might show up someday is not how we work at all, sorry. That has caused other open source projects to die. First patch submitted "wins". And these are good patches. Nothing wrong with them, they clean stuff up, remove more lines than they added and that's the proper thing to do here. So I've applied the first 4, the last two didn't apply due to changes from you that were accepted. See, you benifit also from this :) thanks, greg k-h