Received: by 10.192.165.148 with SMTP id m20csp3763402imm; Mon, 23 Apr 2018 11:56:18 -0700 (PDT) X-Google-Smtp-Source: AIpwx48hPK0pw8ccTtcoHxpRH4F1UcR6maJ4XDV43IuJh15+sozqJja+B8X+t67lfE2v4V1qPaE+ X-Received: by 10.101.93.140 with SMTP id f12mr18294035pgt.412.1524509778224; Mon, 23 Apr 2018 11:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524509778; cv=none; d=google.com; s=arc-20160816; b=AStSatLGqpNmRINLCQBUfNwigmhUR/qymieOEp7BxPRFpEPSKlZURYxHJXAId+svfE ZCBAEqaqmg9vSw/Nzuo2Vz6JEXbMQsh/qzb6lOQA4s1geImdpJ/jpiqCOw66zX2U4K+r KhJprZ8YgqyIzk64IfEbmfXVtwikwzRZswLOb0TXKA8Mg9k0+tq1E80CP0ex3nqJXCaz 5IuCTYybeUcXvrKu63BV8HqO0PdSVR+pqTNUGYDJIe8Xhc0WrSpvaF/0bT4DQLrH/6fG X2MjT0SSoIXVWxpkFMUCDVzCxpzo2yy92z4Z17hTDZEPQKaStUH/MgJvHp8c9i3sUXVf 3FFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=ICK50OwBmIOSQJAWkuNrD50q0O5c0T5ZOvBspF029Yc=; b=rbuXxpOdJJS7e6BpKqQUCu/6G0hbLu/140nvfmdXlgYDEMnSt9elomagVFQ3L2yRfy DfuS73ld/Lie3idIYthd+KAKfG2jnOYwbWS5rsPfxowQFJnUvWLLrVCZcVRrWcMMm6Fw 8HiRCohtoPNanghEe/In8M8f/LtThpb+0EN30SBpttdswTP0GXH1/n7ROIHXHqudXL4I wsnKMfVA5bAcDucltbC564MVC2UEILKN2HGuH5P+xj8lF4QfVaW3iKltsIfrEu1dWN8G BvuNp1Cj0r3H475v3QMPFPT02CQLRZNroKb6tPi6iPsGcEct/aD63qN0uCik5Dyojc8u +Mww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si9904789pgp.278.2018.04.23.11.56.03; Mon, 23 Apr 2018 11:56:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932339AbeDWSyz (ORCPT + 99 others); Mon, 23 Apr 2018 14:54:55 -0400 Received: from anholt.net ([50.246.234.109]:60472 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932172AbeDWSyx (ORCPT ); Mon, 23 Apr 2018 14:54:53 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 852D110A138F; Mon, 23 Apr 2018 11:54:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jG8qIPD716pK; Mon, 23 Apr 2018 11:54:51 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 8DE5110A0F49; Mon, 23 Apr 2018 11:54:51 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 101602FE20E2; Mon, 23 Apr 2018 11:54:51 -0700 (PDT) From: Eric Anholt To: Stefan Schake Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Stefan Schake Subject: Re: [PATCH v4 1/2] drm/vc4: Add CTM support In-Reply-To: <20180420122545.40014-1-stschake@gmail.com> References: <20180420122545.40014-1-stschake@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 23 Apr 2018 11:54:49 -0700 Message-ID: <87fu3l4uti.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stefan Schake writes: > The hardware has a single block for applying a CTM prior to gamma lut. > It can be fed with pixels from one of our CRTC at a time and uses a > matrix with S0.9 scalars. Use private atomic state to reject attempts > from userland to apply CTM for more than one CRTC at a time and reject > matrices with scalars that we can't approximate without integer bits. Looks good! I think you got all the transition cases we were concerned about before. Reviewed and applied these two to drm-misc-next. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlreK/kACgkQtdYpNtH8 nuivrg/3QWOHIW2f3/aubiNWNFtlU7tMi41uWUWsnTpgYPd/zuiW3Waf+atMl9XX /VsiQqmJrUQAFtb2O1KAQ+CTPvi/Up9zuPDOfRc9eX1ORD/XIXoD7DfcoesfysV4 U4Oad6BjSIrxWAfkSz9h5bSo9aGktxbiQr4t2n8j349xmfrfpxLH5JtgDyuaQkZ3 KEwzjHthpnVlKrppFoLVfZtdvtX33WLj2GqAzQ21P2BewLBMWhElcqvbmZ4CW532 aGeQ/zIPzfxwl5udRJbp4yiIQ8xSv5V2kHqfZbTJUmG132Z3abPlbAGJxmF6XXOx nemnYmGP967c1yw7BUcTTUoWlWOvpdj38ZBxMAnuK5J0rtKwy0K+wTh+3dOexsGG g/HTZWEVY8Bl/AW53ZyY2Pylls7q+HCM7cP9aBJq9uqJMUU9GsQF6PryimsAVIgt dB/2lXKSL0QE4wVzTpR8L1359933ZgC1lCaLXKTmcFkevwmMzWf3pkaxeG+GPvEv imC2IUz1ayczTZm6pogr/ER/wKxqZm96JSGcKw7rnCIBTBU/7ijTUkTE4mke3Gqw HwPaculiksZLBMtQUxgDaMy7UcOQXvicw+THUpM5XaQwNbfGFYlBpDFdc1fBIpI9 0bctdpejB68pV2v8mKEDSGTrG7xPNqXbTeNAP5t0CrRGuQ6+pA== =4WJI -----END PGP SIGNATURE----- --=-=-=--