Received: by 10.192.165.148 with SMTP id m20csp3800206imm; Mon, 23 Apr 2018 12:35:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx48jHnbZwQzGpP52/u2VKCszYFpr5mtQ/gA+jqG4fSa4O4tPvamWPJRvaTGNgSYWdasMyma4 X-Received: by 10.98.156.152 with SMTP id u24mr21368066pfk.74.1524512129982; Mon, 23 Apr 2018 12:35:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524512129; cv=none; d=google.com; s=arc-20160816; b=p4U2kIA0kIvZbs2i/+APmUYQS0bfqOCykJjrLZGNdIegBE+TS/ngZTlFe0u3D/i1ZX MvUWf+ReXP1/p0zzA79RLGZ4219q81CYVJjy5XZdoMKWhLmpFCKoLXztGH/lUtIX8ruD l6yEK+1m/0azazmwsukcB/xeSwX4zLBrSkJGYLmYbHA+FxzdriN5lPkWWJBJ/YuBS3q0 8HlU9ptmz6E1BOm6UHyytw7Vh2AYPL3Co0lV2r1GTCnGgIwP9QIakuf8w3LHx59q8+jq gWCC60JUsYmjQYsoP0jCYQW7zfOlGEcBlDgJVzOQ+LmwmDu5qA5STVbycCjzpDXKFgmn kwSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=u4lj6BuWUmo6ThGQJGeyUTwPRTVJRRf7m4XaWiW1I7E=; b=vKQ8KCsVk+hqTbVnXWb3vM6a1tVoMPVjUyesZzwdLBs7FWAw+xTVov+TyLA+u7gxL1 tZSFwhRS1FT0Pu0bBlNT+uXpn3AB74Ru7QiLka23uFIDJ4ef6uFyxXSm9oMfLmtVU6CG K1FDDycBMd+cLBCQjUBVRK7qa1Pg63ibfhHmGv/AJp29+tHpR2WpdreiR+Qr52QtDoRj q6yi1OrTDD3CeJUmeN/C3Yj1VVcxDQbQ8X1f6WdYxdS90ZCcdRKAQLxfsipWe8/2kMJo OOgADrGdoWrdgNNtdt8dhFkMilChS89PqOMZLEw+EPstWqLzXfd5hJu/SXulePqcbfWZ 7Kjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eqjEeGUp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q62si10204672pga.177.2018.04.23.12.35.15; Mon, 23 Apr 2018 12:35:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eqjEeGUp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932336AbeDWTbu (ORCPT + 99 others); Mon, 23 Apr 2018 15:31:50 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:37972 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbeDWTbs (ORCPT ); Mon, 23 Apr 2018 15:31:48 -0400 Received: by mail-lf0-f67.google.com with SMTP id z130-v6so16710434lff.5 for ; Mon, 23 Apr 2018 12:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u4lj6BuWUmo6ThGQJGeyUTwPRTVJRRf7m4XaWiW1I7E=; b=eqjEeGUp5IGYJkOQBB4zYb77nu5BYOiMlPmKlvnIolec4nx/S4gB81/fIaHz/zjDVF Ws46DlZz7gsHxvBvl0UXZ8vfinxxWWy4lK0rIXHwdFf3+x0pHD751AVm/R67g8v7gFv9 PXgC6gmxdTI4tOOWErkISU4zNqNi5DnFm2McE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u4lj6BuWUmo6ThGQJGeyUTwPRTVJRRf7m4XaWiW1I7E=; b=AICLXD0L5YSqQTta925N+Mp7MrMCffcvwv/O0fKZzCRkeAgi4RC9nF7B9R2IbN8apu 3QtZN7PVU5YBuESRuapaRKfVYVtfJJkb8tuBkeXf4vaP7Y5ia1zb0yyfH5cWo8/DLRkB fDdrxMpHhTBu0tF5N+CZMDWoK6l1OY6Jrc+jqEFM1raDzey9VvNz6Z/out16iIHWiIr+ 6XwXmQh0EBVC0n0Wrs3ru+0ol7YG8htQhlPodIMFL/wpzeAoXpDESOfLx9BRdgXv0Z4g n/Y8aTxY1u0QyzNQsdvmE+sbRd7YCwbfC9n9tJqprLH6QQJ/qtXG/ncmwb1hSXJgdqPg C20A== X-Gm-Message-State: ALQs6tDk0lXHZ12wxTmkUvstmn0AJDxbv+3j7anhEfL09BqxKTHYBCIP 1Dhim9KVUC8fiBU7NLHrC8ZH9g== X-Received: by 10.46.134.136 with SMTP id l8mr15294497lji.116.1524511907254; Mon, 23 Apr 2018 12:31:47 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.cust.bredbandsbolaget.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id y1-v6sm2994584lfg.88.2018.04.23.12.31.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 12:31:46 -0700 (PDT) From: Anders Roxell To: mchehab@kernel.org, p.zabel@pengutronix.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH] drivers: media: platform: make VIDEO_VIU depend on I2C Date: Mon, 23 Apr 2018 21:31:39 +0200 Message-Id: <20180423193139.16792-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_I2C selected. drivers/media/platform/fsl-viu.c: In function ‘viu_of_probe’: drivers/media/platform/fsl-viu.c:1452:7: error: implicit declaration of function ‘i2c_get_adapter’; did you mean ‘i2c_lock_adapter’? [-Werror=implicit-function-declaration] ad = i2c_get_adapter(0); ^~~~~~~~~~~~~~~ i2c_lock_adapter drivers/media/platform/fsl-viu.c:1452:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion] ad = i2c_get_adapter(0); ^ drivers/media/platform/fsl-viu.c:1534:2: error: implicit declaration of function ‘i2c_put_adapter’; did you mean ‘i2c_lock_adapter’? [-Werror=implicit-function-declaration] i2c_put_adapter(ad); ^~~~~~~~~~~~~~~ i2c_lock_adapter Added I2C dependency in order to make all configurations work again. Signed-off-by: Anders Roxell --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 91b0c7324afb..56c205b44ee1 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -42,7 +42,7 @@ config VIDEO_SH_VOU config VIDEO_VIU tristate "Freescale VIU Video Driver" - depends on VIDEO_V4L2 && (PPC_MPC512x || COMPILE_TEST) + depends on VIDEO_V4L2 && (PPC_MPC512x || COMPILE_TEST) && I2C select VIDEOBUF_DMA_CONTIG default y ---help--- -- 2.17.0