Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Jingoo Han" <jingoohan1@gmail.com>
To:     "'Enric Balletbo i Serra'" <enric.balletbo@collabora.com>,
        <architt@codeaurora.org>, <inki.dae@samsung.com>,
        <thierry.reding@gmail.com>, <hjc@rock-chips.com>,
        <seanpaul@chromium.org>, <airlied@linux.ie>, <tfiga@chromium.org>,
        <heiko@sntech.de>
Cc:     <dri-devel@lists.freedesktop.org>, <dianders@chromium.org>,
        <a.hajda@samsung.com>, <kernel@collabora.com>,
        <m.szyprowski@samsung.com>, <linux-samsung-soc@vger.kernel.org>,
        <jy0922.shim@samsung.com>, <rydberg@bitmath.org>,
        <krzk@kernel.org>, <linux-rockchip@lists.infradead.org>,
        <kgene@kernel.org>, <orjan.eide@arm.com>, <wxt@rock-chips.com>,
        <jeffy.chen@rock-chips.com>,
        <linux-arm-kernel@lists.infradead.org>, <wzz@rock-chips.com>,
        <hl@rock-chips.com>, <sw0312.kim@samsung.com>,
        <linux-kernel@vger.kernel.org>, <kyungmin.park@samsung.com>,
        <Laurent.pinchart@ideasonboard.com>, <kuankuan.y@gmail.com>,
        <hshi@chromium.org>
References: <20180423105003.9004-1-enric.balletbo@collabora.com> <20180423105003.9004-15-enric.balletbo@collabora.com>
In-Reply-To: <20180423105003.9004-15-enric.balletbo@collabora.com>
Subject: Re: [RESEND PATCH v6 14/27] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll
Date:   Mon, 23 Apr 2018 21:25:56 -0400
Message-ID: <000001d3db6b$32a87200$97f95600$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQJsKqzGdLQ3B8H319FIYPcigFOt/AGILm3RotI/UVA=
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Monday, April 23, 2018 6:50 AM, Enric Balletbo i Serra wrote:
> 
> From: zain wang <wzz@rock-chips.com>
> 
> There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg
> list.  We should use BIT_4 in ANALOGIX_DP_PD to control the pll power
> instead of ANALOGIX_DP_PLL_CTL.
> 
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: zain wang <wzz@rock-chips.com>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Archit Taneja <architt@codeaurora.org>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
> 
>  .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> index 7b7fd227e1f9..02ab1aaa9993 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> @@ -230,16 +230,20 @@ enum pll_status
> analogix_dp_get_pll_lock_status(struct analogix_dp_device *dp)
>  void analogix_dp_set_pll_power_down(struct analogix_dp_device *dp, bool
> enable)
>  {
>  	u32 reg;
> +	u32 mask = DP_PLL_PD;
> +	u32 pd_addr = ANALOGIX_DP_PLL_CTL;
> 
> -	if (enable) {
> -		reg = readl(dp->reg_base + ANALOGIX_DP_PLL_CTL);
> -		reg |= DP_PLL_PD;
> -		writel(reg, dp->reg_base + ANALOGIX_DP_PLL_CTL);
> -	} else {
> -		reg = readl(dp->reg_base + ANALOGIX_DP_PLL_CTL);
> -		reg &= ~DP_PLL_PD;
> -		writel(reg, dp->reg_base + ANALOGIX_DP_PLL_CTL);
> +	if (dp->plat_data && is_rockchip(dp->plat_data->dev_type)) {
> +		pd_addr = ANALOGIX_DP_PD;
> +		mask = RK_PLL_PD;
>  	}
> +
> +	reg = readl(dp->reg_base + pd_addr);
> +	if (enable)
> +		reg |= mask;
> +	else
> +		reg &= ~mask;
> +	writel(reg, dp->reg_base + pd_addr);
>  }
> 
>  void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp,
> --
> 2.17.0